diff options
| author | David Wrighton <davidwr@microsoft.com> | 2019-04-03 19:11:00 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-03 19:11:00 -0700 |
| commit | 046d9d4fe9206396fac4a9e0c7b7c8b5801947b3 (patch) | |
| tree | 8034df6ea62328d4b33330c4c299c1b78d7b39cd /src/utilcode | |
| parent | ea83460f07b0f502abddbbd8f264fb66671d7fe4 (diff) | |
| download | coreclr-046d9d4fe9206396fac4a9e0c7b7c8b5801947b3.tar.gz coreclr-046d9d4fe9206396fac4a9e0c7b7c8b5801947b3.tar.bz2 coreclr-046d9d4fe9206396fac4a9e0c7b7c8b5801947b3.zip | |
Fix resource loading (#23714)
- Some resources are generated without setting a Major/Minor version in the resource directory
- This is legal, and we shouldn't skip parsing the resource
Diffstat (limited to 'src/utilcode')
| -rw-r--r-- | src/utilcode/pedecoder.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/utilcode/pedecoder.cpp b/src/utilcode/pedecoder.cpp index 7324f6e9fa..c0d0d6191a 100644 --- a/src/utilcode/pedecoder.cpp +++ b/src/utilcode/pedecoder.cpp @@ -1801,12 +1801,6 @@ DWORD PEDecoder::ReadResourceDictionary(DWORD rvaOfResourceSection, DWORD rva, L IMAGE_RESOURCE_DIRECTORY *pResourceDirectory = (IMAGE_RESOURCE_DIRECTORY *)GetRvaData(rva); - if (pResourceDirectory->MajorVersion != 4) - return 0; - - if (pResourceDirectory->MinorVersion != 0) - return 0; - // Check to see if entire resource dictionary is accessible if (!CheckRva(rva + sizeof(IMAGE_RESOURCE_DIRECTORY), (sizeof(IMAGE_RESOURCE_DIRECTORY_ENTRY) * pResourceDirectory->NumberOfNamedEntries) + |