Fix SOS managed breakpoints when coreclr symbols are stripped.

Added a SOS DAC interface (ISOSDacInterface4::GetClrNotification) to get the exception
notification arguments instead of using the GetLastExceptionInformation function from the lldb
sosplugin that depends on coreclr symbols being present.

On the coreclr side, the clr notification arguments are saved in a global variable that is DAC
accessible. A critical section was added to protect this global variable while the special
exception is raised.

Setting the internal COMPlus_DebugBreakOnAssert environment variable causes 3 or 4 breaks in
the debugger with no reason.  It was breaking in the function that was determining whether it
should break.  I was using COMPlus_BreakOnEELoad=2 to break after coreclr was loaded and initialized
to set managed breakpoints and on a debug build it generates an assert (on release just a DebugBreak).

1 files changed, 0 insertions, 19 deletions

diff --git a/src/utilcode/debug.cpp b/src/utilcode/debug.cpp
index 01963dea7d..b1fb16524b 100644
--- a/src/utilcode/debug.cpp
+++ b/src/utilcode/debug.cpp
@@ -349,13 +349,6 @@ bool _DbgBreakCheck(
     STATIC_CONTRACT_FORBID_FAULT;
     STATIC_CONTRACT_DEBUG_ONLY;
 
-    RaiseExceptionOnAssert(rTestAndRaise);
-
-    if (DebugBreakOnAssert())
-    {
-        DebugBreak();
-    }
-
     DBGIGNORE* pDBGIFNORE = GetDBGIGNORE();
     _DBGIGNOREDATA *psData;
     int i;
@@ -558,13 +551,6 @@ bool _DbgBreakCheckNoThrow(
     STATIC_CONTRACT_FORBID_FAULT;
     STATIC_CONTRACT_DEBUG_ONLY;
 
-    RaiseExceptionOnAssert(rTestAndRaise);
-
-    if (DebugBreakOnAssert())
-    {
-        DebugBreak();
-    }
-
     bool failed = false;
     bool result = false;
     EX_TRY
@@ -707,11 +693,6 @@ VOID DbgAssertDialog(const char *szFile, int iLine, const char *szExpr)
 
     RaiseExceptionOnAssert(rTestAndRaise);
 
-    if (DebugBreakOnAssert())
-    {
-        DebugBreak();
-    }
-
     BOOL fConstrained = FALSE;
 
     DWORD dwAssertStacktrace = CLRConfig::GetConfigValue(CLRConfig::INTERNAL_AssertStacktrace);