diff options
author | Aaron Robinson <arobins@microsoft.com> | 2019-05-06 10:19:49 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-05-06 10:19:49 -0700 |
commit | 099177b0899156a4e8a352083a273805240c0ccd (patch) | |
tree | 85c3f7c449ee3ed8b725c7212379914e7706e74f /src/scripts | |
parent | 7681c19e4a6f2b5a82abf6268e96eb9140f08bb7 (diff) | |
download | coreclr-099177b0899156a4e8a352083a273805240c0ccd.tar.gz coreclr-099177b0899156a4e8a352083a273805240c0ccd.tar.bz2 coreclr-099177b0899156a4e8a352083a273805240c0ccd.zip |
Port all managed product binaries to use SDK style projects (#24285)
Convert managed product binary to use SDK project system.
- Uses Arcade for versions strings
- Overrides Arcade defined output paths - should change in the future
Diffstat (limited to 'src/scripts')
-rw-r--r-- | src/scripts/check-definitions.py | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/src/scripts/check-definitions.py b/src/scripts/check-definitions.py index 4f1026d4ef..24e75b4ddb 100644 --- a/src/scripts/check-definitions.py +++ b/src/scripts/check-definitions.py @@ -27,6 +27,7 @@ from __future__ import print_function import sys import re +import os debug = 0 @@ -130,32 +131,33 @@ def printPotentiallyCritical(arrDefinitions, referencedFilename, arrIgnore): # MAIN SCRIPT if len(sys.argv) < 3: print("\nUsage:") - print("$ check-definitions.py [Definition file] [String of definitions]") + print("$ check-definitions.py [ProjectDir] [Definition file] [String of definitions]") print(" Definition file contains the list of cmake (native) compiler definitions") print(" seperated by line.") print(" String of definitions contains the list of csproj (managed) definitions") print(" seperated by semicolons.") sys.exit(-1) -filename = sys.argv[1] -string = sys.argv[2] +projectDir = sys.argv[1] +filename = sys.argv[2] +string = sys.argv[3] arrayNative = loadDefinitionFile(filename) arrayManaged = loadDefinitionString(string) arrayIgnore = [] -if len(sys.argv) > 3: - arrayIgnore = loadDefinitionString(sys.argv[3]) +if len(sys.argv) > 4: + arrayIgnore = loadDefinitionString(sys.argv[4]) arrays = getDiff(arrayNative, arrayManaged) # arrays[0] = array of added in managed # arrays[1] = array of omitted in managed (added in native) print("Potentially Dangerous Compiler Definitions in clrdefinitions.cmake (omitted in native build):") -printPotentiallyCritical(arrays[0], "../../clrdefinitions.cmake", arrayIgnore) +printPotentiallyCritical(arrays[0], os.path.join(projectDir, "clrdefinitions.cmake"), arrayIgnore) -print("Potentially Dangerous Compiler Definitions in clr.defines.targets (omitted in managed build):") -printPotentiallyCritical(arrays[1], "../../clr.defines.targets", arrayIgnore) +print("Potentially Dangerous Compiler Definitions in clr.featuredefines.props (omitted in managed build):") +printPotentiallyCritical(arrays[1], os.path.join(projectDir, "clr.featuredefines.props"), arrayIgnore) print("Definition Check Completed.") |