diff options
| author | Omair Majid <omair.majid@gmail.com> | 2017-06-07 00:19:48 -0400 |
|---|---|---|
| committer | Dan Moseley <danmose@microsoft.com> | 2017-06-06 21:19:48 -0700 |
| commit | f14cffc86b49cb803a6ed8e5a864f8c0c7b87f33 (patch) | |
| tree | a5ba526043cb04fa1d2798eb54e6102b300b6264 /src/scripts | |
| parent | c80f895350b9327868e96abb12ff7da838bc9949 (diff) | |
| download | coreclr-f14cffc86b49cb803a6ed8e5a864f8c0c7b87f33.tar.gz coreclr-f14cffc86b49cb803a6ed8e5a864f8c0c7b87f33.tar.bz2 coreclr-f14cffc86b49cb803a6ed8e5a864f8c0c7b87f33.zip | |
Fix build breakage on high-processsor machines (#12114)
The build calls `make -j $NumProc`. This breaks on machines with a high
number of procesors (such as 25).
To reproduce this on any machine, edit build.sh and change
buildTool install -j $NumProc
to
buildTool install -j 100
The error trace looks like this:
In file included from coreclr/bin/obj/Linux.x64.Debug/Generated/eventpipe/dotnetruntime.cpp:12:
In file included from coreclr/src/vm/common.h:306:
In file included from coreclr/src/vm/eepolicy.h:15:
In file included from coreclr/src/vm/vars.hpp:70:
In file included from coreclr/src/vm/eeprofinterfaces.h:19:
In file included from coreclr/src/inc/profilepriv.h:128:
In file included from coreclr/src/inc/profilepriv.inl:18:
In file included from coreclr/src/vm/eetoprofinterfaceimpl.h:23:
coreclr/src/inc/eventtracebase.h:306:10: fatal error: 'clretwallmain.h' file not found
It turns out that the eventpipe code has a dependency on
clretwallmain.h. src/CMakeLists.txt points out that clretwallmain.h is a
generated file. But there's no actual dependency between the eventpipe
target and the header file(s).
Fix that by fixing the generator script to insert an explicit dependency
between 'eventpipe' module and 'GeneratedEventingFiles' module.
Diffstat (limited to 'src/scripts')
| -rw-r--r-- | src/scripts/genEventPipe.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/scripts/genEventPipe.py b/src/scripts/genEventPipe.py index a00511d95d..4c802acaf3 100644 --- a/src/scripts/genEventPipe.py +++ b/src/scripts/genEventPipe.py @@ -262,6 +262,8 @@ def generateEventPipeCmakeFile(etwmanifest, eventpipe_directory): topCmake.write(' "eventpipehelpers.cpp"\n') topCmake.write(""" ) + add_dependencies(eventpipe GeneratedEventingFiles) + # Install the static eventpipe library install(TARGETS eventpipe DESTINATION lib) """) |