Remove mentions of Rotor from codebase (#20298)

* Moving parsing from TypeNameParser ctor to a separate method.

It seems a bit odd to have the constructor parsing and then use
a dummy method (MakeRotorHappy) to make it look more normal.

* Remove CorMarkThreadInThreadPool.

It is neither referenced nor exported.

* Remove reference to rotor from securitywrapper.h

* Remove reference to rotor from Strike/vm.cpp.

This file is only built for Windows.

* Remove reference to rotor from debugreturn.h

This is the only file the defines these macros, so there is no need to
undef them first.

* Remove unused code refering to rotor from PAL.

* Remove references to Rotor from PAL.

* Remove references to deleted tests from DisabledTests.txt

I can't find any evidence that this file is actually used.

* Remove unneeded casts.

* Remove dead and misleading code from profilinghelper.cpp.

FEATURE_PROFAPI_EVENT_LOGGING is always defined when PROFILING_SUPPORTED
is defined. And the entire contents of profilinghelper.cpp is surrounded
with "ifdef PROFILING_SUPPORTED". So all sections in
"ifndef FEATURE_PROFAPI_EVENT_LOGGING" are dead.

Furthermore, in coreclr this does not use the eventlog, so the macro name
is misleading.

* Remove dead code in excep.cpp.

This entire function is surrounded with "ifndef FEATURE_PAL".

* Remove refererences to rotor from safemath.h

This does not appear to cause any compile problems, so nobody was using
safemath.h without _ASSERTE defined.

Also S_SIZE_T_WP64BUG is not used anywhere.

* Remove dead code from palclr.h.

I don't know why these check to see if the macro is undefined immediately
after defining them.

Also the comment appears to reference some unions that are no longer in
this file.

* Expose ISymUnmanagedWriter2 from SymWriter as required by COM.

The comment talks about the C# compiler using this, however I cannot see
a way for the C# compiler to get an instance of this. It is only used
internally by AssemblyBuilder and not exposed otherwise.

* Restore check for _ASSERTE in safemath.h.

On Windows sometimes that this file is included without
_ASSERTE being defined. As the existing comment suggests, it appears
that SOS explicitly does not want _ASSERTE to do anything.

2 files changed, 4 insertions, 36 deletions

diff --git a/src/pal/tests/palsuite/DisabledTests.txt b/src/pal/tests/palsuite/DisabledTests.txt
index b3ca370586..36c09d2d9e 100644
--- a/src/pal/tests/palsuite/DisabledTests.txt
+++ b/src/pal/tests/palsuite/DisabledTests.txt
@@ -8,12 +8,12 @@ debug_api/debugbreak/test1
 debug_api/outputdebugstringa/test1
 debug_api/outputdebugstringw/test1
 debug_api/writeprocessmemory/test1
-debug_api/writeprocessmemory/test2
 debug_api/writeprocessmemory/test3
 debug_api/writeprocessmemory/test4
 =======================================
 The above testcases were disabled in the palsuite, because they depend heavily on
-WaitForDebugEvent,DebugActiveProcess and ContinueDebugEvent, where these api's have been removed from the PAL and listed in the rotor_pal.doc (6.0)
+WaitForDebugEvent,DebugActiveProcess and ContinueDebugEvent, where these api's
+have been removed from the PAL.
 
 
 file_io/gettempfilenamea/test2 :
@@ -86,38 +86,6 @@ pal_specific/pal_get_stdin/test1 :
 =======================================
 This test case should be run manually.  Requires user input.
 
-
-threading/setconsolectrlhandler/test1
-threading/setconsolectrlhandler/test2
-threading/setconsolectrlhandler/test3
-threading/setconsolectrlhandler/test4
-=======================================
-These tests cases should be run manually.  Requires user input.
-
-threading/getprocesstimes/test1
-=======================================
-According to rotor_pal.doc, GetProcessTimes() should be supported for the current 
-process only. I've removed this test because it tests GetProcessTimes() with 
-invalid process handle value.
-
-threading/getthreadcontext/test1,1
-=======================================
-According to rotor_pal.doc, when GetThreadContext is call for a thread within 
-the same process, it could only be called for te current thread. I've removed
-this test, because it tests GetThreadContext() with a non current thread handle 
-belong the current procees.
-
-loader/loadlibrarya/test4
-loader/loadlibraryw/test4
-=======================================
-PAL BSD should not append the .so extension in LoadLibrary if the extension is 
-omitted.
-file_io/deletefilea/test3
-file_io/deletefilew/test3
-=======================================
-No code in Rotor depends on DeleteFile[A/W] failing on readonly files so we 
-don't need to exactly emulate this feature of the Win32 filesystems on FreeBSD.
-
 filemapping_memmgt\MapViewOfFile\test1
 =======================================
-Refer this github issue https://github.com/dotnet/coreclr/issues/5176
\ No newline at end of file
+Refer this github issue https://github.com/dotnet/coreclr/issues/5176
diff --git a/src/pal/tests/palsuite/c_runtime/errno/test1/test1.cpp b/src/pal/tests/palsuite/c_runtime/errno/test1/test1.cpp
index 3ae25fb02a..e1dd4a6b36 100644
--- a/src/pal/tests/palsuite/c_runtime/errno/test1/test1.cpp
+++ b/src/pal/tests/palsuite/c_runtime/errno/test1/test1.cpp
@@ -25,7 +25,7 @@ int __cdecl main(int argc, char *argv[])
     }
     
     /* 
-       From rotor.doc:  The only value that must be supported is 
+       The only value that must be supported is
        ERANGE, in the event that wcstoul() fails due to overflow. 
     */