diff options
author | Jan Vorlicek <janvorli@microsoft.com> | 2018-06-28 13:47:34 +0200 |
---|---|---|
committer | Jan Kotas <jkotas@microsoft.com> | 2018-06-28 04:47:34 -0700 |
commit | 83bdd210b40dac4d42ca8775bfe63d935ab9af2c (patch) | |
tree | b4b9208ea81ff544161ce41ae487c6c2da6f2311 /src/pal/src/exception/signal.cpp | |
parent | 1a34c72e9e719c9d3879c2a519bf70a05f42869c (diff) | |
download | coreclr-83bdd210b40dac4d42ca8775bfe63d935ab9af2c.tar.gz coreclr-83bdd210b40dac4d42ca8775bfe63d935ab9af2c.tar.bz2 coreclr-83bdd210b40dac4d42ca8775bfe63d935ab9af2c.zip |
Fix alternate stack cleanup on MUSL (#18685)
The MUSL implementation of sigaltstack checks that the ss.ss_size is
larger or equal than the MINSIGSTKSZ even when the ss_flags is set
to SS_DISABLE even though Linux man page for sigaltstack states that
when this flag is set, all other ss fields are ignored.
We were not setting the ss_size in this case and it was causing a memory
leak for each thread that has terminated on MUSL based Linux distros
like Alpine.
Glibc implementation doesn't check the ss_size when the SS_DISABLE is set
so the problem was really MUSL specific.
Diffstat (limited to 'src/pal/src/exception/signal.cpp')
-rw-r--r-- | src/pal/src/exception/signal.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/pal/src/exception/signal.cpp b/src/pal/src/exception/signal.cpp index 458e331698..7f2e5c5b3d 100644 --- a/src/pal/src/exception/signal.cpp +++ b/src/pal/src/exception/signal.cpp @@ -199,6 +199,10 @@ Return : void FreeSignalAlternateStack() { stack_t ss, oss; + // The man page for sigaltstack says that when the ss.ss_flags is set to SS_DISABLE, + // all other ss fields are ignored. However, MUSL implementation checks that the + // ss_size is >= MINSIGSTKSZ even in this case. + ss.ss_size = MINSIGSTKSZ; ss.ss_flags = SS_DISABLE; int st = sigaltstack(&ss, &oss); if ((st == 0) && (oss.ss_flags != SS_DISABLE)) |