diff options
| author | Atsushi Kanamori <AtsushiKan@users.noreply.github.com> | 2018-03-20 14:14:41 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-03-20 14:14:41 -0700 |
| commit | e0fa11308de58684cde6bf8b7d0da287b48f01e9 (patch) | |
| tree | 300aff8cbfb435661fa2ea1041b61227254ac37f /src/mscorlib/shared/System.Private.CoreLib.Shared.projitems | |
| parent | 0597eed6a6674ad0b0f531a851475c212c7478c5 (diff) | |
| download | coreclr-e0fa11308de58684cde6bf8b7d0da287b48f01e9.tar.gz coreclr-e0fa11308de58684cde6bf8b7d0da287b48f01e9.tar.bz2 coreclr-e0fa11308de58684cde6bf8b7d0da287b48f01e9.zip | |
Port System.Memory performance improvements to Convert.TryFromBase64Chars (#17033)
* Copy over Base64.DecodeFromUtf8 verbatim
* Don't need the InPlace api
* Change input from Utf8 to Utf16
* isFinalBlock will always be true, so constant fold it through
* I only need a true/false result, so get rid of OperationStatus
* Rename variables to reflect Utf8->Utf16 change
* Update comments and some minor cleanup
* Make Convert use Base64 as a fast-path
* Incorporate PR feedback.
* Delete FromBase64_Decode
* Use a single safe stackalloc
* Rename Base64.cs to Convert.Base64.cs
and make its contents a part of the Convert class.
We should eventually move all the Base64-related
stuff into this new file but not as part of this PR.
We want to be able to diff the implementation change
separately from the code movement.
* Thanks VS for the unasked for indent
Diffstat (limited to 'src/mscorlib/shared/System.Private.CoreLib.Shared.projitems')
| -rw-r--r-- | src/mscorlib/shared/System.Private.CoreLib.Shared.projitems | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mscorlib/shared/System.Private.CoreLib.Shared.projitems b/src/mscorlib/shared/System.Private.CoreLib.Shared.projitems index 2bc6464e97..270d06d3c4 100644 --- a/src/mscorlib/shared/System.Private.CoreLib.Shared.projitems +++ b/src/mscorlib/shared/System.Private.CoreLib.Shared.projitems @@ -94,6 +94,7 @@ <Compile Include="$(MSBuildThisFileDirectory)System\Configuration\Assemblies\AssemblyHashAlgorithm.cs" /> <Compile Include="$(MSBuildThisFileDirectory)System\Configuration\Assemblies\AssemblyVersionCompatibility.cs" /> <Compile Include="$(MSBuildThisFileDirectory)System\Convert.cs" /> + <Compile Include="$(MSBuildThisFileDirectory)System\Convert.Base64.cs" /> <Compile Include="$(MSBuildThisFileDirectory)System\CurrentSystemTimeZone.cs" /> <Compile Include="$(MSBuildThisFileDirectory)System\DataMisalignedException.cs" /> <Compile Include="$(MSBuildThisFileDirectory)System\DateTime.cs" /> |