summaryrefslogtreecommitdiff
path: root/src/jit
diff options
context:
space:
mode:
authorTanner Gooding <tagoo@outlook.com>2018-02-21 22:57:05 -0800
committerTanner Gooding <tagoo@outlook.com>2018-02-22 20:49:38 -0800
commitd502a55d245d889c37e1b57d869f3aa7d26535c0 (patch)
treef7799a28da9b7141e2469de5ea17d865af42dc22 /src/jit
parent794a2f9f134b97dc351b1b62fa0bb28f27fea59f (diff)
downloadcoreclr-d502a55d245d889c37e1b57d869f3aa7d26535c0.tar.gz
coreclr-d502a55d245d889c37e1b57d869f3aa7d26535c0.tar.bz2
coreclr-d502a55d245d889c37e1b57d869f3aa7d26535c0.zip
Adding a TODO-XArch to `Lowering::ContainCheckHWIntrinsic` to track https://github.com/dotnet/coreclr/issues/16497
Diffstat (limited to 'src/jit')
-rw-r--r--src/jit/hwintrinsiccodegenxarch.cpp2
-rw-r--r--src/jit/lowerxarch.cpp6
2 files changed, 7 insertions, 1 deletions
diff --git a/src/jit/hwintrinsiccodegenxarch.cpp b/src/jit/hwintrinsiccodegenxarch.cpp
index 9a0363f6a1..a4fc9f1875 100644
--- a/src/jit/hwintrinsiccodegenxarch.cpp
+++ b/src/jit/hwintrinsiccodegenxarch.cpp
@@ -244,7 +244,7 @@ void CodeGen::genHWIntrinsic_FullRangeImm8(GenTreeHWIntrinsic* node, instruction
else
{
// We emit a fallback case for the scenario when op3 is not a constant. This should normally
- // happen when the intrinsic is called indirectly, such as via Reflection. However, it can
+ // only happen when the intrinsic is called indirectly, such as via Reflection. However, it can
// also occur if the consumer calls it directly and just doesn't pass a constant value.
const unsigned jmpCount = 256;
diff --git a/src/jit/lowerxarch.cpp b/src/jit/lowerxarch.cpp
index 376c3194d3..8eb9e164cf 100644
--- a/src/jit/lowerxarch.cpp
+++ b/src/jit/lowerxarch.cpp
@@ -2406,6 +2406,9 @@ void Lowering::ContainCheckHWIntrinsic(GenTreeHWIntrinsic* node)
break;
default:
+ // TODO-XArch-CQ: Assert that this is unreached after we have ensured the relevant node types are
+ // handled.
+ // https://github.com/dotnet/coreclr/issues/16497
break;
}
}
@@ -2426,6 +2429,9 @@ void Lowering::ContainCheckHWIntrinsic(GenTreeHWIntrinsic* node)
}
default:
+ // TODO-XArch-CQ: Assert that this is unreached after we have ensured the relevant node types are
+ // handled.
+ // https://github.com/dotnet/coreclr/issues/16497
break;
}
}