diff options
| author | Carol Eidt <carol.eidt@microsoft.com> | 2018-06-13 14:43:07 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-06-13 14:43:07 -0700 |
| commit | 82134a002fed96739694b6f085baaeea6c7c41f5 (patch) | |
| tree | 2d608f102c9f4d6908ff8d6641c3c109ee557fff /src/jit/lower.cpp | |
| parent | 1d83f170fdf7ed6ade3e49799724e0ac17769a09 (diff) | |
| download | coreclr-82134a002fed96739694b6f085baaeea6c7c41f5.tar.gz coreclr-82134a002fed96739694b6f085baaeea6c7c41f5.tar.bz2 coreclr-82134a002fed96739694b6f085baaeea6c7c41f5.zip | |
Fix enregistered lclFld bug (#18418)
* Fix enregistered lclFld bug
In `impFixupStructReturnType()`, don't transform to `GT_LCL_FLD` if we have a scalar lclVar.
Also, to avoid future bad codegen, add verification and recovery code to Lowering.
Fix #18408
* Extract the full conditions for whether a lclVar is a reg candidate, so it can be called from the assert in Lowering.
* Review feedback
Diffstat (limited to 'src/jit/lower.cpp')
| -rw-r--r-- | src/jit/lower.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/jit/lower.cpp b/src/jit/lower.cpp index f45dadc929..defc34c398 100644 --- a/src/jit/lower.cpp +++ b/src/jit/lower.cpp @@ -269,6 +269,13 @@ GenTree* Lowering::LowerNode(GenTree* node) break; #endif // FEATURE_HW_INTRINSICS + case GT_LCL_FLD: + { + // We should only encounter this for lclVars that are lvDoNotEnregister. + verifyLclFldDoNotEnregister(node->AsLclVarCommon()->gtLclNum); + break; + } + case GT_LCL_VAR: WidenSIMD12IfNecessary(node->AsLclVarCommon()); break; |