diff options
author | Carol Eidt <carol.eidt@microsoft.com> | 2019-03-28 11:23:10 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-03-28 11:23:10 -0700 |
commit | 3d4a1d5cea0ae71eed1482990ce6e575049829d8 (patch) | |
tree | fd3ea00fbd67bec2b6f6ec0966ef2bd34ea0c01d /src/jit/lower.cpp | |
parent | a32f7e6b176fc18973581d48d919112d66e321aa (diff) | |
download | coreclr-3d4a1d5cea0ae71eed1482990ce6e575049829d8.tar.gz coreclr-3d4a1d5cea0ae71eed1482990ce6e575049829d8.tar.bz2 coreclr-3d4a1d5cea0ae71eed1482990ce6e575049829d8.zip |
Struct & SIMD improvements (#22255)
* [WIP] Struct & SIMD improvements
- Enable CSE of struct values when handle is available (and add code to get the handle of HW SIMD types)
- Don't require block nodes for SIMD assignments
- Don't set `GTF_GLOB_REF` on `GT_OBJ` if it is local
- Set `lvRegStruct` on promoted SIMD fields
- Add tests for #19910 (fixed with this PR) and #3539 & #19438 (fixed with #21314)
- Additional cleanup
Fix #19910
Diffstat (limited to 'src/jit/lower.cpp')
-rw-r--r-- | src/jit/lower.cpp | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/jit/lower.cpp b/src/jit/lower.cpp index fc507c4c50..01f181f5ba 100644 --- a/src/jit/lower.cpp +++ b/src/jit/lower.cpp @@ -1765,11 +1765,7 @@ void Lowering::CheckVSQuirkStackPaddingNeeded(GenTreeCall* call) if (op1->OperGet() == GT_LCL_VAR_ADDR) { unsigned lclNum = op1->AsLclVarCommon()->GetLclNum(); - // TODO-1stClassStructs: This is here to duplicate previous behavior, - // but is not needed because the scenario being quirked did not involve - // a SIMD or enregisterable struct. - // if(comp->lvaTable[lclNum].TypeGet() == TYP_STRUCT) - if (varTypeIsStruct(comp->lvaTable[lclNum].TypeGet())) + if (comp->lvaGetDesc(lclNum)->TypeGet() == TYP_STRUCT) { // First arg is addr of a struct local. paddingNeeded = true; |