Inliner refactoring: allow repeated bad observations

The LegacyPolicy now allows repeated observations leading to never
or failing inlines, provided the policy is used as part of the prejit
scan and the observations all have the same impact (that is, all nevers
or all failures). Only the first bad observation is remembered and it
is used as the reason for badness.

This addresses another of the items in issue #3371.

Also, clean up a few things:

Fix a few copy and paste errors in comment headers.

Fix broken "disallow copy-assignment" pattern for InlineResult
and uncomment and fix same for InlinePolicy.

Remove an accidentally duplicated comment block (original is still
there in inline.h).

1 files changed, 2 insertions, 2 deletions

diff --git a/src/jit/inline.h b/src/jit/inline.h
index 4f3e0290b8..5a4012bdd9 100644
--- a/src/jit/inline.h
+++ b/src/jit/inline.h
@@ -249,7 +249,7 @@ private:
 
     // No copying or assignment supported
     InlinePolicy(const InlinePolicy&) = delete;
-    // InlinePolicy operator=(const InlinePolicy&) = delete;
+    InlinePolicy& operator=(const InlinePolicy&) = delete;
 
 protected:
 
@@ -413,7 +413,7 @@ private:
 
     // No copying or assignment allowed.
     InlineResult(const InlineResult&) = delete;
-    InlineResult operator=(const InlineResult&) = delete;
+    InlineResult& operator=(const InlineResult&) = delete;
 
     // Report/log/dump decision as appropriate
     void report();