diff options
| author | Omair Majid <omajid@redhat.com> | 2019-06-07 16:49:52 -0400 |
|---|---|---|
| committer | Jan Vorlicek <janvorli@microsoft.com> | 2019-06-07 22:49:52 +0200 |
| commit | 3fcaf0373369ed4b17bd1ed068592c2e0cec3997 (patch) | |
| tree | a751b81233e46f1163ffd2bacf31697cea72231c /src/jit/compiler.h | |
| parent | b314ed86b11756834b0936e56c3d841e7407f81d (diff) | |
| download | coreclr-3fcaf0373369ed4b17bd1ed068592c2e0cec3997.tar.gz coreclr-3fcaf0373369ed4b17bd1ed068592c2e0cec3997.tar.bz2 coreclr-3fcaf0373369ed4b17bd1ed068592c2e0cec3997.zip | |
Do not delete polymorphic objects without a virtual destructor (#23705)
SEI CERT C++ Coding Standard says:
> Do not delete an object of derived class type through a pointer to its
> base class type that has a non-virtual destructor. Instead, the base
> class should be defined with a virtual destructor. Deleting an object
> through a pointer to a type without a virtual destructor results in
> undefined behavior.
See https://wiki.sei.cmu.edu/confluence/display/cplusplus/OOP52-CPP.+Do+not+delete+a+polymorphic+object+without+a+virtual+destructor
Clang generally warns about this, but we disabled the warning via
-Wno-delete-non-virtual-dtor. This commit re-enables the warning and
fixes up all the code that hits the warning.
Diffstat (limited to 'src/jit/compiler.h')
0 files changed, 0 insertions, 0 deletions