diff options
| author | Koundinya Veluri <kouvel@users.noreply.github.com> | 2017-09-26 13:14:53 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-26 13:14:53 -0700 |
| commit | 8f0ac5d2041d0c577607e2f778f2fbca1f7d732e (patch) | |
| tree | 23e191f0f10287d162ef53b4a2b77d9170ac7615 /src/inc | |
| parent | 296aaf12b40ddd7478b6a14d6099f48b4b049438 (diff) | |
| download | coreclr-8f0ac5d2041d0c577607e2f778f2fbca1f7d732e.tar.gz coreclr-8f0ac5d2041d0c577607e2f778f2fbca1f7d732e.tar.bz2 coreclr-8f0ac5d2041d0c577607e2f778f2fbca1f7d732e.zip | |
Remove Monitor asm helpers (#14146)
- Removed asm helpers on Windows and used portable C++ helpers instead
- Rearranged fast path code to improve them a bit and match the asm more closely
Perf:
- The asm helpers are a bit faster. The code generated for the portable helpers is almost the same now, the remaining differences are:
- There were some layout issues where hot paths were in the wrong place and return paths were not cloned. Instrumenting some of the tests below with PGO on x64 resolved all of the layout issues. I couldn't get PGO instrumentation to work on x86 but I imagine it would be the same there.
- Register usage
- x64: All of the Enter functions are using one or two (TryEnter is using two) callee-saved registers for no apparent reason, forcing them to be saved and restored. r10 and r11 seem to be available but they're not being used.
- x86: Similarly to x64, the compiled functions are pushing and popping 2-3 additional registers in the hottest fast paths.
- I believe this is the main remaining gap and PGO is not helping with this
- On Linux, perf is >= before for the most part
- Perf tests used for below are updated in PR https://github.com/dotnet/coreclr/pull/13670
Diffstat (limited to 'src/inc')
| -rw-r--r-- | src/inc/jithelpers.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/inc/jithelpers.h b/src/inc/jithelpers.h index b45948ac59..43b75293ae 100644 --- a/src/inc/jithelpers.h +++ b/src/inc/jithelpers.h @@ -134,17 +134,10 @@ JITHELPER(CORINFO_HELP_ENDCATCH, JIT_EndCatch, CORINFO_HELP_SIG_CANNOT_USE_ALIGN_STUB) #endif -#ifdef _TARGET_AMD64_ - DYNAMICJITHELPER(CORINFO_HELP_MON_ENTER, JIT_MonEnterWorker, CORINFO_HELP_SIG_REG_ONLY) - DYNAMICJITHELPER(CORINFO_HELP_MON_EXIT, JIT_MonExitWorker, CORINFO_HELP_SIG_REG_ONLY) - DYNAMICJITHELPER(CORINFO_HELP_MON_ENTER_STATIC, JIT_MonEnterStatic,CORINFO_HELP_SIG_REG_ONLY) - DYNAMICJITHELPER(CORINFO_HELP_MON_EXIT_STATIC, JIT_MonExitStatic,CORINFO_HELP_SIG_REG_ONLY) -#else JITHELPER(CORINFO_HELP_MON_ENTER, JIT_MonEnterWorker, CORINFO_HELP_SIG_REG_ONLY) JITHELPER(CORINFO_HELP_MON_EXIT, JIT_MonExitWorker, CORINFO_HELP_SIG_REG_ONLY) JITHELPER(CORINFO_HELP_MON_ENTER_STATIC, JIT_MonEnterStatic,CORINFO_HELP_SIG_REG_ONLY) JITHELPER(CORINFO_HELP_MON_EXIT_STATIC, JIT_MonExitStatic,CORINFO_HELP_SIG_REG_ONLY) -#endif JITHELPER(CORINFO_HELP_GETCLASSFROMMETHODPARAM, JIT_GetClassFromMethodParam, CORINFO_HELP_SIG_REG_ONLY) JITHELPER(CORINFO_HELP_GETSYNCFROMCLASSHANDLE, JIT_GetSyncFromClassHandle, CORINFO_HELP_SIG_REG_ONLY) |