diff options
| author | Mike McLaughlin <mikem@microsoft.com> | 2016-02-08 17:47:31 -0800 |
|---|---|---|
| committer | Mike McLaughlin <mikem@microsoft.com> | 2016-02-10 13:38:08 -0800 |
| commit | 7d74570d33823d4734fa287bc21a81ff12f7b40a (patch) | |
| tree | a5c30abede3ac0679554444651fa1026288ae594 /src/inc/dacvars.h | |
| parent | ceb0a800ad650a36a32e543146669e9f3654e948 (diff) | |
| download | coreclr-7d74570d33823d4734fa287bc21a81ff12f7b40a.tar.gz coreclr-7d74570d33823d4734fa287bc21a81ff12f7b40a.tar.bz2 coreclr-7d74570d33823d4734fa287bc21a81ff12f7b40a.zip | |
Fix SOS managed breakpoints when coreclr symbols are stripped.
Added a SOS DAC interface (ISOSDacInterface4::GetClrNotification) to get the exception
notification arguments instead of using the GetLastExceptionInformation function from the lldb
sosplugin that depends on coreclr symbols being present.
On the coreclr side, the clr notification arguments are saved in a global variable that is DAC
accessible. A critical section was added to protect this global variable while the special
exception is raised.
Setting the internal COMPlus_DebugBreakOnAssert environment variable causes 3 or 4 breaks in
the debugger with no reason. It was breaking in the function that was determining whether it
should break. I was using COMPlus_BreakOnEELoad=2 to break after coreclr was loaded and initialized
to set managed breakpoints and on a debug build it generates an assert (on release just a DebugBreak).
Diffstat (limited to 'src/inc/dacvars.h')
| -rw-r--r-- | src/inc/dacvars.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/inc/dacvars.h b/src/inc/dacvars.h index 310717ba43..05e00d5552 100644 --- a/src/inc/dacvars.h +++ b/src/inc/dacvars.h @@ -333,6 +333,8 @@ DEFINE_DACVAR(ULONG, DWORD, dac__g_MiniMetaDataBuffMaxSize, ::g_MiniMetaDataBuff DEFINE_DACVAR(ULONG, TADDR, dac__g_MiniMetaDataBuffAddress, ::g_MiniMetaDataBuffAddress) #endif // FEATURE_MINIMETADATA_IN_TRIAGEDUMPS +DEFINE_DACVAR(ULONG, SIZE_T, dac__g_clrNotificationArguments, ::g_clrNotificationArguments) + #undef DEFINE_DACVAR #undef DEFINE_DACVAR_SVR #undef DEFINE_DACVAR_NO_DUMP |