diff options
author | Jan Vorlicek <janvorli@microsoft.com> | 2015-03-27 23:30:10 +0100 |
---|---|---|
committer | Jan Vorlicek <janvorli@microsoft.com> | 2015-04-01 21:39:28 +0200 |
commit | de8b85b643ac08d69696ad078846424b69ae651f (patch) | |
tree | 3c8f416945ebb2768eeb1f26a5d09b5f4dcb2202 /src/inc/ceefilegenwriter.h | |
parent | 898cdcf05ae334252b354a1f5bae9e26be1912ec (diff) | |
download | coreclr-de8b85b643ac08d69696ad078846424b69ae651f.tar.gz coreclr-de8b85b643ac08d69696ad078846424b69ae651f.tar.bz2 coreclr-de8b85b643ac08d69696ad078846424b69ae651f.zip |
Fix next round of warning types
This change fixes the following warnings:
1) Assignment in a condition should be wrapped in ()
2) Priority of && / || should be indicated by parentheses.
3) Unknown #pragma optimize ifdefed out for non MSVC
4) Unused functions deleted or put under #ifdef
5) Extra tokens warning disabling moved to the CMakeLists.txt in the src/inc
6) Self assignment of a member or local variable
7) Assigning ~0 to a bitfield member that was just 8 bit wide
It also fixes a bug in the STRESS_LOGxx macro invocation in exceptionhandling.cpp and
stackwalk.cpp related to recent adding the DBG_ADDR macro usage. This macro expanded
a single parameter into two expressions to extract high / low 32 bits separately.
But the STRESS_LOGxx parameters are passed to the StressLog::LogMsg method as follows:
(void*)(size_t)(data1)
That means that the expanded pair x, y would be inserted as data 1 and that leads
to ignoring the x due to the comma operator.
Diffstat (limited to 'src/inc/ceefilegenwriter.h')
-rw-r--r-- | src/inc/ceefilegenwriter.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/inc/ceefilegenwriter.h b/src/inc/ceefilegenwriter.h index cbd5d87596..5d0df4da0c 100644 --- a/src/inc/ceefilegenwriter.h +++ b/src/inc/ceefilegenwriter.h @@ -190,7 +190,7 @@ inline LPWSTR CeeFileGenWriter::getResourceFileName() { } inline HRESULT CeeFileGenWriter::setDllSwitch(bool dllSwitch) { - if(m_dllSwitch = dllSwitch) m_objSwitch = FALSE; return S_OK; + if((m_dllSwitch = dllSwitch)) m_objSwitch = FALSE; return S_OK; } inline bool CeeFileGenWriter::getDllSwitch() { @@ -198,7 +198,7 @@ inline bool CeeFileGenWriter::getDllSwitch() { } inline HRESULT CeeFileGenWriter::setObjSwitch(bool objSwitch) { - if(m_objSwitch = objSwitch) m_dllSwitch = FALSE; return S_OK; + if((m_objSwitch = objSwitch)) m_dllSwitch = FALSE; return S_OK; } inline bool CeeFileGenWriter::getObjSwitch() { |