GC OS interface refactoring

This change replaces all calls of OS specific functions in the GC by a call to
a platform agnostic interface. Critical sections were abstracted too.
The logging file access was changed to use CRT functions instead of Windows specific APIs.
A "size" member was added to the card_table_info so that we can pass the right
size to the VirtualRelease method when destroying the card table.
I have also fixed a bug in the gc_heap::make_card_table error path where when VirtualCommit
failed, it called VirtualRelease with size that was not the reserved size, but
the committed size.
Other related changes
- All interlocked operations moved to Interlocked class as static methods
- Removed unused function prototypes
- Shuffled stuff in the root CMakeLists.txt to enable building the GC sample using the
  settings inherited from the root CMakeLists.txt and to clean up some things that have
  rotted over time, like the FEATURE_xxx macros not being in one alphabetically ordered
  block
- Fixed the VOLATILE_MEMORY_BARRIER macro in the gcenv.base.h
- Replaced uint32_t thread id by EEThreadId
- Removed thread handles storage (g_gc_thread) from the GC. The thread handle is closed right after the thread is launched. That allowed me to get rid of the GCThreadHandle
- Renamed the methods of the EEThreadId to be easier to understand
- Moved the gcenv.windows.cpp and gcenv.unix.cpp to the sample folder

1 files changed, 9 insertions, 22 deletions

diff --git a/src/gc/env/gcenv.sync.h b/src/gc/env/gcenv.sync.h
index c3aea23fde..fe619cc696 100644
--- a/src/gc/env/gcenv.sync.h
+++ b/src/gc/env/gcenv.sync.h
@@ -7,19 +7,6 @@
 //
 // Helper classes expected by the GC
 //
-class EEThreadId
-{
-public:
-    EEThreadId(uint32_t uiId) : m_uiId(uiId) {}
-    bool IsSameThread()
-    {
-        return m_uiId == GetCurrentThreadId();
-    }
-
-private:
-    uint32_t m_uiId;
-};
-
 #define CRST_REENTRANCY         0
 #define CRST_UNSAFE_SAMELEVEL   0
 #define CRST_UNSAFE_ANYMODE     0
@@ -33,37 +20,37 @@ typedef int CrstType;
 
 class CrstStatic
 {
-    CRITICAL_SECTION m_cs;
+    CLRCriticalSection m_cs;
 #ifdef _DEBUG
-    uint32_t m_holderThreadId;
+    EEThreadId m_holderThreadId;
 #endif
 
 public:
     bool InitNoThrow(CrstType eType, CrstFlags eFlags = CRST_DEFAULT)
     {
-        UnsafeInitializeCriticalSection(&m_cs);
+        m_cs.Initialize();
         return true;
     }
 
     void Destroy()
     {
-        UnsafeDeleteCriticalSection(&m_cs);
+        m_cs.Destroy();
     }
 
     void Enter()
     {
-        UnsafeEEEnterCriticalSection(&m_cs);
+        m_cs.Enter();
 #ifdef _DEBUG
-        m_holderThreadId = GetCurrentThreadId();
+        m_holderThreadId.SetToCurrentThread();
 #endif
     }
 
     void Leave()
     {
 #ifdef _DEBUG
-        m_holderThreadId = 0;
+        m_holderThreadId.Clear();
 #endif
-        UnsafeEELeaveCriticalSection(&m_cs);
+        m_cs.Leave();
     }
 
 #ifdef _DEBUG
@@ -74,7 +61,7 @@ public:
 
     bool OwnedByCurrentThread()
     {
-        return GetHolderThreadId().IsSameThread();
+        return GetHolderThreadId().IsCurrentThread();
     }
 #endif
 };