summaryrefslogtreecommitdiff
path: root/src/dlls/mscordac
diff options
context:
space:
mode:
authorJan Vorlicek <janvorli@microsoft.com>2015-03-26 08:19:22 +0100
committerJan Vorlicek <janvorli@microsoft.com>2015-03-26 09:03:20 +0100
commit1e787356393276f38f4600232722076d2d9311e2 (patch)
tree35e1a5c85a1c375e681c9b0c45013317ce6e25a6 /src/dlls/mscordac
parentab0fb914d6efde5c0b59e7edbbfd04016232c96b (diff)
downloadcoreclr-1e787356393276f38f4600232722076d2d9311e2.tar.gz
coreclr-1e787356393276f38f4600232722076d2d9311e2.tar.bz2
coreclr-1e787356393276f38f4600232722076d2d9311e2.zip
Fix about 12 kinds of warnings over the codebase
This change fixes: 1) Member initiazalization order in class constructor didn't correspond to the member order in some classes 2) Objects with vtables were copied via memcpy. While this is intentional, cast of the pointers to void* is required to silence clang warning 3) Switch case statements containing values of different enums 4) Casting int to pointer 5) Missing return value in methods with _ASSERTE 6) Class name classifier on methods in the .h 7) Invalid position of the DECLSPEC_ALIGN at few places - it had no effect 8) Invalid position of the 'used' attribute 9) Issue with comparing holders to NULL 10) Operator 'new' returning NULL without being marked with throw() or noexcept 11) Variables marked as 'extern' at the declaration / initialization place 12) Data structure declared as struct at one place and forward declared as class at another Some disabled warnings were no longer happening, so options to disable them were removed too
Diffstat (limited to 'src/dlls/mscordac')
-rw-r--r--src/dlls/mscordac/mscordac.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/dlls/mscordac/mscordac.cpp b/src/dlls/mscordac/mscordac.cpp
index ecb9e48ae1..3d5c527ac2 100644
--- a/src/dlls/mscordac/mscordac.cpp
+++ b/src/dlls/mscordac/mscordac.cpp
@@ -10,11 +10,11 @@
//
// This dummy reference to CLRDataCreateInstance prevents the LLVM toolchain from optimizing this important export out.
//
-void
-DummyReferenceToExportedAPI()
#ifdef __llvm__
__attribute__((used))
#endif // __llvm__
+void
+DummyReferenceToExportedAPI()
{
CLRDataCreateInstance(IID_ICLRDataTarget, NULL, NULL);
}