diff options
| author | Sinan Kaya <41809318+franksinankaya@users.noreply.github.com> | 2019-03-04 01:55:22 -0500 |
|---|---|---|
| committer | Jan Kotas <jkotas@microsoft.com> | 2019-03-03 22:55:22 -0800 |
| commit | 9d3f264b9ef8b4715017ec615dcb6f9d57e607cc (patch) | |
| tree | 44cdbdfc045ca93779e3d6faabe30ab2e4b56dd1 /src/debug/di | |
| parent | 7da0883d9ceba31bccf36cc8cbbbf2fe77a4f3e0 (diff) | |
| download | coreclr-9d3f264b9ef8b4715017ec615dcb6f9d57e607cc.tar.gz coreclr-9d3f264b9ef8b4715017ec615dcb6f9d57e607cc.tar.bz2 coreclr-9d3f264b9ef8b4715017ec615dcb6f9d57e607cc.zip | |
Cleanup more GCC warnings (#22872)
* Add parenthesis
src/vm/sha1.cpp: In function ‘void SHA1_block(SHA1_CTX*)’:
src/vm/sha1.cpp:93:29: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
#define ROUND3(B, C, D) ((C & (B | D) | (B & D)) + sha1_round3)
^
src/vm/sha1.cpp:139:32: note: in expansion of macro ‘ROUND3’
e += ROTATE32L(a, 5) + ROUND3(b, c, d) + msg80[i];
* Move declaration into same file as one was defined Extern the other one was static
* Remove hr=hr undefined assignment
* Fix mutli-line comment warning
* Convert multi-character literal
* Remove null check for stack local variables
rc/vm/invokeutil.cpp: In static member function ‘static void InvokeUtil::SetValidField(CorElementType, TypeHandle, FieldDesc*, OBJECTREF*, OBJECTREF*, TypeHandle, CLR_BOOL*)’:
src/vm/invokeutil.cpp:978:29: warning: the address of ‘Throwable’ will never be NULL [-Waddress]
EX_CATCH_THROWABLE(&Throwable);
^
src/inc/ex.h:1087:21: note: in definition of macro ‘EX_CATCH_THROWABLE’
if (NULL != ppThrowable)
^
Diffstat (limited to 'src/debug/di')
| -rw-r--r-- | src/debug/di/module.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/debug/di/module.cpp b/src/debug/di/module.cpp index 5097008be0..1263e710e4 100644 --- a/src/debug/di/module.cpp +++ b/src/debug/di/module.cpp @@ -4988,7 +4988,7 @@ HRESULT CordbNativeCode::EnsureReturnValueAllowedWorker(Instantiation *currentIn IfFailRet(CordbType::SigToType(GetModule(), &original, &inst, &pType)); - IfFailRet(hr = pType->ReturnedByValue()); + IfFailRet(pType->ReturnedByValue()); if (hr == S_OK) // not S_FALSE return S_OK; @@ -5001,7 +5001,7 @@ HRESULT CordbNativeCode::EnsureReturnValueAllowedWorker(Instantiation *currentIn CordbType *pType = 0; IfFailRet(CordbType::SigToType(GetModule(), &original, &inst, &pType)); - IfFailRet(hr = pType->ReturnedByValue()); + IfFailRet(pType->ReturnedByValue()); if (hr == S_OK) // not S_FALSE return S_OK; |