summaryrefslogtreecommitdiff
path: root/src/debug/di
diff options
context:
space:
mode:
authorAndrew Au <“andrewau@microsoft.com>2018-06-29 15:54:12 -0700
committerAndrew Au <cshung@gmail.com>2018-11-06 18:34:47 -0800
commit8fc1cb2b537845ce9f59e7cd422ba01bc2d3011c (patch)
tree00439e4b27b938689bd2d871f5ca49630a05bdfc /src/debug/di
parent20b1e6c0ec19c90f67fb08e1f655e58871302a2d (diff)
downloadcoreclr-8fc1cb2b537845ce9f59e7cd422ba01bc2d3011c.tar.gz
coreclr-8fc1cb2b537845ce9f59e7cd422ba01bc2d3011c.tar.bz2
coreclr-8fc1cb2b537845ce9f59e7cd422ba01bc2d3011c.zip
Eliminate dataBreakpointMask from ICorDebug
Diffstat (limited to 'src/debug/di')
-rw-r--r--src/debug/di/process.cpp2
-rw-r--r--src/debug/di/rsmain.cpp4
-rw-r--r--src/debug/di/shimcallback.cpp10
-rw-r--r--src/debug/di/shimpriv.h2
4 files changed, 8 insertions, 10 deletions
diff --git a/src/debug/di/process.cpp b/src/debug/di/process.cpp
index bcbaecb529..8fcd994536 100644
--- a/src/debug/di/process.cpp
+++ b/src/debug/di/process.cpp
@@ -4937,7 +4937,7 @@ void CordbProcess::RawDispatchEvent(
{
PUBLIC_CALLBACK_IN_THIS_SCOPE(this, pLockHolder, pEvent);
- pCallback4->DataBreakpoint(static_cast<ICorDebugProcess*>(this), pThread, pEvent->DataBreakpointData.dataBreakpointMask);
+ pCallback4->DataBreakpoint(static_cast<ICorDebugProcess*>(this), pThread);
}
break;
}
diff --git a/src/debug/di/rsmain.cpp b/src/debug/di/rsmain.cpp
index feed733265..8f26de0aea 100644
--- a/src/debug/di/rsmain.cpp
+++ b/src/debug/di/rsmain.cpp
@@ -870,7 +870,7 @@ namespace
virtual ULONG STDMETHODCALLTYPE Release();
COM_METHOD BeforeGarbageCollection(ICorDebugProcess* pProcess);
COM_METHOD AfterGarbageCollection(ICorDebugProcess* pProcess);
- COM_METHOD DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, ULONG64 dataBreakpointMask);
+ COM_METHOD DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread);
private:
// not implemented
DefaultManagedCallback4(const DefaultManagedCallback4&);
@@ -944,7 +944,7 @@ namespace
}
HRESULT
- DefaultManagedCallback4::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, ULONG64 dataBreakpointMask)
+ DefaultManagedCallback4::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread)
{
//
// Just ignore and continue the process.
diff --git a/src/debug/di/shimcallback.cpp b/src/debug/di/shimcallback.cpp
index ad02df00fd..1af6e04c0f 100644
--- a/src/debug/di/shimcallback.cpp
+++ b/src/debug/di/shimcallback.cpp
@@ -1384,7 +1384,7 @@ HRESULT ShimProxyCallback::AfterGarbageCollection(ICorDebugProcess* pProcess)
// input:
// pProcess - process in which the notification occurred
// Return value: S_OK
-HRESULT ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, ULONG64 dataBreakpointMask)
+HRESULT ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread)
{
m_pShim->PreDispatchEvent();
class DataBreakpointEvent : public ManagedEvent
@@ -1392,25 +1392,23 @@ HRESULT ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugT
// callbacks parameters. These are strong references
RSExtSmartPtr<ICorDebugProcess> m_pProcess;
RSExtSmartPtr<ICorDebugThread> m_pThread;
- ULONG64 m_dataBreakpointMask;
public:
// Ctor
- DataBreakpointEvent(ICorDebugProcess* pProcess, ICorDebugThread* pThread, ULONG64 dataBreakpointMask) :
+ DataBreakpointEvent(ICorDebugProcess* pProcess, ICorDebugThread* pThread) :
ManagedEvent()
{
this->m_pProcess.Assign(pProcess);
this->m_pThread.Assign(pThread);
- this->m_dataBreakpointMask = dataBreakpointMask;
}
HRESULT Dispatch(DispatchArgs args)
{
- return args.GetCallback4()->DataBreakpoint(m_pProcess, m_pThread, m_dataBreakpointMask);
+ return args.GetCallback4()->DataBreakpoint(m_pProcess, m_pThread);
}
}; // end class AfterGarbageCollectionEvent
- m_pShim->GetManagedEventQueue()->QueueEvent(new DataBreakpointEvent(pProcess, pThread, dataBreakpointMask));
+ m_pShim->GetManagedEventQueue()->QueueEvent(new DataBreakpointEvent(pProcess, pThread));
return S_OK;
}
diff --git a/src/debug/di/shimpriv.h b/src/debug/di/shimpriv.h
index ecef3622d4..97cbeb75eb 100644
--- a/src/debug/di/shimpriv.h
+++ b/src/debug/di/shimpriv.h
@@ -222,7 +222,7 @@ public:
COM_METHOD ShimProxyCallback::AfterGarbageCollection(ICorDebugProcess* pProcess);
// Implementation of ICorDebugManagedCallback4::DataBreakpoint
- COM_METHOD ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, ULONG64 dataBreakpointMask);
+ COM_METHOD ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread);
};