summaryrefslogtreecommitdiff
path: root/src/debug/di
diff options
context:
space:
mode:
authorJan Kotas <jkotas@microsoft.com>2018-11-08 21:12:57 -0800
committerJan Kotas <jkotas@microsoft.com>2018-11-08 21:13:54 -0800
commit592bc01e8da6bb4f692b3b090a3c82d415a3b7d7 (patch)
treeb76251d1ee822540d5cd19933ef937178704fcb6 /src/debug/di
parent9f41ff9d20c66a4b4fa8c273059085b8a8036343 (diff)
downloadcoreclr-592bc01e8da6bb4f692b3b090a3c82d415a3b7d7.tar.gz
coreclr-592bc01e8da6bb4f692b3b090a3c82d415a3b7d7.tar.bz2
coreclr-592bc01e8da6bb4f692b3b090a3c82d415a3b7d7.zip
Revert "Passing the CONTEXT in ICorDebugManagedCallback4::DataBreakpoint"
This reverts commit 9dd2a3688320fa197a3a2a412523416f10e7fa3b.
Diffstat (limited to 'src/debug/di')
-rw-r--r--src/debug/di/process.cpp2
-rw-r--r--src/debug/di/rsmain.cpp4
-rw-r--r--src/debug/di/shimcallback.cpp12
-rw-r--r--src/debug/di/shimpriv.h2
4 files changed, 8 insertions, 12 deletions
diff --git a/src/debug/di/process.cpp b/src/debug/di/process.cpp
index cad2c9bdcc..a5116f711f 100644
--- a/src/debug/di/process.cpp
+++ b/src/debug/di/process.cpp
@@ -4922,7 +4922,7 @@ void CordbProcess::RawDispatchEvent(
{
PUBLIC_CALLBACK_IN_THIS_SCOPE(this, pLockHolder, pEvent);
- pCallback4->DataBreakpoint(static_cast<ICorDebugProcess*>(this), pThread, reinterpret_cast<BYTE*>(&(pEvent->DataBreakpointData.context)), sizeof(CONTEXT));
+ pCallback4->DataBreakpoint(static_cast<ICorDebugProcess*>(this), pThread);
}
break;
}
diff --git a/src/debug/di/rsmain.cpp b/src/debug/di/rsmain.cpp
index 750cb1d8ee..8f26de0aea 100644
--- a/src/debug/di/rsmain.cpp
+++ b/src/debug/di/rsmain.cpp
@@ -870,7 +870,7 @@ namespace
virtual ULONG STDMETHODCALLTYPE Release();
COM_METHOD BeforeGarbageCollection(ICorDebugProcess* pProcess);
COM_METHOD AfterGarbageCollection(ICorDebugProcess* pProcess);
- COM_METHOD DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, BYTE* pContext, ULONG32 contextSize);
+ COM_METHOD DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread);
private:
// not implemented
DefaultManagedCallback4(const DefaultManagedCallback4&);
@@ -944,7 +944,7 @@ namespace
}
HRESULT
- DefaultManagedCallback4::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, BYTE* pContext, ULONG32 contextSize)
+ DefaultManagedCallback4::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread)
{
//
// Just ignore and continue the process.
diff --git a/src/debug/di/shimcallback.cpp b/src/debug/di/shimcallback.cpp
index 84ee3454d5..1af6e04c0f 100644
--- a/src/debug/di/shimcallback.cpp
+++ b/src/debug/di/shimcallback.cpp
@@ -1384,7 +1384,7 @@ HRESULT ShimProxyCallback::AfterGarbageCollection(ICorDebugProcess* pProcess)
// input:
// pProcess - process in which the notification occurred
// Return value: S_OK
-HRESULT ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, BYTE* pContext, ULONG32 contextSize)
+HRESULT ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread)
{
m_pShim->PreDispatchEvent();
class DataBreakpointEvent : public ManagedEvent
@@ -1392,27 +1392,23 @@ HRESULT ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugT
// callbacks parameters. These are strong references
RSExtSmartPtr<ICorDebugProcess> m_pProcess;
RSExtSmartPtr<ICorDebugThread> m_pThread;
- BYTE* m_pContext;
- ULONG32 m_contextSize;
public:
// Ctor
- DataBreakpointEvent(ICorDebugProcess* pProcess, ICorDebugThread* pThread, BYTE* pContext, ULONG32 contextSize) :
+ DataBreakpointEvent(ICorDebugProcess* pProcess, ICorDebugThread* pThread) :
ManagedEvent()
{
this->m_pProcess.Assign(pProcess);
this->m_pThread.Assign(pThread);
- this->m_pContext = pContext;
- this->m_contextSize = contextSize;
}
HRESULT Dispatch(DispatchArgs args)
{
- return args.GetCallback4()->DataBreakpoint(m_pProcess, m_pThread, m_pContext, m_contextSize);
+ return args.GetCallback4()->DataBreakpoint(m_pProcess, m_pThread);
}
}; // end class AfterGarbageCollectionEvent
- m_pShim->GetManagedEventQueue()->QueueEvent(new DataBreakpointEvent(pProcess, pThread, pContext, contextSize));
+ m_pShim->GetManagedEventQueue()->QueueEvent(new DataBreakpointEvent(pProcess, pThread));
return S_OK;
}
diff --git a/src/debug/di/shimpriv.h b/src/debug/di/shimpriv.h
index 4c9eb7ab86..97cbeb75eb 100644
--- a/src/debug/di/shimpriv.h
+++ b/src/debug/di/shimpriv.h
@@ -222,7 +222,7 @@ public:
COM_METHOD ShimProxyCallback::AfterGarbageCollection(ICorDebugProcess* pProcess);
// Implementation of ICorDebugManagedCallback4::DataBreakpoint
- COM_METHOD ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread, BYTE* pContext, ULONG32 contextSize);
+ COM_METHOD ShimProxyCallback::DataBreakpoint(ICorDebugProcess* pProcess, ICorDebugThread* pThread);
};