summaryrefslogtreecommitdiff
path: root/src/debug/di/valuehome.cpp
diff options
context:
space:
mode:
authorKonstantin Baladurin <k.baladurin@partner.samsung.com>2017-10-05 11:31:44 +0300
committerJan Vorlicek <janvorli@microsoft.com>2017-10-05 10:31:44 +0200
commitde4daccc1ea52ddc1ae8ac9e48cde603c507b868 (patch)
treec8bf3f40f838811fd4410123fc3e869dc4475cde /src/debug/di/valuehome.cpp
parentd0baa73f54eb0f7eba1364e207c02afa984760cb (diff)
downloadcoreclr-de4daccc1ea52ddc1ae8ac9e48cde603c507b868.tar.gz
coreclr-de4daccc1ea52ddc1ae8ac9e48cde603c507b868.tar.bz2
coreclr-de4daccc1ea52ddc1ae8ac9e48cde603c507b868.zip
[x86/Linux][SOS] Fix clrstack command of lldb sosplugin on x86 (#13973)
* [x86/Linux][SOS] Add support for x86 in GetContextFromFrame It's need for 'clrstack -f' command of SOS plugin on x86. * [x86/Linux] Fix RtlpGetFunctionEndAddress function We should use PTR_UNWIND_INFO instead of PUNWIND_INFO for pointer to UNWIND_INFO structure because it's pointer from other process and we need to use DAC to read data using it. * [x86/Linux][SOS] Define DEBUG_STACK_CONTEXT for x86 It's needed for 'clrstack -f' command in libsosplugin. * [x86/Linux] Fix undefined references in libmscordbi.so on x86 Asm block like following: __asm fnsave currentFPUState where currentFPUState is structure works with MSVC but leads to undefined reference currentFPUState in the binary with other compilers. So rewrite such asm blocks for them. This patch fixes error "Unable to load 'libmscordbi.so'" during execution of 'clrstack -f' command of SOS plugin on x86. * [x86/Linux] Fix calling convention inconsistency WINAPI and STDAPI are defined as __cdecl but in some cases functions with these attributes are called using stdcall calling convention. It leads to crashes during execution of 'clrstack -i' command of SOS plugin on x86.
Diffstat (limited to 'src/debug/di/valuehome.cpp')
-rw-r--r--src/debug/di/valuehome.cpp36
1 files changed, 36 insertions, 0 deletions
diff --git a/src/debug/di/valuehome.cpp b/src/debug/di/valuehome.cpp
index 837afd5f8b..6cae8c1f3a 100644
--- a/src/debug/di/valuehome.cpp
+++ b/src/debug/di/valuehome.cpp
@@ -481,18 +481,36 @@ void FloatRegValueHome::SetEnregisteredValue(MemoryRange newValue,
// restore our original state.
DT_FLOATING_SAVE_AREA currentFPUState;
+ #ifdef _MSC_VER
__asm fnsave currentFPUState // save the current FPU state.
+ #else
+ __asm__ __volatile__
+ (
+ " fnsave %0\n" \
+ : "=m"(currentFPUState)
+ );
+ #endif
// Copy the state out of the context.
DT_FLOATING_SAVE_AREA floatarea = pContext->FloatSave;
floatarea.StatusWord &= 0xFF00; // remove any error codes.
floatarea.ControlWord |= 0x3F; // mask all exceptions.
+ #ifdef _MSC_VER
__asm
{
fninit
frstor floatarea ;; reload the threads FPU state.
}
+ #else
+ __asm__
+ (
+ " fninit\n" \
+ " frstor %0\n" \
+ : /* no outputs */
+ : "m"(floatarea)
+ );
+ #endif
double td; // temp double
double popArea[DebuggerIPCE_FloatCount];
@@ -519,17 +537,35 @@ void FloatRegValueHome::SetEnregisteredValue(MemoryRange newValue,
}
// Save out the modified float area.
+ #ifdef _MSC_VER
__asm fnsave floatarea
+ #else
+ __asm__ __volatile__
+ (
+ " fnsave %0\n" \
+ : "=m"(floatarea)
+ );
+ #endif
// Put it into the context.
pContext->FloatSave= floatarea;
// Restore our FPU state
+ #ifdef _MSC_VER
__asm
{
fninit
frstor currentFPUState ;; restore our saved FPU state.
}
+ #else
+ __asm__
+ (
+ " fninit\n" \
+ " frstor %0\n" \
+ : /* no outputs */
+ : "m"(currentFPUState)
+ );
+ #endif
#endif // DBG_TARGET_X86
// update the thread's floating point stack