summaryrefslogtreecommitdiff
path: root/src/debug/debug-pal
diff options
context:
space:
mode:
authorMike McLaughlin <mikem@microsoft.com>2016-02-11 13:28:09 -0800
committerMike McLaughlin <mikem@microsoft.com>2016-02-12 11:21:24 -0800
commitc66f88cda89166d74b33522c13b2523302202d9d (patch)
treea03282898184ed3ace8f81e6b2caa30f68d75415 /src/debug/debug-pal
parent58a96714860f3acab33ddbb22f572bff0ea6ad4b (diff)
downloadcoreclr-c66f88cda89166d74b33522c13b2523302202d9d.tar.gz
coreclr-c66f88cda89166d74b33522c13b2523302202d9d.tar.bz2
coreclr-c66f88cda89166d74b33522c13b2523302202d9d.zip
Change the transport pipe and dbgshim runtime startup semaphores permissions to user only
Since the mechanism used to enumerate process modules (/proc/xxxx/maps on Linux, running vmvmap on OSX) is user only and the default group new users get on OSX is the same ("staff") restricting the transport pipes and runtime startup named semaphores to user only is the right way to go. If we find some reason to give groups permissions, we can always change that later though the process module enumeration would have to be figured out.
Diffstat (limited to 'src/debug/debug-pal')
-rw-r--r--src/debug/debug-pal/unix/twowaypipe.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/debug/debug-pal/unix/twowaypipe.cpp b/src/debug/debug-pal/unix/twowaypipe.cpp
index b266ac14cc..f8f82be546 100644
--- a/src/debug/debug-pal/unix/twowaypipe.cpp
+++ b/src/debug/debug-pal/unix/twowaypipe.cpp
@@ -35,13 +35,12 @@ bool TwoWayPipe::CreateServer(DWORD id)
GetPipeName(inPipeName, id, "in");
GetPipeName(outPipeName, id, "out");
- //TODO: REVIEW if S_IRWXU | S_IRWXG is the right access level in prof use
- if (mkfifo(inPipeName, S_IRWXU | S_IRWXG) == -1)
+ if (mkfifo(inPipeName, S_IRWXU) == -1)
{
return false;
}
- if (mkfifo(outPipeName, S_IRWXU | S_IRWXG) == -1)
+ if (mkfifo(outPipeName, S_IRWXU) == -1)
{
remove(inPipeName);
return false;