diff options
author | Jan Vorlicek <janvorli@microsoft.com> | 2015-03-26 08:19:22 +0100 |
---|---|---|
committer | Jan Vorlicek <janvorli@microsoft.com> | 2015-03-26 09:03:20 +0100 |
commit | 1e787356393276f38f4600232722076d2d9311e2 (patch) | |
tree | 35e1a5c85a1c375e681c9b0c45013317ce6e25a6 /src/debug/daccess/dacdbiimpl.h | |
parent | ab0fb914d6efde5c0b59e7edbbfd04016232c96b (diff) | |
download | coreclr-1e787356393276f38f4600232722076d2d9311e2.tar.gz coreclr-1e787356393276f38f4600232722076d2d9311e2.tar.bz2 coreclr-1e787356393276f38f4600232722076d2d9311e2.zip |
Fix about 12 kinds of warnings over the codebase
This change fixes:
1) Member initiazalization order in class constructor didn't correspond to the member order in some classes
2) Objects with vtables were copied via memcpy. While this is intentional, cast of the pointers to void*
is required to silence clang warning
3) Switch case statements containing values of different enums
4) Casting int to pointer
5) Missing return value in methods with _ASSERTE
6) Class name classifier on methods in the .h
7) Invalid position of the DECLSPEC_ALIGN at few places - it had no effect
8) Invalid position of the 'used' attribute
9) Issue with comparing holders to NULL
10) Operator 'new' returning NULL without being marked with throw() or noexcept
11) Variables marked as 'extern' at the declaration / initialization place
12) Data structure declared as struct at one place and forward declared as class at another
Some disabled warnings were no longer happening, so options to disable them were removed too
Diffstat (limited to 'src/debug/daccess/dacdbiimpl.h')
-rw-r--r-- | src/debug/daccess/dacdbiimpl.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/debug/daccess/dacdbiimpl.h b/src/debug/daccess/dacdbiimpl.h index 34c5ff5b53..766e7345f5 100644 --- a/src/debug/daccess/dacdbiimpl.h +++ b/src/debug/daccess/dacdbiimpl.h @@ -286,9 +286,9 @@ public: VMPTR_TypeHandle GetApproxTypeHandle(TypeInfoList * pTypeData); // Get the exact type handle from type data - HRESULT DacDbiInterfaceImpl::GetExactTypeHandle(DebuggerIPCE_ExpandedTypeData * pTypeData, - ArgInfoList * pArgInfo, - VMPTR_TypeHandle& vmTypeHandle); + HRESULT GetExactTypeHandle(DebuggerIPCE_ExpandedTypeData * pTypeData, + ArgInfoList * pArgInfo, + VMPTR_TypeHandle& vmTypeHandle); // Retrieve the generic type params for a given MethodDesc. This function is specifically // for stackwalking because it requires the generic type token on the stack. |