summaryrefslogtreecommitdiff
path: root/src/corefx
diff options
context:
space:
mode:
authorJan Vorlicek <janvorli@microsoft.com>2016-11-29 19:09:35 +0100
committerGitHub <noreply@github.com>2016-11-29 19:09:35 +0100
commit74816870ce9ff5ec41d30455a7dcc3b5d327bf45 (patch)
treefc148a063f34c8bfc70e15d24a5e4abba272f78d /src/corefx
parente67851210d1c03d730a3bc97a87e8a6713bbf772 (diff)
downloadcoreclr-74816870ce9ff5ec41d30455a7dcc3b5d327bf45.tar.gz
coreclr-74816870ce9ff5ec41d30455a7dcc3b5d327bf45.tar.bz2
coreclr-74816870ce9ff5ec41d30455a7dcc3b5d327bf45.zip
Fix shared library dependencies verification on some platforms (#8349)
The existing way of verifying shared library dependencies, used for System.Globalization.Native.so, doesn't work on platforms that don't have ldd or where ldd doesn't support the `-r` option. This change makes the check happen on non-Alpine Linux only for now. It also refactors the way the check is performed. Instead of doing it post build in the build.sh, it is now performed as a postbuild phase of the System.Globalization.Native target and it is also generalized so that we can easily add such verification to other build targets. The new verify-so.sh script is also used in corefx.
Diffstat (limited to 'src/corefx')
-rw-r--r--src/corefx/System.Globalization.Native/CMakeLists.txt6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/corefx/System.Globalization.Native/CMakeLists.txt b/src/corefx/System.Globalization.Native/CMakeLists.txt
index 5892856dfe..90f50671cd 100644
--- a/src/corefx/System.Globalization.Native/CMakeLists.txt
+++ b/src/corefx/System.Globalization.Native/CMakeLists.txt
@@ -93,5 +93,11 @@ else()
add_definitions(-DU_DISABLE_RENAMING=1)
endif()
+verify_dependencies(
+ System.Globalization.Native
+ "Verification failed. System.Globalization.Native.so has undefined dependencies. These are likely ICU APIs that need to be added to icushim.h."
+)
+
# add the install targets
install_clr(System.Globalization.Native)
+