diff options
| author | Robin Sue <robinsue@live.de> | 2018-06-03 20:12:26 +0200 |
|---|---|---|
| committer | Sergey Andreenko <seandree@microsoft.com> | 2018-06-03 11:12:26 -0700 |
| commit | b31ec0562a7e916301585001968ac5522aa20e84 (patch) | |
| tree | c386d6d267f005083a61d8d0085e0ad612e42924 /src/ToolBox | |
| parent | 9791a661155d08f85f862bfc37eff3cd8d7b25cc (diff) | |
| download | coreclr-b31ec0562a7e916301585001968ac5522aa20e84.tar.gz coreclr-b31ec0562a7e916301585001968ac5522aa20e84.tar.bz2 coreclr-b31ec0562a7e916301585001968ac5522aa20e84.zip | |
Warnings cleanup (#18260)
* Cleanup all disabled warnings that do not trigger
* Fix warning about line continuation in single line comment
* Eliminiate all unreferenced local variables and reenable warning
Diffstat (limited to 'src/ToolBox')
| -rw-r--r-- | src/ToolBox/SOS/Strike/ExpressionNode.cpp | 3 | ||||
| -rw-r--r-- | src/ToolBox/SOS/Strike/disasm.cpp | 2 | ||||
| -rw-r--r-- | src/ToolBox/SOS/Strike/strike.cpp | 8 |
3 files changed, 3 insertions, 10 deletions
diff --git a/src/ToolBox/SOS/Strike/ExpressionNode.cpp b/src/ToolBox/SOS/Strike/ExpressionNode.cpp index 03630b40a6..b61dcad487 100644 --- a/src/ToolBox/SOS/Strike/ExpressionNode.cpp +++ b/src/ToolBox/SOS/Strike/ExpressionNode.cpp @@ -577,7 +577,6 @@ HRESULT ExpressionNode::ExpandFields(ICorDebugValue* pInnerValue, __in_z WCHAR* ULONG nameLen = 0; DWORD fieldAttr = 0; WCHAR mdName[mdNameLen]; - WCHAR typeName[mdNameLen]; CorElementType fieldDefaultValueEt; UVCP_CONSTANT pDefaultValue; ULONG cchDefaultValue; @@ -771,7 +770,6 @@ HRESULT ExpressionNode::PopulateEnumValue(ICorDebugValue* pEnumValue, BYTE* enum ULONG nameLen = 0; DWORD fieldAttr = 0; WCHAR mdName[mdNameLen]; - WCHAR typeName[mdNameLen]; UVCP_CONSTANT pRawValue = NULL; ULONG rawValueLength = 0; if(SUCCEEDED(pMD->GetFieldProps(fieldDef, NULL, mdName, mdNameLen, &nameLen, &fieldAttr, NULL, NULL, NULL, &pRawValue, &rawValueLength))) @@ -1478,7 +1476,6 @@ HRESULT ExpressionNode::CreateExpressionNodeHelper(__in_z WCHAR* pExpression, ULONG nameLen = 0; DWORD fieldAttr = 0; WCHAR mdName[mdNameLen]; - WCHAR typeName[mdNameLen]; CorElementType fieldDefaultValueEt; UVCP_CONSTANT pDefaultValue; ULONG cchDefaultValue; diff --git a/src/ToolBox/SOS/Strike/disasm.cpp b/src/ToolBox/SOS/Strike/disasm.cpp index 6137031410..f82c38ac4d 100644 --- a/src/ToolBox/SOS/Strike/disasm.cpp +++ b/src/ToolBox/SOS/Strike/disasm.cpp @@ -873,8 +873,6 @@ void PrintNativeStack(DWORD_PTR ip, BOOL bSuppressLines) // Return TRUE if we have printed something. BOOL PrintCallInfo(DWORD_PTR vEBP, DWORD_PTR IP, DumpStackFlag& DSFlag, BOOL bSymbolOnly) { - char Symbol[1024]; - char filename[MAX_PATH_FNAME+1]; ULONG64 Displacement; BOOL bOutput = FALSE; diff --git a/src/ToolBox/SOS/Strike/strike.cpp b/src/ToolBox/SOS/Strike/strike.cpp index b566ed5711..cd3b9f299c 100644 --- a/src/ToolBox/SOS/Strike/strike.cpp +++ b/src/ToolBox/SOS/Strike/strike.cpp @@ -7300,10 +7300,9 @@ HRESULT HandleExceptionNotification(ILLDBServices *client) DECLARE_API(bpmd) { - INIT_API_NOEE(); - MINIDUMP_NOT_SUPPORTED(); - int i; - char buffer[1024]; + INIT_API_NOEE(); + MINIDUMP_NOT_SUPPORTED(); + char buffer[1024]; if (IsDumpFile()) { @@ -11459,7 +11458,6 @@ private: ULONG nameLen = 0; DWORD fieldAttr = 0; WCHAR mdName[mdNameLen]; - WCHAR typeName[mdNameLen]; UVCP_CONSTANT pRawValue = NULL; ULONG rawValueLength = 0; if(SUCCEEDED(pMD->GetFieldProps(fieldDef, NULL, mdName, mdNameLen, &nameLen, &fieldAttr, NULL, NULL, NULL, &pRawValue, &rawValueLength))) |