diff options
author | Eugene Rozenfeld <erozen@microsoft.com> | 2018-10-11 13:03:26 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-10-11 13:03:26 -0700 |
commit | 5f9f37432568b9abd91de39949ae860e9151798e (patch) | |
tree | d526a60db61b6add23c2c3c90a3ca7f3c6eaa35d /src/ToolBox | |
parent | 5c039559b96bf71e4281331977160ff4c8c44af8 (diff) | |
download | coreclr-5f9f37432568b9abd91de39949ae860e9151798e.tar.gz coreclr-5f9f37432568b9abd91de39949ae860e9151798e.tar.bz2 coreclr-5f9f37432568b9abd91de39949ae860e9151798e.zip |
JitEE interface additions to support object stack allocation. (#20283)
Add two methods to JitEE interface: getHeapClassSize and canAllocateOnStack.
Change JITEEVersionIdentifier.
Diffstat (limited to 'src/ToolBox')
8 files changed, 118 insertions, 1 deletions
diff --git a/src/ToolBox/superpmi/superpmi-shared/icorjitinfoimpl.h b/src/ToolBox/superpmi/superpmi-shared/icorjitinfoimpl.h index 29c1b44711..e21f72b668 100644 --- a/src/ToolBox/superpmi/superpmi-shared/icorjitinfoimpl.h +++ b/src/ToolBox/superpmi/superpmi-shared/icorjitinfoimpl.h @@ -326,6 +326,11 @@ size_t getClassModuleIdForStatics(CORINFO_CLASS_HANDLE cls, CORINFO_MODULE_HANDL // return the number of bytes needed by an instance of the class unsigned getClassSize(CORINFO_CLASS_HANDLE cls); +// return the number of bytes needed by an instance of the class allocated on the heap +unsigned getHeapClassSize(CORINFO_CLASS_HANDLE cls); + +BOOL canAllocateOnStack(CORINFO_CLASS_HANDLE cls); + unsigned getClassAlignmentRequirement(CORINFO_CLASS_HANDLE cls, BOOL fDoubleAlignHint = FALSE); // This is only called for Value classes. It returns a boolean array diff --git a/src/ToolBox/superpmi/superpmi-shared/lwmlist.h b/src/ToolBox/superpmi/superpmi-shared/lwmlist.h index 779a9b65c8..42ffc01423 100644 --- a/src/ToolBox/superpmi/superpmi-shared/lwmlist.h +++ b/src/ToolBox/superpmi/superpmi-shared/lwmlist.h @@ -72,6 +72,8 @@ LWM(GetClassNameFromMetadata, DLD, DD) LWM(GetTypeInstantiationArgument, DWORDLONG, DWORDLONG) LWM(GetClassNumInstanceFields, DWORDLONG, DWORD) LWM(GetClassSize, DWORDLONG, DWORD) +LWM(GetHeapClassSize, DWORDLONG, DWORD) +LWM(CanAllocateOnStack, DWORDLONG, DWORD) LWM(GetCookieForPInvokeCalliSig, GetCookieForPInvokeCalliSigValue, DLDL) LWM(GetDefaultEqualityComparerClass, DWORDLONG, DWORDLONG) LWM(GetDelegateCtor, Agnostic_GetDelegateCtorIn, Agnostic_GetDelegateCtorOut) diff --git a/src/ToolBox/superpmi/superpmi-shared/methodcontext.cpp b/src/ToolBox/superpmi/superpmi-shared/methodcontext.cpp index 6ebe9881fb..ea6dbd4953 100644 --- a/src/ToolBox/superpmi/superpmi-shared/methodcontext.cpp +++ b/src/ToolBox/superpmi/superpmi-shared/methodcontext.cpp @@ -1722,6 +1722,50 @@ unsigned MethodContext::repGetClassSize(CORINFO_CLASS_HANDLE cls) return result; } +void MethodContext::recGetHeapClassSize(CORINFO_CLASS_HANDLE cls, unsigned result) +{ + if (GetHeapClassSize == nullptr) + GetHeapClassSize = new LightWeightMap<DWORDLONG, DWORD>(); + + GetHeapClassSize->Add((DWORDLONG)cls, (DWORD)result); + DEBUG_REC(dmpGetHeapClassSize((DWORDLONG)cls, (DWORD)result)); +} +void MethodContext::dmpGetHeapClassSize(DWORDLONG key, DWORD val) +{ + printf("GetHeapClassSize key %016llX, value %u", key, val); +} +unsigned MethodContext::repGetHeapClassSize(CORINFO_CLASS_HANDLE cls) +{ + AssertCodeMsg(GetHeapClassSize != nullptr, EXCEPTIONCODE_MC, "Didn't find %016llX", (DWORDLONG)cls); + AssertCodeMsg(GetHeapClassSize->GetIndex((DWORDLONG)cls) != -1, EXCEPTIONCODE_MC, "Didn't find %016llX", + (DWORDLONG)cls); + unsigned result = (unsigned)GetHeapClassSize->Get((DWORDLONG)cls); + DEBUG_REP(dmpGetHeapClassSize((DWORDLONG)cls, (DWORD)result)); + return result; +} + +void MethodContext::recCanAllocateOnStack(CORINFO_CLASS_HANDLE cls, BOOL result) +{ + if (CanAllocateOnStack == nullptr) + CanAllocateOnStack = new LightWeightMap<DWORDLONG, DWORD>(); + + CanAllocateOnStack->Add((DWORDLONG)cls, (DWORD)result); + DEBUG_REC(dmpCanAllocateOnStack((DWORDLONG)cls, (DWORD)result)); +} +void MethodContext::dmpCanAllocateOnStack(DWORDLONG key, DWORD val) +{ + printf("CanAllocateOnStack key %016llX, value %u", key, val); +} +BOOL MethodContext::repCanAllocateOnStack(CORINFO_CLASS_HANDLE cls) +{ + AssertCodeMsg(CanAllocateOnStack != nullptr, EXCEPTIONCODE_MC, "Didn't find %016llX", (DWORDLONG)cls); + AssertCodeMsg(CanAllocateOnStack->GetIndex((DWORDLONG)cls) != -1, EXCEPTIONCODE_MC, "Didn't find %016llX", + (DWORDLONG)cls); + BOOL result = (BOOL)CanAllocateOnStack->Get((DWORDLONG)cls); + DEBUG_REP(dmpCanAllocateOnStack((DWORDLONG)cls, (DWORD)result)); + return result; +} + void MethodContext::recGetClassNumInstanceFields(CORINFO_CLASS_HANDLE cls, unsigned result) { if (GetClassNumInstanceFields == nullptr) diff --git a/src/ToolBox/superpmi/superpmi-shared/methodcontext.h b/src/ToolBox/superpmi/superpmi-shared/methodcontext.h index 0a71c8df68..fa7d699e62 100644 --- a/src/ToolBox/superpmi/superpmi-shared/methodcontext.h +++ b/src/ToolBox/superpmi/superpmi-shared/methodcontext.h @@ -696,6 +696,14 @@ public: void dmpGetClassSize(DWORDLONG key, DWORD val); unsigned repGetClassSize(CORINFO_CLASS_HANDLE cls); + void recGetHeapClassSize(CORINFO_CLASS_HANDLE cls, unsigned result); + void dmpGetHeapClassSize(DWORDLONG key, DWORD val); + unsigned repGetHeapClassSize(CORINFO_CLASS_HANDLE cls); + + void recCanAllocateOnStack(CORINFO_CLASS_HANDLE cls, BOOL result); + void dmpCanAllocateOnStack(DWORDLONG key, DWORD val); + BOOL repCanAllocateOnStack(CORINFO_CLASS_HANDLE cls); + void recGetClassNumInstanceFields(CORINFO_CLASS_HANDLE cls, unsigned result); void dmpGetClassNumInstanceFields(DWORDLONG key, DWORD value); unsigned repGetClassNumInstanceFields(CORINFO_CLASS_HANDLE cls); @@ -1309,7 +1317,7 @@ private: }; // ********************* Please keep this up-to-date to ease adding more *************** -// Highest packet number: 168 +// Highest packet number: 171 // ************************************************************************************* enum mcPackets { @@ -1378,6 +1386,8 @@ enum mcPackets Packet_GetTypeInstantiationArgument = 167, // Added 12/4/17 Packet_GetClassNumInstanceFields = 46, Packet_GetClassSize = 47, + Packet_GetHeapClassSize = 170, // Added 10/5/2018 + Packet_CanAllocateOnStack = 171, // Added 10/5/2018 Packet_GetIntConfigValue = 151, // Added 2/12/2015 Packet_GetStringConfigValue = 152, // Added 2/12/2015 Packet_GetCookieForPInvokeCalliSig = 48, diff --git a/src/ToolBox/superpmi/superpmi-shim-collector/icorjitinfo.cpp b/src/ToolBox/superpmi/superpmi-shim-collector/icorjitinfo.cpp index 32cc072d68..200152a046 100644 --- a/src/ToolBox/superpmi/superpmi-shim-collector/icorjitinfo.cpp +++ b/src/ToolBox/superpmi/superpmi-shim-collector/icorjitinfo.cpp @@ -683,6 +683,25 @@ unsigned interceptor_ICJI::getClassSize(CORINFO_CLASS_HANDLE cls) return temp; } +// return the number of bytes needed by an instance of the class allocated on the heap +unsigned interceptor_ICJI::getHeapClassSize(CORINFO_CLASS_HANDLE cls) +{ + mc->cr->AddCall("getHeapClassSize"); + unsigned temp = original_ICorJitInfo->getHeapClassSize(cls); + mc->recGetHeapClassSize(cls, temp); + return temp; +} + +BOOL interceptor_ICJI::canAllocateOnStack( + CORINFO_CLASS_HANDLE cls +) +{ + mc->cr->AddCall("canAllocateOnStack"); + BOOL temp = original_ICorJitInfo->canAllocateOnStack(cls); + mc->recCanAllocateOnStack(cls, temp); + return temp; +} + unsigned interceptor_ICJI::getClassAlignmentRequirement(CORINFO_CLASS_HANDLE cls, BOOL fDoubleAlignHint) { mc->cr->AddCall("getClassAlignmentRequirement"); diff --git a/src/ToolBox/superpmi/superpmi-shim-counter/icorjitinfo.cpp b/src/ToolBox/superpmi/superpmi-shim-counter/icorjitinfo.cpp index 8a3e80ca4c..c2100e245f 100644 --- a/src/ToolBox/superpmi/superpmi-shim-counter/icorjitinfo.cpp +++ b/src/ToolBox/superpmi/superpmi-shim-counter/icorjitinfo.cpp @@ -519,6 +519,19 @@ unsigned interceptor_ICJI::getClassSize(CORINFO_CLASS_HANDLE cls) return original_ICorJitInfo->getClassSize(cls); } +// return the number of bytes needed by an instance of the class allocated on the heap +unsigned interceptor_ICJI::getHeapClassSize(CORINFO_CLASS_HANDLE cls) +{ + mcs->AddCall("getHeapClassSize"); + return original_ICorJitInfo->getHeapClassSize(cls); +} + +BOOL interceptor_ICJI::canAllocateOnStack(CORINFO_CLASS_HANDLE cls) +{ + mcs->AddCall("canAllocateOnStack"); + return original_ICorJitInfo->canAllocateOnStack(cls); +} + unsigned interceptor_ICJI::getClassAlignmentRequirement(CORINFO_CLASS_HANDLE cls, BOOL fDoubleAlignHint) { mcs->AddCall("getClassAlignmentRequirement"); diff --git a/src/ToolBox/superpmi/superpmi-shim-simple/icorjitinfo.cpp b/src/ToolBox/superpmi/superpmi-shim-simple/icorjitinfo.cpp index 90b2fdb628..4ebd09a4f6 100644 --- a/src/ToolBox/superpmi/superpmi-shim-simple/icorjitinfo.cpp +++ b/src/ToolBox/superpmi/superpmi-shim-simple/icorjitinfo.cpp @@ -464,6 +464,17 @@ unsigned interceptor_ICJI::getClassSize(CORINFO_CLASS_HANDLE cls) return original_ICorJitInfo->getClassSize(cls); } +// return the number of bytes needed by an instance of the class allocated on the heap +unsigned interceptor_ICJI::getHeapClassSize(CORINFO_CLASS_HANDLE cls) +{ + return original_ICorJitInfo->getHeapClassSize(cls); +} + +BOOL interceptor_ICJI::canAllocateOnStack(CORINFO_CLASS_HANDLE cls) +{ + return original_ICorJitInfo->canAllocateOnStack(cls); +} + unsigned interceptor_ICJI::getClassAlignmentRequirement(CORINFO_CLASS_HANDLE cls, BOOL fDoubleAlignHint) { return original_ICorJitInfo->getClassAlignmentRequirement(cls, fDoubleAlignHint); diff --git a/src/ToolBox/superpmi/superpmi/icorjitinfo.cpp b/src/ToolBox/superpmi/superpmi/icorjitinfo.cpp index 3eb5a312a9..ac1abcc38d 100644 --- a/src/ToolBox/superpmi/superpmi/icorjitinfo.cpp +++ b/src/ToolBox/superpmi/superpmi/icorjitinfo.cpp @@ -577,6 +577,19 @@ unsigned MyICJI::getClassSize(CORINFO_CLASS_HANDLE cls) return jitInstance->mc->repGetClassSize(cls); } +// return the number of bytes needed by an instance of the class allocated on the heap +unsigned MyICJI::getHeapClassSize(CORINFO_CLASS_HANDLE cls) +{ + jitInstance->mc->cr->AddCall("getHeapClassSize"); + return jitInstance->mc->repGetHeapClassSize(cls); +} + +BOOL MyICJI::canAllocateOnStack(CORINFO_CLASS_HANDLE cls) +{ + jitInstance->mc->cr->AddCall("canAllocateOnStack"); + return jitInstance->mc->repCanAllocateOnStack(cls); +} + unsigned MyICJI::getClassAlignmentRequirement(CORINFO_CLASS_HANDLE cls, BOOL fDoubleAlignHint) { jitInstance->mc->cr->AddCall("getClassAlignmentRequirement"); |