summaryrefslogtreecommitdiff
path: root/src/System.Private.CoreLib/shared/System/Threading/Tasks
diff options
context:
space:
mode:
authorSantiago Fernandez Madero <safern@microsoft.com>2019-06-03 23:37:44 -0700
committerSantiago Fernandez Madero <safern@microsoft.com>2019-06-03 23:43:54 -0700
commit9d98b4875ae456d3f58cae75c009afabf19d0d15 (patch)
tree06ab88d57e0ec25d838544ebc1da5d02852effb0 /src/System.Private.CoreLib/shared/System/Threading/Tasks
parent4adb4abf3dbeff4fb3070315368f49d66c732862 (diff)
downloadcoreclr-9d98b4875ae456d3f58cae75c009afabf19d0d15.tar.gz
coreclr-9d98b4875ae456d3f58cae75c009afabf19d0d15.tar.bz2
coreclr-9d98b4875ae456d3f58cae75c009afabf19d0d15.zip
PR Feedback
Diffstat (limited to 'src/System.Private.CoreLib/shared/System/Threading/Tasks')
-rw-r--r--src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs4
-rw-r--r--src/System.Private.CoreLib/shared/System/Threading/Tasks/ValueTask.cs2
2 files changed, 1 insertions, 5 deletions
diff --git a/src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs b/src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs
index 24c756e34d..f275fd9549 100644
--- a/src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs
+++ b/src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs
@@ -256,7 +256,7 @@ namespace System.Threading.Tasks
#if PROJECTN
[DependencyReductionRoot]
#endif
- internal abstract Delegate[] GetDelegateContinuationsForDebugger();
+ internal abstract Delegate[]? GetDelegateContinuationsForDebugger();
}
/// <summary>Provides the standard implementation of a task continuation.</summary>
@@ -341,7 +341,6 @@ namespace System.Threading.Tasks
else continuationTask.InternalCancel(false);
}
-#pragma warning disable CS8609 // TODO-NULLABLE: Covariant return types (https://github.com/dotnet/roslyn/issues/23268)
internal override Delegate[]? GetDelegateContinuationsForDebugger()
{
if (m_task.m_action == null)
@@ -351,7 +350,6 @@ namespace System.Threading.Tasks
return new Delegate[] { m_task.m_action };
}
-#pragma warning restore CS8609
}
diff --git a/src/System.Private.CoreLib/shared/System/Threading/Tasks/ValueTask.cs b/src/System.Private.CoreLib/shared/System/Threading/Tasks/ValueTask.cs
index 123800914b..75c6fd9a32 100644
--- a/src/System.Private.CoreLib/shared/System/Threading/Tasks/ValueTask.cs
+++ b/src/System.Private.CoreLib/shared/System/Threading/Tasks/ValueTask.cs
@@ -776,7 +776,6 @@ namespace System.Threading.Tasks
public ConfiguredValueTaskAwaitable<TResult> ConfigureAwait(bool continueOnCapturedContext) =>
new ConfiguredValueTaskAwaitable<TResult>(new ValueTask<TResult>(_obj, _result, _token, continueOnCapturedContext));
-#pragma warning disable CS8609 // TODO-NULLABLE: Covariant return types (https://github.com/dotnet/roslyn/issues/23268)
/// <summary>Gets a string-representation of this <see cref="ValueTask{TResult}"/>.</summary>
public override string? ToString()
{
@@ -791,6 +790,5 @@ namespace System.Threading.Tasks
return string.Empty;
}
-#pragma warning restore CS8609
}
}