diff options
| author | Sung Yoon Whang <suwhang@microsoft.com> | 2018-07-22 20:56:42 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-22 20:56:42 -0700 |
| commit | cc96914f80b6873c555d0ed377042537ef99f1af (patch) | |
| tree | 026d241960b09179fd5132861763261e1f43f8d4 /clr.defines.targets | |
| parent | 45f1ec9c4d91733c76868870ff85f2beafabdd39 (diff) | |
| download | coreclr-cc96914f80b6873c555d0ed377042537ef99f1af.tar.gz coreclr-cc96914f80b6873c555d0ed377042537ef99f1af.tar.bz2 coreclr-cc96914f80b6873c555d0ed377042537ef99f1af.zip | |
Enable profiler attach on Windows (#18762)
* try building clr with prof attach enabled
* define ICLRProfiling interface
* profattach.dll now builds with CreateCLRProfiling export
* remove try catch
* basic attach working now
* build with profiler attach feature only on win
* Fix linux build
* cleanup
* more cleanup
* more cleanup
* remove profattach dll
* remove useless unix exports in mscorwks
* remove profattach from dll cmakelist
* Add back ifdef
* cleanup
* change LINUX to UNIX in clrdefinitions
* Fix broken checked builds
* Remove CLRProfilingClassFactory and metadata.h include from profattach.cpp
* remove useless extern C
* Add this back in
* adding ifndef DACCESS_COMPILE
* Try building with FWD define ICLRProfiling interface
* Test commit - removing additional definition from metahost.h to see if this will pass CI runs
* Address pr comments
Diffstat (limited to 'clr.defines.targets')
| -rw-r--r-- | clr.defines.targets | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clr.defines.targets b/clr.defines.targets index b9f159eb0c..04bfbda7fc 100644 --- a/clr.defines.targets +++ b/clr.defines.targets @@ -26,7 +26,7 @@ <DefineConstants Condition="'$(FeatureDefaultInterfaces)' == 'true'">$(DefineConstants);FEATURE_DEFAULT_INTERFACES</DefineConstants> <DefineConstants Condition="'$(ProfilingSupportedBuild)' == 'true'">$(DefineConstants);PROFILING_SUPPORTED</DefineConstants> - + <DefineConstants Condition="'$(FeatureProfAttach)' == 'true'">$(DefineConstants);FEATURE_PROFAPI_ATTACH_DETACH</DefineConstants> <DefineConstants Condition="'$(TargetsUnix)' == 'true'">$(DefineConstants);PLATFORM_UNIX</DefineConstants> <DefineConstants Condition="'$(TargetsWindows)' == 'true'">$(DefineConstants);PLATFORM_WINDOWS</DefineConstants> |