summaryrefslogtreecommitdiff
path: root/build.sh
diff options
context:
space:
mode:
authorJan Vorlicek <janvorli@microsoft.com>2016-11-29 19:09:35 +0100
committerGitHub <noreply@github.com>2016-11-29 19:09:35 +0100
commit74816870ce9ff5ec41d30455a7dcc3b5d327bf45 (patch)
treefc148a063f34c8bfc70e15d24a5e4abba272f78d /build.sh
parente67851210d1c03d730a3bc97a87e8a6713bbf772 (diff)
downloadcoreclr-74816870ce9ff5ec41d30455a7dcc3b5d327bf45.tar.gz
coreclr-74816870ce9ff5ec41d30455a7dcc3b5d327bf45.tar.bz2
coreclr-74816870ce9ff5ec41d30455a7dcc3b5d327bf45.zip
Fix shared library dependencies verification on some platforms (#8349)
The existing way of verifying shared library dependencies, used for System.Globalization.Native.so, doesn't work on platforms that don't have ldd or where ldd doesn't support the `-r` option. This change makes the check happen on non-Alpine Linux only for now. It also refactors the way the check is performed. Instead of doing it post build in the build.sh, it is now performed as a postbuild phase of the System.Globalization.Native target and it is also generalized so that we can easily add such verification to other build targets. The new verify-so.sh script is also used in corefx.
Diffstat (limited to 'build.sh')
-rwxr-xr-xbuild.sh8
1 files changed, 0 insertions, 8 deletions
diff --git a/build.sh b/build.sh
index 61b5ab1120..1017d5caab 100755
--- a/build.sh
+++ b/build.sh
@@ -218,14 +218,6 @@ build_coreclr()
exit 1
fi
- echo "Verifying System.Globalization.Native.so dependencies"
-
- ldd -r $__BinDir/System.Globalization.Native.so | awk 'BEGIN {count=0} /undefined symbol:/ { if (count==0) {print "Undefined symbol(s) found:"} print " " $3; count++ } END {if (count>0) exit(1)}'
- if [ $? != 0 ]; then
- echo "Failed. System.Globalization.Native.so has undefined dependencies. These are likely ICU APIs that need to be added to icushim.h"
- exit 1
- fi
-
popd
}