diff options
author | jashook <jashoo@microsoft.com> | 2019-06-13 20:29:27 +0000 |
---|---|---|
committer | jashook <jashoo@microsoft.com> | 2019-06-13 20:29:27 +0000 |
commit | 5e00fa0e6c82f67061572c21d6bfa429ebcc84c8 (patch) | |
tree | be31b4dcfcac6f18eb894a12946fbe183cb65f84 /build.sh | |
parent | bc980f3aa76229155efb4c7e024829b31e3a9633 (diff) | |
download | coreclr-5e00fa0e6c82f67061572c21d6bfa429ebcc84c8.tar.gz coreclr-5e00fa0e6c82f67061572c21d6bfa429ebcc84c8.tar.bz2 coreclr-5e00fa0e6c82f67061572c21d6bfa429ebcc84c8.zip |
Address PR feedback.
Diffstat (limited to 'build.sh')
-rwxr-xr-x | build.sh | 19 |
1 files changed, 11 insertions, 8 deletions
@@ -151,23 +151,26 @@ restore_optdata() if [ $__isMSBuildOnNETCoreSupported == 1 ]; then # Parse the optdata package versions out of msbuild so that we can pass them on to CMake - # Writes into ${__IntermediatesDir}/optdataversion.txt - ${__ProjectDir}/dotnet.sh msbuild $OptDataProjectFilePath /t:DumpPgoDataPackageVersion ${__CommonMSBuildArgs} /nologo 2>&1 >/dev/null - if [ ! -f "${__IntermediatesDir}/optdataversion.txt" ]; then + local PgoDataPackageVersionOutputFile="${__IntermediatesDir}/optdataversion.txt" + local IbcDataPackageVersionOutputFile="${__IntermediatesDir}/ibcoptdataversion.txt" + + # Writes into ${PgoDataPackageVersionOutputFile} + ${__ProjectDir}/dotnet.sh msbuild $OptDataProjectFilePath /t:DumpPgoDataPackageVersion ${__CommonMSBuildArgs} /p:PgoDataPackageVersionOutputFile=${PgoDataPackageVersionOutputFile} /nologo 2>&1 > /dev/null + if [ $? != 0 ] || [ ! -f "${PgoDataPackageVersionOutputFile}" ]; then echo "Failed to get PGO data package version." exit $? fi - __PgoOptDataVersion=$(<"${__IntermediatesDir}/optdataversion.txt") + __PgoOptDataVersion=$(<"${PgoDataPackageVersionOutputFile}") - # Writes into ${__IntermediatesDir}/ibcoptdataversion.txt - ${__ProjectDir}/dotnet.sh msbuild $OptDataProjectFilePath /t:DumpIbcDataPackageVersion ${__CommonMSBuildArgs} /nologo 2>&1 >/dev/null - if [ ! -f "${__IntermediatesDir}/ibcoptdataversion.txt" ]; then + # Writes into ${IbcDataPackageVersionOutputFile} + ${__ProjectDir}/dotnet.sh msbuild $OptDataProjectFilePath /t:DumpIbcDataPackageVersion ${__CommonMSBuildArgs} /p:IbcDataPackageVersionOutputFile=${IbcDataPackageVersionOutputFile} /nologo 2>&1 > /dev/null + if [ $? != 0 ] || [ ! -f "${IbcDataPackageVersionOutputFile}" ]; then echo "Failed to get IBC data package version." exit $? fi - __IbcOptDataVersion=$(<"${__IntermediatesDir}/ibcoptdataversion.txt") + __IbcOptDataVersion=$(<"${IbcDataPackageVersionOutputFile}") fi } |