summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergey Andreenko <seandree@microsoft.com>2018-03-19 15:08:09 -0700
committerGitHub <noreply@github.com>2018-03-19 15:08:09 -0700
commit20f7c219e79f55ab8062282c6cb1d89310f365ea (patch)
tree92ff447575f5a971b83518da92993bfe7ad0d75f
parent39831d5bd30e0e0f1759ea3a042c73e96f8a3e87 (diff)
downloadcoreclr-20f7c219e79f55ab8062282c6cb1d89310f365ea.tar.gz
coreclr-20f7c219e79f55ab8062282c6cb1d89310f365ea.tar.bz2
coreclr-20f7c219e79f55ab8062282c6cb1d89310f365ea.zip
delete unused debug arg from genChangeLife and compChangeLife. (#17041)
* delete unused debug arg from genChangeLife(VARSET_VALARG_TP * remove unused debug arg from compChangeLife
-rw-r--r--src/jit/codegencommon.cpp12
-rw-r--r--src/jit/codegenlegacy.cpp2
-rw-r--r--src/jit/compiler.h6
-rw-r--r--src/jit/compiler.hpp2
4 files changed, 9 insertions, 13 deletions
diff --git a/src/jit/codegencommon.cpp b/src/jit/codegencommon.cpp
index 22491c8bda..2c605c9a69 100644
--- a/src/jit/codegencommon.cpp
+++ b/src/jit/codegencommon.cpp
@@ -1082,17 +1082,13 @@ void Compiler::compUpdateLifeVar(GenTree* tree, VARSET_TP* pLastUseVars)
template void Compiler::compUpdateLifeVar<false>(GenTree* tree, VARSET_TP* pLastUseVars);
template <bool ForCodeGen>
-void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree))
+void Compiler::compChangeLife(VARSET_VALARG_TP newLife)
{
LclVarDsc* varDsc;
#ifdef DEBUG
if (verbose)
{
- if (tree != nullptr)
- {
- Compiler::printTreeID(tree);
- }
printf("Change life %s ", VarSetOps::ToString(this, compCurLife));
dumpConvertedVarSet(this, compCurLife);
printf(" -> %s ", VarSetOps::ToString(this, newLife));
@@ -1163,7 +1159,7 @@ void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree))
{
codeGen->gcInfo.gcRegByrefSetCur &= ~regMask;
}
- codeGen->genUpdateRegLife(varDsc, false /*isBorn*/, true /*isDying*/ DEBUGARG(tree));
+ codeGen->genUpdateRegLife(varDsc, false /*isBorn*/, true /*isDying*/ DEBUGARG(nullptr));
}
#ifndef LEGACY_BACKEND
// This isn't in a register, so update the gcVarPtrSetCur.
@@ -1197,7 +1193,7 @@ void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree))
#endif // DEBUG
VarSetOps::RemoveElemD(this, codeGen->gcInfo.gcVarPtrSetCur, bornVarIndex);
#endif // !LEGACY_BACKEND
- codeGen->genUpdateRegLife(varDsc, true /*isBorn*/, false /*isDying*/ DEBUGARG(tree));
+ codeGen->genUpdateRegLife(varDsc, true /*isBorn*/, false /*isDying*/ DEBUGARG(nullptr));
regMaskTP regMask = varDsc->lvRegMask();
if (isGCRef)
{
@@ -1222,7 +1218,7 @@ void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree))
}
// Need an explicit instantiation.
-template void Compiler::compChangeLife<true>(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree));
+template void Compiler::compChangeLife<true>(VARSET_VALARG_TP newLife);
#ifdef LEGACY_BACKEND
diff --git a/src/jit/codegenlegacy.cpp b/src/jit/codegenlegacy.cpp
index 7fb946dbed..648a48162d 100644
--- a/src/jit/codegenlegacy.cpp
+++ b/src/jit/codegenlegacy.cpp
@@ -12971,7 +12971,7 @@ void CodeGen::genCodeForBBlist()
gcInfo.gcMarkRegSetNpt(gcrefRegs | byrefRegs);
if (!VarSetOps::Equal(compiler, compiler->compCurLife, block->bbLiveOut))
- compiler->genChangeLife(block->bbLiveOut DEBUGARG(NULL));
+ compiler->genChangeLife(block->bbLiveOut);
/* Both stacks should always be empty on exit from a basic block */
diff --git a/src/jit/compiler.h b/src/jit/compiler.h
index f1c9529205..0bbe9e2dae 100644
--- a/src/jit/compiler.h
+++ b/src/jit/compiler.h
@@ -7249,11 +7249,11 @@ public:
GenTree* compCurLifeTree; // node after which compCurLife has been computed
template <bool ForCodeGen>
- void compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree));
+ void compChangeLife(VARSET_VALARG_TP newLife);
- void genChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree))
+ void genChangeLife(VARSET_VALARG_TP newLife)
{
- compChangeLife</*ForCodeGen*/ true>(newLife DEBUGARG(tree));
+ compChangeLife</*ForCodeGen*/ true>(newLife);
}
template <bool ForCodeGen>
diff --git a/src/jit/compiler.hpp b/src/jit/compiler.hpp
index 36012fbc38..2a6fd86153 100644
--- a/src/jit/compiler.hpp
+++ b/src/jit/compiler.hpp
@@ -3589,7 +3589,7 @@ inline void Compiler::compUpdateLife(VARSET_VALARG_TP newLife)
{
if (!VarSetOps::Equal(this, compCurLife, newLife))
{
- compChangeLife<ForCodeGen>(newLife DEBUGARG(nullptr));
+ compChangeLife<ForCodeGen>(newLife);
}
#ifdef DEBUG
else