diff options
author | Noah Falk <noahfalk@users.noreply.github.com> | 2017-10-20 01:15:16 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-10-20 01:15:16 -0700 |
commit | 85819d322a72636eb65128aa2e5dfedc8843e073 (patch) | |
tree | 827aca9b551ddc6136c277ffe2b822cbe1f2d6a9 | |
parent | 92b6b7d6b7354a2d69c706f674c6a4d59272169f (diff) | |
download | coreclr-85819d322a72636eb65128aa2e5dfedc8843e073.tar.gz coreclr-85819d322a72636eb65128aa2e5dfedc8843e073.tar.bz2 coreclr-85819d322a72636eb65128aa2e5dfedc8843e073.zip |
Update comments in TieredCompilationManager (#14610)
We've continued plugging away and the status in the comment was out-of-date.
-rw-r--r-- | src/vm/tieredcompilation.cpp | 28 |
1 files changed, 10 insertions, 18 deletions
diff --git a/src/vm/tieredcompilation.cpp b/src/vm/tieredcompilation.cpp index 97961df112..48c6670fb2 100644 --- a/src/vm/tieredcompilation.cpp +++ b/src/vm/tieredcompilation.cpp @@ -24,25 +24,17 @@ // // This feature is incomplete and currently experimental. To enable it // you need to set COMPLUS_EXPERIMENTAL_TieredCompilation = 1. When the environment -// variable is unset the runtime should work as normal, but when it is set there are -// anticipated incompatibilities and limited cross cutting test coverage so far. -// Profiler - Anticipated incompatible with ReJIT, untested in general -// ETW - Anticipated incompatible with the ReJIT id of the MethodJitted rundown events -// Managed debugging - Anticipated incompatible with breakpoints/stepping that are -// active when a method is recompiled. -// -// -// Testing that has been done so far largely consists of regression testing with -// the environment variable off + functional/perf testing of the Music Store ASP.Net -// workload as a basic example that the feature can work. Running the coreclr repo -// tests with the env var on generates about a dozen failures in JIT tests. The issues -// are likely related to assertions about optimization behavior but haven't been -// properly investigated yet. +// variable is unset the runtime should work as normal, but when it is there are a few +// known issues +// ETW - Native to IL maps aren't correctly emitted (probably tier1 wrong, tier0 right) +// Profiler - Still missing APIs that allow profilers to correctly get native to IL +// maps for all code bodies. // -// If you decide to try this out on a new workload and run into trouble a quick note -// on github is appreciated but this code may have high churn for a while to come and -// there will be no sense investing a lot of time investigating only to have it rendered -// moot by changes. I aim to keep this comment updated as things change. +// Diagnostic tools have minimal testing that we are aware of and its possible they +// made additional assumptions about runtime implementation that have been invalidated +// by this feature. VS debugging does appear to work at a basic level at least. +// +// I aim to keep this comment updated as things change. // // // # Important entrypoints in this code: |