diff options
| author | Jacek Blaszczynski <biosciencenow@outlook.com> | 2018-07-30 02:56:32 +0200 |
|---|---|---|
| committer | Jan Kotas <jkotas@microsoft.com> | 2018-07-29 17:56:32 -0700 |
| commit | 93cf012db8396f5ea16f70b781a5de0d012fc65d (patch) | |
| tree | d9aa866239a1adccdae9dbdfcdacae8ee1cabbe0 | |
| parent | 5d31194880e800a9df8eef76e7a0a53646aa72d3 (diff) | |
| download | coreclr-93cf012db8396f5ea16f70b781a5de0d012fc65d.tar.gz coreclr-93cf012db8396f5ea16f70b781a5de0d012fc65d.tar.bz2 coreclr-93cf012db8396f5ea16f70b781a5de0d012fc65d.zip | |
Fix invalid IntPtr == null comparisons, set strict mode for Roslyn (#19191)
Issue reported in https://github.com/dotnet/corefx/issues/31456
Solution is to compare always against IntPtr.Zero and use Roslyn
stric mode for reporting warnings for IntPtr == null comparisons
| -rw-r--r-- | Directory.Build.props | 4 | ||||
| -rw-r--r-- | src/System.Private.CoreLib/src/System/StubHelpers.cs | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index 3efd9a363c..2082362adc 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -2,4 +2,8 @@ <PropertyGroup> <CL_MPCount>$(NumberOfCores)</CL_MPCount> </PropertyGroup> + <PropertyGroup> + <!-- Enables Strict mode for Roslyn compiler --> + <Features>strict</Features> + </PropertyGroup> </Project> diff --git a/src/System.Private.CoreLib/src/System/StubHelpers.cs b/src/System.Private.CoreLib/src/System/StubHelpers.cs index 6d9e7a8cea..b8e34e0e6c 100644 --- a/src/System.Private.CoreLib/src/System/StubHelpers.cs +++ b/src/System.Private.CoreLib/src/System/StubHelpers.cs @@ -200,7 +200,7 @@ namespace System.StubHelpers internal static unsafe void ConvertToManaged(StringBuilder sb, IntPtr pNative) { - if (pNative == null) + if (pNative == IntPtr.Zero) return; int nbBytes = StubHelpers.strlen((sbyte*)pNative); |