summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRuss Keldorph <Russ.Keldorph@microsoft.com>2016-05-13 21:19:36 -0700
committerRuss Keldorph <Russ.Keldorph@microsoft.com>2016-05-13 21:37:40 -0700
commit195baf674a92c7ddb0ba4dac425abf1a8b0402cf (patch)
treef1cbcc353fcfb8cec7478733db309baf3303ebf8
parent97b4ff0b438261ba11b357008630076054a6f25d (diff)
downloadcoreclr-195baf674a92c7ddb0ba4dac425abf1a8b0402cf.tar.gz
coreclr-195baf674a92c7ddb0ba4dac425abf1a8b0402cf.tar.bz2
coreclr-195baf674a92c7ddb0ba4dac425abf1a8b0402cf.zip
Re-enable arrres.il test
arrres.il is a quesionable test case because it relies on finalizers being run even though the JIT is allowed to extend the lifetime of objects beyond the point where finalizer effects are checked. The test could be fixed, but for now I'm just marking it as requiring optimization, which is what has been done previously. I'm deleting the "dbg" project because it is the same as the "rel" project except that it disables optimization. Fixes #2330
-rw-r--r--tests/issues.targets6
-rw-r--r--tests/src/JIT/Methodical/Arrays/misc/_il_dbgarrres.ilproj49
-rw-r--r--tests/src/JIT/Methodical/Arrays/misc/_il_relarrres.ilproj3
-rw-r--r--tests/testsUnsupportedOutsideWindows.txt2
-rw-r--r--tests/x86_legacy_backend_issues.targets6
5 files changed, 2 insertions, 64 deletions
diff --git a/tests/issues.targets b/tests/issues.targets
index dcda362611..addeacffde 100644
--- a/tests/issues.targets
+++ b/tests/issues.targets
@@ -7,12 +7,6 @@
<ExcludeList Include="$(XunitTestBinBase)\JIT\opt\Tailcall\TailcallVerifyWithPrefix\TailcallVerifyWithPrefix.cmd" >
<Issue>2329</Issue>
</ExcludeList>
- <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\Arrays\misc\_il_dbgarrres\_il_dbgarrres.cmd" >
- <Issue>2330</Issue>
- </ExcludeList>
- <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\Arrays\misc\_il_relarrres\_il_relarrres.cmd" >
- <Issue>2330</Issue>
- </ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\delegate\_simpleoddpower_il_d\_simpleoddpower_il_d.cmd" >
<Issue>2407</Issue>
</ExcludeList>
diff --git a/tests/src/JIT/Methodical/Arrays/misc/_il_dbgarrres.ilproj b/tests/src/JIT/Methodical/Arrays/misc/_il_dbgarrres.ilproj
deleted file mode 100644
index f66dabd3cb..0000000000
--- a/tests/src/JIT/Methodical/Arrays/misc/_il_dbgarrres.ilproj
+++ /dev/null
@@ -1,49 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
- <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
- <PropertyGroup>
- <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
- <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
- <AssemblyName>$(MSBuildProjectName)</AssemblyName>
- <SchemaVersion>2.0</SchemaVersion>
- <ProjectGuid>{95DFC527-4DC1-495E-97D7-E94EE1F7140D}</ProjectGuid>
- <OutputType>Exe</OutputType>
- <AppDesignerFolder>Properties</AppDesignerFolder>
- <FileAlignment>512</FileAlignment>
- <ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
- <ReferencePath>$(ProgramFiles)\Common Files\microsoft shared\VSTT\11.0\UITestExtensionPackages</ReferencePath>
- <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
- <RestorePackages>true</RestorePackages>
- <NuGetPackageImportStamp>7a9bfb7d</NuGetPackageImportStamp>
- </PropertyGroup>
- <!-- Default configurations to help VS understand the configurations -->
- <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
- </PropertyGroup>
- <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
- </PropertyGroup>
- <ItemGroup>
- <CodeAnalysisDependentAssemblyPaths Condition=" '$(VS100COMNTOOLS)' != '' " Include="$(VS100COMNTOOLS)..\IDE\PrivateAssemblies">
- <Visible>False</Visible>
- </CodeAnalysisDependentAssemblyPaths>
- </ItemGroup>
- <PropertyGroup>
-
- </PropertyGroup>
- <ItemGroup>
- <Compile Include="arrres.il" />
- </ItemGroup>
- <ItemGroup>
- <None Include="$(JitPackagesConfigFileDirectory)minimal\project.json" />
- <None Include="app.config" />
- </ItemGroup>
- <ItemGroup>
- <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
- </ItemGroup>
- <PropertyGroup>
- <ProjectJson>$(JitPackagesConfigFileDirectory)minimal\project.json</ProjectJson>
- <ProjectLockJson>$(JitPackagesConfigFileDirectory)minimal\project.lock.json</ProjectLockJson>
- </PropertyGroup>
- <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
- <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' ">
- </PropertyGroup>
-</Project> \ No newline at end of file
diff --git a/tests/src/JIT/Methodical/Arrays/misc/_il_relarrres.ilproj b/tests/src/JIT/Methodical/Arrays/misc/_il_relarrres.ilproj
index 1ed68d99fa..a1d8dde445 100644
--- a/tests/src/JIT/Methodical/Arrays/misc/_il_relarrres.ilproj
+++ b/tests/src/JIT/Methodical/Arrays/misc/_il_relarrres.ilproj
@@ -28,6 +28,7 @@
</ItemGroup>
<PropertyGroup>
<DebugType>PdbOnly</DebugType>
+ <JitOptimizationSensitive>true</JitOptimizationSensitive>
</PropertyGroup>
<ItemGroup>
<Compile Include="arrres.il" />
@@ -46,4 +47,4 @@
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
<PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' ">
</PropertyGroup>
-</Project> \ No newline at end of file
+</Project>
diff --git a/tests/testsUnsupportedOutsideWindows.txt b/tests/testsUnsupportedOutsideWindows.txt
index 7833bcb900..bbee3e9038 100644
--- a/tests/testsUnsupportedOutsideWindows.txt
+++ b/tests/testsUnsupportedOutsideWindows.txt
@@ -215,8 +215,6 @@ JIT/jit64/mcc/interop/mcc_i85/mcc_i85.sh
JIT/jit64/mcc/interop/mcc_i86/mcc_i86.sh
JIT/jit64/mcc/interop/mcc_i87/mcc_i87.sh
JIT/jit64/regress/vsw/286991/test/test.sh
-JIT/Methodical/Arrays/misc/_il_dbgarrres/_il_dbgarrres.sh
-JIT/Methodical/Arrays/misc/_il_relarrres/_il_relarrres.sh
JIT/Methodical/cctor/xassem/xprecise3_cs_d/xprecise3_cs_d.sh
JIT/Methodical/cctor/xassem/xprecise3_cs_do/xprecise3_cs_do.sh
JIT/Methodical/cctor/xassem/xprecise3_cs_r/xprecise3_cs_r.sh
diff --git a/tests/x86_legacy_backend_issues.targets b/tests/x86_legacy_backend_issues.targets
index 42a7f32069..a61929c1a8 100644
--- a/tests/x86_legacy_backend_issues.targets
+++ b/tests/x86_legacy_backend_issues.targets
@@ -310,9 +310,6 @@
<ExcludeList Include="$(XunitTestBinBase)\JIT\Regression\CLR-x86-JIT\V1.2-Beta1\b103058\b103058\b103058.cmd">
<Issue>needs triage</Issue>
</ExcludeList>
- <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\Arrays\misc\_il_relarrres\_il_relarrres.cmd">
- <Issue>needs triage</Issue>
- </ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)\JIT\opt\perf\doublealign\Locals\Locals.cmd">
<Issue>needs triage</Issue>
</ExcludeList>
@@ -322,9 +319,6 @@
<ExcludeList Include="$(XunitTestBinBase)\JIT\Performance\CodeQuality\Roslyn\CscBench\CscBench.cmd">
<Issue>needs triage</Issue>
</ExcludeList>
- <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\Arrays\misc\_il_dbgarrres\_il_dbgarrres.cmd">
- <Issue>needs triage</Issue>
- </ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)\JIT\Directed\lifetime\lifetime2\lifetime2.cmd">
<Issue>needs triage</Issue>
</ExcludeList>