diff options
| author | Bruce Forstall <Bruce_Forstall@msn.com> | 2018-11-01 10:56:53 -0700 |
|---|---|---|
| committer | Bruce Forstall <Bruce_Forstall@msn.com> | 2018-11-01 10:56:53 -0700 |
| commit | 9b240c6ab12a312d206118b3e3009bd78c68f3d5 (patch) | |
| tree | db1a9bf6617450b1873310285f05303f1b2061c7 | |
| parent | df0cd2cd2c026af3aff78206bed6b45429dc9e19 (diff) | |
| download | coreclr-9b240c6ab12a312d206118b3e3009bd78c68f3d5.tar.gz coreclr-9b240c6ab12a312d206118b3e3009bd78c68f3d5.tar.bz2 coreclr-9b240c6ab12a312d206118b3e3009bd78c68f3d5.zip | |
Fix expected Pri-1 test count
https://github.com/dotnet/coreclr/pull/20693 reduced the number of
Pri-1 tests significantly, which caused this error to appear on
some Pri-1 builds, e.g., Ubuntu x64 Checked builds.
| -rw-r--r-- | tests/runtest.proj | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/runtest.proj b/tests/runtest.proj index 9c541f67cf..81b09be9f8 100644 --- a/tests/runtest.proj +++ b/tests/runtest.proj @@ -57,9 +57,9 @@ <!-- Target to check the test build, to see if it looks ok. We've had several cases where a change inadvertently and drastically changes the set of tests that are built, and that change is unnoticed. The most common case is for a build of the Priority 1 tests to only build the Priority 0 tests. This target is run after a test build to verify that the basic number of tests that were - built is basically what was expected. When this was written, there were about 2500 Priority 0 tests and about 12270 Priority 1 - tests (differing slightly based on platform). We currently check that the number of Priority 0 tests is greater than 2000 and - less than 3000, and the number of Priority 1 tests is greater than 10000. + built is basically what was expected. When this was written, there were about 2500 Priority 0 tests and about 10268 Priority 1 + tests on Windows, 9976 on Ubuntu (it differs slightly based on platform). We currently check that the number of Priority 0 tests + is greater than 2000 and less than 3000, and the number of Priority 1 tests is greater than 9000. --> <Target Name="CheckTestBuild" DependsOnTargets="GetListOfTestCmds"> <Error Condition="!Exists('$(XunitTestBinBase)')" @@ -73,7 +73,7 @@ <Error Condition="'$(CLRTestPriorityToBuild)' == '0' and '$(TestCount)' <= 2000" Text="Unexpected test count. Expected > 2000, found $(TestCount).'" /> <Error Condition="'$(CLRTestPriorityToBuild)' == '0' and '$(TestCount)' >= 3000" Text="Unexpected test count. Expected < 3000, found $(TestCount).'" /> - <Error Condition="'$(CLRTestPriorityToBuild)' == '1' and '$(TestCount)' <= 10000" Text="Unexpected test count. Expected > 10000, found $(TestCount).'" /> + <Error Condition="'$(CLRTestPriorityToBuild)' == '1' and '$(TestCount)' <= 9000" Text="Unexpected test count. Expected > 9000, found $(TestCount).'" /> <Error Condition="'$(CLRTestPriorityToBuild)' != '0' and '$(CLRTestPriorityToBuild)' != '1'" Text="Unknown priority $(CLRTestPriorityToBuild)" /> </Target> |