diff options
| author | Carol Eidt <carol.eidt@microsoft.com> | 2016-05-16 16:29:13 -0700 |
|---|---|---|
| committer | Carol Eidt <carol.eidt@microsoft.com> | 2016-05-16 16:29:13 -0700 |
| commit | b0de8b0bc7c1274442ed8a64d41d72c7c2a0f8c3 (patch) | |
| tree | d6016d901c0041ce3a58a3409c8937ba5bdbc675 | |
| parent | d84bcf4426bdff27b2b06137c6816861970f0f43 (diff) | |
| parent | cde5a27915541a3d9388d4c16145e1b67441a3f6 (diff) | |
| download | coreclr-b0de8b0bc7c1274442ed8a64d41d72c7c2a0f8c3.tar.gz coreclr-b0de8b0bc7c1274442ed8a64d41d72c7c2a0f8c3.tar.bz2 coreclr-b0de8b0bc7c1274442ed8a64d41d72c7c2a0f8c3.zip | |
Merge pull request #4962 from CarolEidt/FixIssue3964
Fix CircleInConvex to check result within 1 ULP
| -rw-r--r-- | tests/issues.targets | 12 | ||||
| -rw-r--r-- | tests/src/JIT/SIMD/CircleInConvex.cs | 7 | ||||
| -rw-r--r-- | tests/x86_legacy_backend_issues.targets | 6 |
3 files changed, 10 insertions, 15 deletions
diff --git a/tests/issues.targets b/tests/issues.targets index 5214af42f6..b7301e0262 100644 --- a/tests/issues.targets +++ b/tests/issues.targets @@ -261,12 +261,6 @@ <ExcludeList Include="$(XunitTestBinBase)\JIT\Regression\Dev11\External\dev11_239804\ShowLocallocAlignment\ShowLocallocAlignment.cmd"> <Issue>needs triage</Issue> </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\SIMD\CircleInConvex_r\CircleInConvex_r.cmd"> - <Issue>3964</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\SIMD\CircleInConvex_ro\CircleInConvex_ro.cmd"> - <Issue>3964</Issue> - </ExcludeList> <ExcludeList Include="$(XunitTestBinBase)\managed\Compilation\Compilation\Compilation.cmd"> <Issue>needs triage</Issue> </ExcludeList> @@ -296,5 +290,11 @@ <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\MDArray\basics\stringarr_cs_do\stringarr_cs_do.cmd"> <Issue>4844</Issue> </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)\JIT\SIMD\CircleInConvex_r\CircleInConvex_r.cmd"> + <Issue>4992</Issue> + </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)\JIT\SIMD\CircleInConvex_ro\CircleInConvex_ro.cmd"> + <Issue>4992</Issue> + </ExcludeList> </ItemGroup> </Project> diff --git a/tests/src/JIT/SIMD/CircleInConvex.cs b/tests/src/JIT/SIMD/CircleInConvex.cs index a2c0c3239c..c858386d76 100644 --- a/tests/src/JIT/SIMD/CircleInConvex.cs +++ b/tests/src/JIT/SIMD/CircleInConvex.cs @@ -17,7 +17,7 @@ namespace ClassLibrary public class test { - const float EPS = 1E-9F; + const float EPS = Single.Epsilon; const int steps = 100; const float INF = Single.PositiveInfinity; @@ -259,8 +259,9 @@ namespace ClassLibrary float r; FindCircle(points, out O, out r); - float expRes = 7.565624E7F; - if (Math.Abs(r - expRes) > EPS) + float expRes = 75656240.0F; + float ulp = 8.0F; + if (Math.Abs(r - expRes) <= ulp) return 100; return 0; } diff --git a/tests/x86_legacy_backend_issues.targets b/tests/x86_legacy_backend_issues.targets index 6c80805b65..65578d57ea 100644 --- a/tests/x86_legacy_backend_issues.targets +++ b/tests/x86_legacy_backend_issues.targets @@ -163,9 +163,6 @@ <ExcludeList Include="$(XunitTestBinBase)\JIT\opt\Inline\regression\mismatch32\mismatch32\mismatch32.cmd"> <Issue>needs triage</Issue> </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\SIMD\CircleInConvex_ro\CircleInConvex_ro.cmd"> - <Issue>needs triage</Issue> - </ExcludeList> <ExcludeList Include="$(XunitTestBinBase)\JIT\jit64\localloc\verify\verify01_small\verify01_small.cmd"> <Issue>needs triage</Issue> </ExcludeList> @@ -256,9 +253,6 @@ <ExcludeList Include="$(XunitTestBinBase)\JIT\Directed\intrinsic\interlocked\rva_rvastatic3\rva_rvastatic3.cmd"> <Issue>needs triage</Issue> </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\SIMD\CircleInConvex_r\CircleInConvex_r.cmd"> - <Issue>needs triage</Issue> - </ExcludeList> <ExcludeList Include="$(XunitTestBinBase)\JIT\Regression\VS-ia64-JIT\V2.0-Beta2\b410474\b410474\b410474.cmd Timed Out"> <Issue>needs triage</Issue> </ExcludeList> |