summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike McLaughlin <mikem@microsoft.com>2016-06-19 15:24:49 -0700
committerGitHub <noreply@github.com>2016-06-19 15:24:49 -0700
commit4144d4cb720399fb9fe0a8a03bffac07ba8fb065 (patch)
tree110db1945b57a7bd2be107b36200412e2e0fc25b
parent5546991296f5e407cf6797a914092cf8317b0ec0 (diff)
downloadcoreclr-4144d4cb720399fb9fe0a8a03bffac07ba8fb065.tar.gz
coreclr-4144d4cb720399fb9fe0a8a03bffac07ba8fb065.tar.bz2
coreclr-4144d4cb720399fb9fe0a8a03bffac07ba8fb065.zip
Fix source/line info in unhandled exceptions (#5874)
* Fix no source/line info for unhandled exceptions. Issue #5828. * Remove comment.
-rw-r--r--src/mscorlib/src/System/Exception.cs15
1 files changed, 2 insertions, 13 deletions
diff --git a/src/mscorlib/src/System/Exception.cs b/src/mscorlib/src/System/Exception.cs
index 51127a513c..b08c12de61 100644
--- a/src/mscorlib/src/System/Exception.cs
+++ b/src/mscorlib/src/System/Exception.cs
@@ -910,19 +910,8 @@ namespace System {
//however if something wrong happens we still can call the usual ToString
}
- // Get the current stack trace string. On CoreCLR we don't bother
- // to try and include file/line-number information because all AppDomains
- // are sandboxed, and so this won't succeed in most (or all) cases. Therefore the
- // Demand and exception overhead is a waste.
- // We currently have some bugs in watson bucket generation where the SecurityException
- // here causes us to lose saved bucket parameters. By not even doing the demand
- // we avoid those problems (although there are deep underlying problems that need to
- // be fixed there - relying on this to avoid problems is incomplete and brittle).
- bool fGetFileLineInfo = true;
-#if FEATURE_CORECLR
- fGetFileLineInfo = false;
-#endif
- return ToString(fGetFileLineInfo, true);
+ // Get the current stack trace string.
+ return ToString(true, true);
}
#if !FEATURE_CORECLR