diff options
| author | Gaurav Khanna <gkhanna@microsoft.com> | 2017-04-18 14:02:14 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-04-18 14:02:14 -0700 |
| commit | 796cd8bd3c153af929844fcc4b4c950c1f9ad690 (patch) | |
| tree | d1cc02e463ae675d993b91d509957a5002b83201 | |
| parent | 0623eb3c85078d84284e5c75eab1ce978ede62f7 (diff) | |
| download | coreclr-796cd8bd3c153af929844fcc4b4c950c1f9ad690.tar.gz coreclr-796cd8bd3c153af929844fcc4b4c950c1f9ad690.tar.bz2 coreclr-796cd8bd3c153af929844fcc4b4c950c1f9ad690.zip | |
Remove /RELEASE option required for device drivers (#11023)
| -rw-r--r-- | CMakeLists.txt | 1 | ||||
| -rw-r--r-- | src/dlls/mscoree/coreclr/CMakeLists.txt | 4 |
2 files changed, 4 insertions, 1 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 7583f1850e..f55b54c498 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -328,7 +328,6 @@ if (WIN32) endif () set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /LARGEADDRESSAWARE") # can handle addresses larger than 2 gigabytes - set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /RELEASE") #sets the checksum in the header set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /NXCOMPAT") #Compatible with Data Execution Prevention set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DYNAMICBASE") #Use address space layout randomization set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /PDBCOMPRESS") #shrink pdb size diff --git a/src/dlls/mscoree/coreclr/CMakeLists.txt b/src/dlls/mscoree/coreclr/CMakeLists.txt index 3144b5139f..afa253f08f 100644 --- a/src/dlls/mscoree/coreclr/CMakeLists.txt +++ b/src/dlls/mscoree/coreclr/CMakeLists.txt @@ -5,6 +5,10 @@ if (WIN32) set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /ENTRY:CoreDllMain") + # Incremental linking results in the linker inserting extra padding and routing function calls via thunks that can break the + # invariants (e.g. size of region between Jit_PatchedCodeLast-Jit_PatchCodeStart needs to fit in a page). + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /INCREMENTAL:NO") + # Delay load libraries required for WinRT as that is not supported on all platforms set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DELAYLOAD:api-ms-win-core-winrt-string-l1-1-0.dll") set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DELAYLOAD:api-ms-win-core-winrt-l1-1-0.dll") |