diff options
| author | Brian Sullivan <briansul@microsoft.com> | 2019-01-10 16:02:10 -0800 |
|---|---|---|
| committer | Brian Sullivan <briansul@microsoft.com> | 2019-01-10 16:02:10 -0800 |
| commit | b4cbfba170ccdf277a5080bf24460fde4c41bbf3 (patch) | |
| tree | 131148cf3e1ffd73a158c45023fe01c1ea06a951 | |
| parent | b9fafc63c6d2a90f0444d809269380fd593c03a3 (diff) | |
| download | coreclr-b4cbfba170ccdf277a5080bf24460fde4c41bbf3.tar.gz coreclr-b4cbfba170ccdf277a5080bf24460fde4c41bbf3.tar.bz2 coreclr-b4cbfba170ccdf277a5080bf24460fde4c41bbf3.zip | |
Code Review feedback
Change test priority to 0
| -rw-r--r-- | src/jit/compiler.h | 2 | ||||
| -rw-r--r-- | src/jit/importer.cpp | 10 | ||||
| -rw-r--r-- | tests/src/JIT/Regression/JitBlue/DevDiv_754566/DevDiv_754566.ilprog | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/src/jit/compiler.h b/src/jit/compiler.h index 5f42bb5a9c..7f51332846 100644 --- a/src/jit/compiler.h +++ b/src/jit/compiler.h @@ -3330,7 +3330,7 @@ public: CORINFO_CONTEXT_HANDLE* contextHandle, CORINFO_CONTEXT_HANDLE* exactContextHandle, bool isLateDevirtualization, - bool isTailCall); + bool isExplicitTailCall); //========================================================================= // PROTECTED diff --git a/src/jit/importer.cpp b/src/jit/importer.cpp index be735a200b..27ea06abaf 100644 --- a/src/jit/importer.cpp +++ b/src/jit/importer.cpp @@ -5276,7 +5276,7 @@ BOOL Compiler::verIsSDArray(typeInfo ti) typeInfo Compiler::verGetArrayElemType(typeInfo arrayObjectType) { - assert(!arrayObjectType.IsNullObjRef()); // you need to check for null explictly since that is a success case + assert(!arrayObjectType.IsNullObjRef()); // you need to check for null explicitly since that is a success case if (!verIsSDArray(arrayObjectType)) { @@ -20175,7 +20175,7 @@ bool Compiler::IsMathIntrinsic(GenTree* tree) // contextHandle -- [IN/OUT] context handle for the call. Updated iff call devirtualized. // exactContextHnd -- [OUT] updated context handle iff call devirtualized // isLateDevirtualization -- if devirtualization is happening after importation -// isTailCall -- [IN/OUT] true if we plan on using a tail call +// isExplicitTailCalll -- [IN] true if we plan on using an explicit tail call // // Notes: // Virtual calls in IL will always "invoke" the base class method. @@ -20210,7 +20210,7 @@ void Compiler::impDevirtualizeCall(GenTreeCall* call, CORINFO_CONTEXT_HANDLE* contextHandle, CORINFO_CONTEXT_HANDLE* exactContextHandle, bool isLateDevirtualization, - bool isTailCall) + bool isExplicitTailCall) { assert(call != nullptr); assert(method != nullptr); @@ -20561,9 +20561,9 @@ void Compiler::impDevirtualizeCall(GenTreeCall* call, { JITDUMP("Now have direct call to boxed entry point, looking for unboxed entry point\n"); - if (isTailCall) + if (isExplicitTailCall) { - JITDUMP("Call is an explcit tail call, we cannot perform an unbox\n"); + JITDUMP("Call is an explicit tail call, we cannot perform an unbox\n"); return; } diff --git a/tests/src/JIT/Regression/JitBlue/DevDiv_754566/DevDiv_754566.ilprog b/tests/src/JIT/Regression/JitBlue/DevDiv_754566/DevDiv_754566.ilprog index 9199c02f2d..d30b4aeb0c 100644 --- a/tests/src/JIT/Regression/JitBlue/DevDiv_754566/DevDiv_754566.ilprog +++ b/tests/src/JIT/Regression/JitBlue/DevDiv_754566/DevDiv_754566.ilprog @@ -10,7 +10,7 @@ <OutputType>Exe</OutputType> <ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir> - <CLRTestPriority>1</CLRTestPriority> + <CLRTestPriority>0</CLRTestPriority> </PropertyGroup> <!-- Default configurations to help VS understand the configurations --> <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "></PropertyGroup> |