summaryrefslogtreecommitdiff
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2018-09-19Fixed null dereferencingsubmit/tizen_5.0/20181101.000006submit/tizen/20180919.090201accepted/tizen/unified/20180919.142036accepted/tizen/5.0/unified/20181102.025128Jaehyun Kim1-1/+5
Change-Id: I969a45edc0d4e16d61de0050466cd80c92c7c5e1 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2018-09-13Fixed 'incompatible pointer type' warningsubmit/tizen/20180913.042841accepted/tizen/unified/20180914.073119Jaehyun Kim1-1/+1
Change-Id: If6a491f11ab73e2039d3194b8a02a24313fa78d7 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2018-08-24[connman] Added Tizen Wi-Fi Meshsubmit/tizen/20180824.072908Nishant Chaprana2-2/+868
Change-Id: Iec2ec99fb7d4fc6d9c0539e5a9e7c903e1969580 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2018-06-28Fixed an issue where communication with the telephony failed.submit/tizen/20180703.012932accepted/tizen/unified/20180703.062157Jaehyun Kim1-9/+10
Change-Id: I0fee6ddc39aa6eacb268ade832a442c90a5961bd Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2018-06-11telephony: Fixed memory leakSaurav Babu1-5/+6
Valgrind reported memory leak with below backtrace ==3471== 1,934 (80 direct, 1,854 indirect) bytes in 2 blocks are definitely lost in loss record 190 of 194 ==3471== at 0x484801C: calloc (vg_replace_malloc.c:711) ==3471== by 0x49D687B: dbus_malloc0 (dbus-memory.c:572) ==3471== by 0x49BB9A3: _dbus_pending_call_new_unlocked (dbus-pending-call.c:124) ==3471== by 0x4995963: dbus_connection_send_with_reply (dbus-connection.c:3449) ==3471== by 0x135D8D: __dbus_request.constprop.8 (telephony.c:396) ==3471== by 0x135E6D: __request_get_services (telephony.c:477) ==3471== by 0x136F19: __add_modem (telephony.c:802) ==3471== by 0x13732F: __response_get_modems (telephony.c:464) ==3471== by 0x498FABB: complete_pending_call_and_unlock (dbus-connection.c:2340) ==3471== by 0x49981BF: dbus_connection_dispatch (dbus-connection.c:4757) ==3471== by 0x18E815: message_dispatch (mainloop.c:72) ==3471== by 0x48BB8E7: g_main_dispatch (gmain.c:3234) ==3471== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887 When dbus response is received then we should unref memory allocated by libdbus Change-Id: I81c514506f0df42e537d63382b2eb2ebc51c58c8 Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2018-06-11gsupplicant: Fixed invalid read issueSaurav Babu1-0/+17
==1071== Invalid read of size 4 ==1071== at 0x48DBB00: g_slist_length (gslist.c:856) ==1071== by 0x12A3C7: add_or_replace_bss_to_network (supplicant.c:1930) ==1071== by 0x12BB4D: signal_bss_changed (supplicant.c:3194) ==1071== by 0x12AFD1: g_supplicant_filter (supplicant.c:4038) ==1071== by 0x4998A17: dbus_connection_dispatch (dbus-connection.c:4808) ==1071== by 0x18E931: message_dispatch (mainloop.c:76) ==1071== by 0x48BB8E7: g_main_dispatch (gmain.c:3234) ==1071== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887) ==1071== by 0x48BBC77: g_main_context_iterate.isra.30 (gmain.c:3960) ==1071== by 0x48BBFD7: g_main_loop_run (gmain.c:4156) ==1071== by 0x119389: main (main.c:851) ==1071== Address 0x4e800a4 is 4 bytes inside a block of size 8 free'd ==1071== at 0x4846EC8: free (vg_replace_malloc.c:530) ==1071== by 0x48DB10F: g_slice_free_chain_with_offset (gslice.c:1232) ==1071== by 0x12A03F: remove_bss (supplicant.c:841) ==1071== by 0x48A858F: g_hash_table_remove_all_nodes.part.0 (ghash.c:548) ==1071== by 0x48A95B7: g_hash_table_remove_all_nodes (ghash.c:1428) ==1071== by 0x48A95B7: g_hash_table_remove_all (ghash.c:1431) ==1071== by 0x48A964B: g_hash_table_destroy (ghash.c:1124) ==1071== by 0x12A8E5: remove_network (supplicant.c:814) ==1071== by 0x48A8A3F: g_hash_table_remove_internal (ghash.c:1360) ==1071== by 0x12BB47: signal_bss_changed (supplicant.c:3192) ==1071== by 0x12AFD1: g_supplicant_filter (supplicant.c:4038) ==1071== by 0x4998A17: dbus_connection_dispatch (dbus-connection.c:4808) ==1071== by 0x18E931: message_dispatch (mainloop.c:76) ==1071== Block was alloc'd at ==1071== at 0x48458A4: malloc (vg_replace_malloc.c:299) ==1071== by 0x48C11B3: g_malloc (gmem.c:94) ==1071== by 0x48DA4A3: g_slice_alloc (gslice.c:1025) ==1071== by 0x48DB4AF: g_slist_prepend (gslist.c:254) ==1071== by 0x12C7D7: bss_process_ies (supplicant.c:2176) ==1071== by 0x12C7D7: bss_property (supplicant.c:2388) ==1071== by 0x1301FF: supplicant_dbus_property_foreach (dbus.c:145) ==1071== by 0x1302A1: property_get_all_reply (dbus.c:184) ==1071== by 0x498FABB: complete_pending_call_and_unlock (dbus-connection.c:2340) ==1071== by 0x49981BF: dbus_connection_dispatch (dbus-connection.c:4757) ==1071== by 0x18E931: message_dispatch (mainloop.c:76) ==1071== by 0x48BB8E7: g_main_dispatch (gmain.c:3234) ==1071== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887) ==1071== by 0x48BBC77: g_main_context_iterate.isra.30 (gmain.c:3960) ==1679== Invalid read of size 4 ==1679== at 0x484D358: memmove (vg_replace_strmem.c:1258) ==1679== by 0x49D8307: memmove (string3.h:59) ==1679== by 0x49D8307: copy.isra.3 (dbus-string.c:1219) ==1679== by 0x49D209F: marshal_1_octets_array (dbus-marshal-basic.c:868) ==1679== by 0x49D209F: _dbus_marshal_write_fixed_multi (dbus-marshal-basic.c:1041) ==1679== by 0x49A4A3B: _dbus_type_writer_write_fixed_multi (dbus-marshal-recursive.c:2681) ==1679== by 0x13088D: supplicant_dbus_property_append_fixed_array (dbus.c:611) ==1679== by 0x12E775: supplicant_dbus_dict_append_fixed_array (dbus.h:121) ==1679== by 0x12E775: interface_add_network_params (supplicant.c:5518) ==1679== by 0x1306FB: supplicant_dbus_method_call (dbus.c:515) ==1679== by 0x12AF05: decryption_request_reply (supplicant.c:5713) ==1679== by 0x498FABB: complete_pending_call_and_unlock (dbus-connection.c:2340) ==1679== by 0x49981BF: dbus_connection_dispatch (dbus-connection.c:4757) ==1679== by 0x18E931: message_dispatch (mainloop.c:76) ==1679== by 0x48BB8E7: g_main_dispatch (gmain.c:3234) ==1679== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887) Change-Id: I53652b06891fa8465e9dd425f425210ebc67ee9f Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2018-05-21Don't remove network when G_SUPPLICANT_STATE_DISCONNECTED is receivedsubmit/tizen/20180523.065951accepted/tizen/unified/20180523.144422Saurav Babu1-24/+0
In case of WPS PBC connection without SSID, sometimes few attempts fail and on subsequent retries connection is established successfully. If we remove network when disconnection is received for the first time from wpa_supplicant then future retries doesn't take place and WPS connection without SSID always fails Change-Id: I2a5754c5e4a442e3305befdea3a94a6c728ef817 Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2018-04-20Add BSSID , signal strength and frequency list of the APssubmit/tizen/20180424.084858accepted/tizen/unified/20180425.062309Mayank Haarit1-0/+5
This patch sends the list of BSSID, signal strength and frequency of an APs having same SSID and Security type. Change-Id: I368d37de310687ca173418dfad91fae7082b2357 Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
2018-04-20Added logic to get country code of APsMayank Haarit1-0/+6
It also includes parsing country code from IEs received from the supplicant Change-Id: Iea5f8b2ea7cc8fefe07591cc4d636d27b015d427 Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
2018-04-10Add SSID and Frequency mixed scan.Niraj Kumar Goit1-2/+47
Change-Id: I6ca91a5f073c11712a936844589aa72c27c0145e Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2018-03-23Fix a coverity for logically dead codesubmit/tizen/20180329.102914accepted/tizen/unified/20180403.060112hyunuktak1-5/+0
Change-Id: I649ed8bbf277611324934db7895d7a8c0cb25ec8 Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
2018-02-26[connman]Added support of EAP-FAST,EAP-PWD and EAP-AKA'.submit/tizen/20180226.110934accepted/tizen/unified/20180227.062953Niraj Kumar Goit1-2/+27
Change-Id: Ibb75ff2c2e54c8d3d53f3b184502647918bf7e24 igned-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2018-02-21Added new dbus method to support bssid based connectionJaehyun Kim1-2/+13
Change-Id: I95d2a56c1d26db06cbdb5c85dc0e2b33b3c10da3 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2018-01-23Modified logic to process each VSIE of all vendors.Niraj Kumar Goit1-8/+6
Modified logic to process each VSIE of all vendors instead of only samsung vendor(OUI: 001632). Received VSIE will be appended in the list and shared with application. Change-Id: Ifbb0159f40a8949a6f117416e5d436d5c2299b49
2018-01-23Updated connman to version 1.35Seonah Moon11-1818/+1964
Change-Id: I13526fbf80296a79be15548fc226a308941ac9ec Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
2018-01-08Imported Upstream version 1.35upstream/1.35Seonah Moon10-1704/+1984
Change-Id: I174854914d9fd06a813270b57d1f7bc2bac63c6a Signed-off-by: Seonah Moon <seonah1.moon@samsung.com>
2018-01-04Modified logic to process each VSIE of all vendors.Niraj Kumar Goit1-8/+6
Modified logic to process each VSIE of all vendors instead of only samsung vendor(OUI: 001632). Received VSIE will be appended in the list and shared with application. Change-Id: I11fee186c04677fdcd7746fcef7fd1dee4a0b02e Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2017-12-28Make WiFi passphrase enc/dec routine async to prevent mutual synchronous ↵submit/tizen/20171229.034008accepted/tizen/unified/20171229.070248Jaehyun Kim1-67/+98
call to net-config Change-Id: Ic7795b430e92b7ee81d4c65b39ef1aa914fccc1a Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2017-12-27connman: Get HS20 property of service correctlysubmit/tizen/20171228.074717submit/tizen/20171228.053515accepted/tizen/unified/20171229.070200Saurav Babu1-2/+3
Change-Id: I21d3a4ba5632d5a00a3254137b12dfdbd1dbe3dc Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2017-12-12Add WiFi passphrase encryption routinesubmit/tizen/20171212.235218accepted/tizen/unified/20171213.153208Jaehyun Kim1-1/+119
Change-Id: Ife8902c48b338cec4a91429441e8435a6b21bc7e Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2017-11-03Added handling of "AssocStatusCode" signalManeesh Jain1-1/+22
Description : This can be used by application in case AP is denying association with status code Change-Id: I195492be4320032b460b708034f044eec03b71dd Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2017-11-02Fix SVACE issue @SVACE ID WGID: 30779 & 30802Maneesh Jain1-1/+19
Change-Id: I183d2e9958bc0278f2d0eff12efbcab07a2148d1 Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2017-10-11[WGID-302103] Fix dereference without null checksubmit/tizen/20171012.045027accepted/tizen/unified/20171013.190316Jaehyun Kim1-2/+2
Change-Id: I0f054b8f4cba4396b6d4018a4bb41504131a1c51 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2017-09-28wifi: Don't increase device ref count on full scan after specific scanSaurav Babu1-16/+24
Earlier full scan was done using throw_wifi_scan() which increases device reference count. As we need to perform full scan then we should directly call g_supplicant_interface_scan() without increasing the device ref count. Change-Id: Icb595ca714d5bf03ed0a071fcd987f9bc1b736dc Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2017-09-28Revert "wifi: Fixed issue with device reference count"taesub kim1-4/+0
This reverts commit 1141e83b5a00d11bada4e07e8203770b3d36939b. Change-Id: I0abf48d5c45cdf16f33345fb7432ceaab4051a11
2017-09-22wifi: Fixed issue with device reference countsubmit/tizen/20170926.020531submit/tizen/20170922.065607accepted/tizen/unified/20170927.063111Saurav Babu1-0/+4
Device reference count is referenced when scanning is set to true, so it should be dereferenced only when scanning is set to false, In one particular case scanning was not being set to false while device was unreferenced when wifi->allow_full_scan is true. Change-Id: Ib8fc675d224eddc8e1dfa4a4a271f7c5b64209fe Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2017-08-18[connman] Enabled specific scan for Multiple APs.submit/tizen/20170822.002714submit/tizen/20170821.070104Niraj Kumar Goit1-10/+22
Change-Id: I2156778ed0bcc703e8823c7eccaf344ab21503c1 Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2017-08-16[connman]Added DBus method for wifi Specific AP Scan.submit/tizen/20170817.042132accepted/tizen/unified/20170818.000126Niraj Kumar Goit1-0/+122
Change-Id: Ib8f446164242caeb7fbc29c2917eff4b8a5b8bf7 Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2017-08-09[connman] Added support to get WiFi vendor element.submit/tizen/20170811.041528accepted/tizen/unified/20170811.133331Niraj Kumar Goit1-0/+13
Change-Id: I560be68a876a5fef516647365db3c56761f2aba1 Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2017-07-20Migrate root daemon to non rootsubmit/tizen/20170724.063335taesub kim1-0/+4
Change-Id: I0d0afacc8a11fadc8128f6eef3f64f7a4ca8675b Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
2017-07-07[Improvement]:Pass the same received RSSI from supplicant to Application.Maneesh Jain1-1/+3
Description: Earlier, connMan was modified the RSSI value received from supplicant using following formula. if (strength > 100) strength = 100; Change-Id: Ifa4fb2be6f65224046274835c9ae26a81fae2e69 Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2017-03-14Apply DNS configuration methodsubmit/tizen/20170322.011410accepted/tizen/wearable/20170322.235735accepted/tizen/unified/20170322.235830accepted/tizen/tv/20170322.235708accepted/tizen/mobile/20170322.235633accepted/tizen/ivi/20170322.235801accepted/tizen/common/20170322.153711Seonah Moon1-1/+20
Change-Id: If16e739fde7e9d736c66015ab1efa982e49d3482 Signed-off-by: Seonah Moon <seonah1.moon@samsung.com>
2017-02-16[tizen 4.0]: Add support of Disconnect Reason Event HandlerManeesh Jain1-5/+13
Description: Merged the following upstream patch and modified the connMan accordingly. http://git.kernel.org/cgit/network/connman/connman.git/commit/?id=6245582d0dc9a3f47a6880dabf437ee7c351caef Change-Id: Id90b6d83849c62c2842c038aec516354a2b74060 Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2017-02-07Merge "[connman]: Fixed: ConnMan keep trying connection infintely" into tizentaesub kim1-5/+24
2017-01-12Fix for single channel scan in SelectNetworktaesub kim1-0/+3
Change-Id: I165fd22bab5ced4a383b0034da79a87712110636 Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
2017-01-08[connman]: Fixed: ConnMan keep trying connection infintelyManeesh Jain1-5/+24
Description : In following use case, ConnMan was stuck in auto-connection with a specific AP. In that time, user could not be able to select any other AP for connection. 1. Connect with an AP 2. Add the Device Mac address in AP's Mac filter list 3. Device disconnect from AP 4. Device keep trying to connection with AP Partially added following upstream patch. "http://git.kernel.org/cgit/network/connman/connman.git/commit/?id=3bda07204b11158dd18322db6e64dc92bdd07124" Change-Id: I1731bfd21324c83a87f4ff2a5fccf264fd7883f5 Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2016-12-21[connman]: @fix WGID 166257 SVACE Issuesubmit/tizen/20161222.015926accepted/tizen/wearable/20161223.095006accepted/tizen/tv/20161223.094951accepted/tizen/mobile/20161223.094936accepted/tizen/ivi/20161223.095029accepted/tizen/common/20161222.131130Maneesh Jain1-1/+1
Change-Id: Ib9186009728b786bc1c5c848a529e67af4752a1e Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2016-12-20Merge "[connman]:Fixed Double Scan Indication Event" into tizencheoleun moon1-4/+9
2016-12-19Clear scanning flag & device when state is connectedtaesub kim1-0/+8
http://slp-info.sec.samsung.net/gerrit/#/c/2752007/ http://slp-info.sec.samsung.net/gerrit/#/c/2763075/ Change-Id: Ia290ba7d4d50935c1473d8a864a508dbad3f5e90 Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
2016-12-15[connman]:Fixed Double Scan Indication EventManeesh Jain1-4/+9
Description: In specific case, CommMan issue the SSID based scan followed by full channel scan. In that case, applicaiton receive the two scan done event. To handle this , block the scan done event for SSID based scan. Change-Id: I24803bd7377e3c682a33b0be653c36c65d30186e Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2016-11-17Remove Tizen specific hidden connection logicSaurav Babu1-0/+5
Change-Id: I0f485580bd16234fe371e0cfb153d9f1cc23dbcc Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2016-10-05Merge "[connman]: Fixed Scan Issue" into tizensubmit/tizen_3.0_wearable/20161015.000001submit/tizen_3.0_tv/20161015.000001submit/tizen_3.0_mobile/20161015.000001submit/tizen_3.0_ivi/20161010.000001submit/tizen/20161006.010203accepted/tizen/wearable/20161006.080157accepted/tizen/tv/20161006.080141accepted/tizen/mobile/20161006.080107accepted/tizen/ivi/20161006.080215accepted/tizen/common/20161006.153612accepted/tizen/3.0/wearable/20161015.082011accepted/tizen/3.0/tv/20161016.004154accepted/tizen/3.0/mobile/20161015.032812accepted/tizen/3.0/ivi/20161011.043852cheoleun moon1-0/+14
2016-09-29[connman]: Fixed Scan IssueManeesh Jain1-0/+14
Description: In following use case, ConnMan always perform the ssid based scan and unable to find the new AP's. a. Connect with any AP (Normal or Hidden) b. Disconnect with AP c. After this, ConnMan always perform the SSID based scan. Impact: Tizen Device is unable to scan new AP's. Reason: In Tizen, ConnMan configure the "BackgroundScanning" flag as false because background scan feature is implemented in net-config module. Due to this reason, I have added patch to sync-up the ConnMan scan implementation with net-config background scan feature. Change-Id: I0cff11df18780816b5f61a647c2298c781e78557 Signed-off-by: Maneesh Jain <maneesh.jain@samsung.com>
2016-09-28Revert "Remove Tizen specific hidden connection logic"submit/tizen/20160929.042234accepted/tizen/wearable/20160929.081746accepted/tizen/tv/20160929.081805accepted/tizen/mobile/20160929.081738accepted/tizen/ivi/20160929.081755accepted/tizen/common/20160929.163218taesub kim1-5/+0
This reverts commit 7ace8c778781a6d3e47010843d9bc5c0d337594d. Change-Id: Ia05ae51984781af64d3225ac302bdfb24df37263
2016-09-26Remove Tizen specific hidden connection logicsubmit/tizen/20160928.053415accepted/tizen/wearable/20160929.081029accepted/tizen/tv/20160929.081156accepted/tizen/mobile/20160929.081112accepted/tizen/ivi/20160929.081222accepted/tizen/common/20160928.164122Saurav Babu1-0/+5
Change-Id: I466d0a4d73ade1278211245fbc94ca2fffeb392f Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
2016-07-06Call g_supplicant_interface_scan with scan_paramshyunuktak1-11/+1
when latest connection is specific ssid as hidden Change-Id: Id5a58977ac3dcb05f3006dbed85d3e07aab15326 Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
2016-07-05Fixed some issuessubmit/tizen/20160705.082658accepted/tizen/wearable/20160705.101859accepted/tizen/tv/20160705.101845accepted/tizen/mobile/20160705.101933accepted/tizen/ivi/20160705.101849accepted/tizen/common/20160705.170548hyunuktak1-5/+0
Removed to set autoconnect when 4way handshake failed Release passphrase of service when indicate error occurred for invalid key Change-Id: Id748ddcd21ad896f0d8e91ce4711a4c9c0df6d96 Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
2016-06-28Modify to get rsn mode using pairwisesubmit/tizen/20160628.112647accepted/tizen/wearable/20160629.021326accepted/tizen/tv/20160629.021220accepted/tizen/mobile/20160629.021329accepted/tizen/ivi/20160629.021304accepted/tizen/common/20160628.141818hyunuktak1-2/+2
Change-Id: Icb3942835130528c4d61d427ee1891d88cc1ac3b Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
2016-06-22Remove some features and modify service filesubmit/tizen/20160624.012559accepted/tizen/wearable/20160624.064357accepted/tizen/tv/20160624.064037accepted/tizen/mobile/20160624.064052accepted/tizen/ivi/20160624.064339accepted/tizen/common/20160624.132425hyunuktak1-31/+0
Change-Id: Id3697d995e4db5d6f03cdf182825d5f61136e235 Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
2016-06-17[SPIN] Indicate auth-failed error.Niraj Kumar Goit1-1/+1
desc: In case of wifi connection if Association fail, indicate "auth-failed" error. Change-Id: Ie08088f3e5b5ff940d0e4290814c266d28e59b15 Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>