Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
Change-Id: I84a42375b5c59739e4caca1f726699ea7647ef17
|
|
Change-Id: Ia09c875954d8a20a3e6c39f87076780d8a6582e4
|
|
|
|
|
|
OPTION_DOMAIN_LIST(24) was not sent to server.
|
|
Clean up several places where dhcp_client->type == G_DHCP_IPV4LL is unhandled.
|
|
See RFC 3315 Chapter 18.1.2. Creation and Transmission of Confirm
Messages for details
|
|
The message status code was initialized too late i.e., after
it was set so we lost the status code. This problem was seen
with wide-dhcpv6 server.
|
|
A mandatory elapsed time option was missing from the sent
DHCPv6 messages. See RFC 3315 chapter 22.9 for details.
|
|
If the desired option was last one in the message, then it was
lost because the remaining data calculation was wrong.
|
|
As requested in RFC 3315 chapter 15.1, a client MUST leave
the transaction id unchanged in retransmissions of a message.
|
|
|
|
Print transaction id of sent and received messages so that it is
easier to match the packets.
|
|
This change affects unicasted DHCP renew and release messages.
A DHCP server receiving packets via a raw socket will get all
packets destined to port 67. If the DHCP server checks the
intended server IP address, the request will fail. If the server
does not care about the IP address being used, it will send a
reply. The reply is not recognized by ConnMan since it is coming
from another IP address than what it was sent to. ConnMan will
retry quite a few times, but eventually settle down and use the
address even without a proper response from the server.
|
|
Use for all memory allocation/dealocation operation the glib
functions. This allows us to use g_mem_profile().
|
|
|
|
The socket was not closed when the sendto failed.
|
|
|
|
Instead of using dhcp_add_simple_option() the gdhcp now uses
three functions for setting uint8, uint16 and uint32 values.
|
|
Convert to network byte order just before sending the packet.
|
|
The alignment macros are copied from Bluez.
|
|
|
|
With the previous behavior, we would end up sending a discover message
and then ignoring the reply due to the client state mismatch, so a
restart would never result in successful acquisition of a lease.
RFC 2131 specifies that the client should return to INIT state in
various restart scenarios. However, also note that it would not make
sense in any case to send a discover message and ignore the reply.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fix packet length checking where payload length could have been zero.
Also check that we don't set the option pointer beyond the end of the
packet payload.
|
|
|
|
The previous way was giving the following warning with gcc 4.7:
CC gdhcp/common.o
gdhcp/common.c: In function 'dhcp_add_simple_option':
gdhcp/common.c:275:38: error: dereferencing type-punned pointer will
break strict-aliasing rules [-Werror=strict-aliasing
Change it slightly so not to give this warning.
|
|
Pass NULL rather than 0 when calling time(2) to follow prefered
stylistic convention.
|
|
This patch sets the BOOTP secs field in a RFC 951- and 2131-compliant
manner for DHCPv4 DISCOVER and REQUEST/SELECT packets.
Certain DHCP servers, such as that implemented in Mac OS X (< 10.7)
for its "Internet Sharing" feature, refuse to issue a DHCP lease to
clients that have not set a non-zero value in their DISCOVER or
REQUEST packets. In fact, based on http://hints.macworld.com/article.php?
story=20071223001432304, it's not non-zero but a value greater than four (4)
seconds to allow another "authoritative" DHCP server on the subnet to reply
first.
Side-by-side packet analysis of Mac OS X, iOS, Android, ISC and
Windows clients show that these clients set the BOOTP 'secs' field and
are successfully issued a DHCP lease by Mac OS X. By contrast, a
connman-based client will issue 10 back-to-back DISCOVER packets and
will not be returned a DHCP OFFER from the server.
|
|
This patch adds a function to add a RFC 1533- and 2132-compliant DHCP
client-id option (61) to sent DHCPv4 packets.
|
|
Support specifying NULL-terminated string or raw data for allocated
DHCP options.
|
|
<inet.h> doesn't exist.
|
|
|
|
|
|
|
|
|
|
|
|
This patch contains solicitation message support.
|
|
See relevant parts from these RFCs:
RFC 3315 - DHCP for IPv6
RFC 3646 - DNS configuration options for DHCP for IPv6
RFC 3736 - Stateless DHCP service for IPv6
RFC 4075 - SNTP configuration option for DHCPv6
The patch does not support authenticated information messages.
|
|
The patch adds support for information-request DHCPv6 message.
|
|
Fixed following error:
connmand[4547]: src/dhcp.c:dhcp_release() dhcp 0x8c6d3e8
connmand[4547]: DHCP: switch listening mode (3 ==> 0)
(connmand:4547): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed
|
|
g_atomic_int_exchange_and_add() has been removed from glib 2.30
and g_atomic_int_add() should be used. Though there are still
quite a few distros out which do not ship a glib version with
g_atomic_int_add().
Instead of maintaing a compatiblilty glib layer we just use
the built-in functions for atomic memory access.
|
|
|
|
Make sure all file descriptor are closed.
|
|
This fix will cause the DHCP_REQUESTED_IP option to be sent to
the server.
Fixes BMC #21068
|