Age | Commit message (Collapse) | Author | Files | Lines |
|
Added NULL check before derefrencing of pointer variable.
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Change-Id: If065f024fe62e72887591f54eaabf4ed70a8d2e2
|
|
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
Change-Id: I84a42375b5c59739e4caca1f726699ea7647ef17
|
|
|
|
|
|
An empty passphrase means that WPS is to be tried next. If WPS is not
supported by the service, passphrase can not be left empty.
|
|
Instead of having a global agent_input struct, make the structure a
member of the agent_data structure that gets passed around when
handling the RequestInput method call.
With this modification agent_data is self-contained with all needed
information and the RequestInput handling code can be shared between
ConnMan and VPN agent implementations.
|
|
|
|
ConnMan and ConnMan VPN daemon both send only one Agent message at
a time. Since they are two different daemons, they can be sending
messages at the same time independent of each other.
Implement a check for an agent request from the other daemon being
already processed and if so store the message for later. When the
current agent request has been processed, check if there are
pending requests from the other daemon and re-run the pending
function.
In order to support arbitrary queueing, make all method call
implementations asynchronous.
|
|
Create a new agent data structure for the VPN Agent and add the needed
minor modifications to Release, Cancel and ReportError method calls in
order to get them working both for Agent and VPN Agent.
Create new register and unregister functions for the VPN Agent code.
|
|
Collect the agent variables into a data structure and update the agent
functionality to pass this data structure around as function callback
user data.
Update the agent mode input functionality to store both the callback
function and user data pointers. Notice that only only one input
callback can be handled at any one time due to the input handling itself
and the simple storing of callback and user data pointers.
|
|
Agent messages need to be handled in the agent code, ignore them when
they get captured in the monitor code.
|
|
The previous pretty-printing fix causes another change to be
made for DBUS_TYPE_UINT16.
|
|
|
|
A basic type was always read independent of the argument type which
on some systems lead to a crash and on others only to a warning
printout.
|
|
To keep it more logical, rename the unsigned variable in the code.
|
|
When adding VPN monitoring capabilities, also clean up the monitor code.
|
|
Show a list of VPN connections known to the VPN daemon.
Also allow D-Bus path names to start with numbers, as it is fine with
the D-Bus library to define such path names. Fix up help command
pretty-printing as the VPN command is slightly longer.
|
|
Add helper function for printing VPN connections. Show also configuration
and failure states using 'C' and 'F' as configuration might take some
time and failure conveys practical information to the user.
|
|
|
|
|
|
Accept also correctly spelled version of 'preferred' option.
|
|
|
|
|
|
|
|
|
|
Cosmetic fix.
|
|
D-Bus aborts if we feed invalid characters to it. So do some sanity
check before that.
|
|
|
|
If there is no callback set, don't try to call readline function.
|
|
Properly handle agent confirmation input, unset the prompt when RequestInput
processing ends and set the passphrase only if it contains some text.
|
|
When receiving a RequestInput Agent API D-Bus call, ask the input in a somewhat
logical order from the user with user names first and passwords next. If a
passphrase is entered, ignore any WPS pin code requests. Prepare for passphrase
length checking by going through the RequestInput message to get the 'Type'
argument.
|
|
Report error and wait for the user to reply with yes/no.
|
|
Print out the RequestBrowser URL and wait for user input to proced. Add a
helper function for getting a yes/no confirmation from the user and another
one for getting the last part of the service object path.
|
|
Unref the saved Agent D-Bus message on Release and Cancel. In response to the
Release method call unnregister Agent interface and quit if in non-interactive
mode.
|
|
In command mode remember history and do command completion, in agent mode
do neither. Enable saving and restoring of the readline prompt and add
the GIOChannel watch also for non-interactive mode.
|
|
|
|
Add agent .h and .c files containing registering and unregistering functionality.
|
|
Enable a client method call return function to exit or continue running when
in non-interactive mode. When a connmanctl_dbus_method_return_func_t returns
-EINPROGRESS in non-interactive mode, the command line client is kept running
even after the method call has been processed.
The command line client needs to keep running after a successful Agent
registration in order to process Agent method calls. Also enabling tethering
in non-interactive mode needs the client executing until SSID, passphrase and
tethering mode have been set.
|
|
|
|
|
|
Remove now obsolete memebers from the option struct and instead add a description
field. Also remove the now unnecessary include.
|
|
|
|
After splitting the input string into components, create a new array holding
the non-zero substrings as input for the commands. Thus the input can start
and end as well as divide its separate parts by any number spaces.
|
|
Add completion support for connmanctl commands.
|
|
Follow coding style and use __connmanctl prefix for the commands() function.
|
|
Add tethering support. For WiFi also set the SSID and passphrase if they
have been specified on the command line. Check that setting both SSID and
passphrase succeed before trying to enable tethering.
After successfully setting SSID and passphrase for WiFi, use the boolean
value parsing helper function return value to decide whether WiFi tethering
is to be enabled, disabled or not modified.
Fixes BMC#25886
|
|
|
|
|
|
The helper function is not used elsewhere, thus move it.
|
|
Remove now obsolete files from services. Remove data_manager, dbus and
technology .h and .c files. Update Makefile.am accordingly.
|