summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
11 daysFix NULL pointer dereferenceHEADtizenNishant Chaprana1-0/+3
Core was generated by `/usr/bin/connmand -n --nobacktrace --noplugin vpn'. Program terminated with signal SIGSEGV, Segmentation fault. >0 connman_device_get_last_connected_ident (device=0x0) at src/device.c:842 842 return device->last_connected_ident; (gdb) bt >0 connman_device_get_last_connected_ident (device=0x0) at src/device.c:842 >1 0x0098ec70 in calculate_score_last_connected (service=0x1ef9eb8) at src/service.c:7900 >2 calculate_score (service=0x1ef9eb8) at src/service.c:7994 >3 calculate_score (service=0x1ef9eb8) at src/service.c:7977 >4 0x0098eed8 in service_compare (a=0x1ef9eb8, b=0x1f010a0) at src/service.c:8138 Change-Id: I7e412f68f71472e28669941b9346ba73281ccd39 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
11 daysUse dbus_free for deallocation, when allocated with dbus_malloc0Nishant Chaprana1-1/+1
Change-Id: I003118f70353bf949f050a6e863c9152be8b6e8e Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2021-02-24Merge "Error checking in passphrase decryption method." into tizensubmit/tizen/20210224.083420accepted/tizen/unified/20210225.130544accepted/tizen_unifiedJaehyun Kim2-1/+9
2021-02-24Merge "Fix svace 'UNREACHABLE_CODE.NO_PATH' warnings" into tizenJaehyun Kim2-2/+4
2021-02-10Fix svace 'UNREACHABLE_CODE.NO_PATH' warningsNishant Chaprana2-2/+4
Change-Id: Ibefe7a09903f2d05e7aa12e9262f820d4e7feb71 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2021-02-03Change systemd-devel package namesubmit/tizen/20210217.025918accepted/tizen/unified/20210217.120449INSUN PYO2-3/+3
Change-Id: I0c553dd40bda63b08846e66bbcdd9955d882ef41
2021-01-27Error checking in passphrase decryption method.Niraj Kumar Goit2-1/+9
If Dbus fails to append argument in dbus-message, do not call a dbus method to decrypt passphrase. Change-Id: Ic3b63ea9e6827ca1bf3753d750026119ec1bfd1a Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2021-01-27merge tag upstream/1.38submit/tizen/20210127.105449accepted/tizen/unified/20210129.002142Seonah Moon0-0/+0
Change-Id: Ic98cd483e7e21143bb1102a781643c06ce9f628d
2021-01-25On device reboot enable wpa-supplicant for EAPoL.submit/tizen/20210126.062930Niraj Kumar Goit4-36/+155
In case of device reboot enable wpa-supplicant for eapol connection if last connection was EAP over ethernet. Change-Id: Ia264accac74ecffdba6c2b116807e45f675ef3db Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2021-01-25Added Dbus method 'IsEapolEnabled'.Niraj Kumar Goit2-1/+24
This patch fixes EAPoL enabled status on device reboot scenario. Change-Id: Ib9fcbed659996eae42c6a30e7ee5f584aeaa19d2 Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2021-01-25Merge "Imported Upstream connman version 1.38" into tizenJaehyun Kim140-2127/+8086
2021-01-19Added timer delay to get the responsesubmit/tizen/20210119.130611accepted/tizen/unified/20210122.123012Prasadam Prashath Kumar1-0/+47
In Tizen6.5 to avoid continious loop in udp_listner_event added timer delay, so connman can receive response from telephony deamon and wpa_supplicant Change-Id: I88a74d6d4fe3f91be27b24949f8fc14edd3f7143 Signed-off-by: Prasadam Prashath Kumar <prasadam.p@samsung.com>
2021-01-04Imported Upstream connman version 1.38Niraj Kumar Goit140-2127/+8086
Change-Id: I9e650762f3b2b2a31945b66e044e67a77e3b4b12 Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2020-12-02Fix derefrencing of NULL pointersubmit/tizen/20201229.102954submit/tizen/20201217.131910Jaehyun Kim1-2/+5
Return value of a function '__connman_service_get_network' is dereferenced without checking. Change-Id: Ib66474b2fc6924d50eb8b35206251938ba63baad Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-11-11Merge "Fix derefrencing of NULL pointer" into tizensubmit/tizen/20201127.052752submit/tizen/20201116.030352Jaehyun Kim2-1/+4
2020-11-11Fix derefrencing of NULL pointerJaehyun Kim2-1/+4
In some cases network->device could be NULL which leads to crash Change-Id: I3cc5401b37fd48d8d702935bef7afa7e277222f2 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-11-09Rename EAPoL configuration file path to /var/lib/connmanNiraj Kumar Goit1-1/+1
Change-Id: I5a14fb736b0b3b842eaedfce53303c6a6d143aa9 Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2020-11-02Emit StateChangedProperties post emitting service state's PropertyChangedsubmit/tizen/20201106.060323Nishant Chaprana2-4/+36
wifi-manager and libnet-client can use this signal instead of [PropertyChanged(state) signal + GetProperties call] combination for updating service information. Change-Id: I0203cb7df202ff3767a2c4d25e8ca685e4eb8ba8 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2020-10-27Merge "[gdhcp/client] Reopen socket GIO channel when failed" into tizensubmit/tizen/20201028.023046accepted/tizen/unified/20201029.124906Jaehyun Kim2-1/+9
2020-10-27Merge "[src/rtnl] Add retry mechanism when socket GIO channel fails" into tizenJaehyun Kim4-1/+46
2020-10-16Fix an issue where the log option is not applied properlyJaehyun Kim5-11/+45
Change-Id: Ibb5305175a1987d74f0a24ba413a664940233e76 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-10-15Fix auto connection failureJaehyun Kim1-0/+7
If there is more than one connection history, auto-connection is failing. This problem occurs because two APs try to connect to the same interface at the same time. So fixed to prevent duplicate connection attempts on the same interface. Change-Id: If5da80db089c9607579f943d023565c999a5576b Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-10-14Imported Upstream version 1.38upstream/1.38upstreamNishant Chaprana139-2168/+8056
Change-Id: I7cada2367329445e1d200055e21d96e7e9c05047 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2020-10-12[gdhcp/client] Reopen socket GIO channel when failedNishant Chaprana2-1/+9
Change-Id: Ib63b6f194e67fc4d7cfc3f223afa064761dff578 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2020-10-12[src/rtnl] Add retry mechanism when socket GIO channel failsNishant Chaprana4-1/+46
Change-Id: I21f1d8c970f1053ce4337dc0d251d2fa20bbd509 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2020-10-07Fix an issue where the log option is applied incorrectlytizen_6.0.m2_releasesubmit/tizen_6.0_hotfix/20201103.115101submit/tizen_6.0_hotfix/20201102.192901submit/tizen_6.0/20201029.205501submit/tizen/20201007.120259accepted/tizen/unified/20201008.043010accepted/tizen/6.0/unified/hotfix/20201102.235749accepted/tizen/6.0/unified/20201030.105121Jaehyun Kim1-2/+2
Change-Id: I57db81c2670b769bbedafb3e3d9db02218516bca Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-10-07Merge "Add support for dlog" into tizenJaehyun Kim17-55/+251
2020-10-07Add support for dlogJaehyun Kim17-55/+251
1. Add support for dlog 2. Add some log options to main.conf 3. Allow to simplify the amount of logs by option Change-Id: I8c1202ae267aca9bb2c18d44c2ccd3e6d5a74a73 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-10-07[Fix][src/service] Add 'fall through' comment when break statement is not neededNishant Chaprana2-2/+2
Change-Id: Iff3cac79bc3f3ede61f90ab688cfbebcbc374221 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2020-10-07[Fix][plugin/ethernet] SVACE warning DEREF_AFTER_NULLNishant Chaprana2-2/+5
Change-Id: Ie3a9044de3be7ce46d05052920f9d5b5d99cd15f Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2020-09-25Fix incorrect dbus usage that caused crashsubmit/tizen/20201005.112026submit/tizen/20200925.132900accepted/tizen/unified/20201006.044352Jaehyun Kim1-1/+2
Change-Id: Ifd11a65d3182533d210401fbce4c5fb9b6504b0d Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-09-16The order between the device signal and the service signal has been changedsubmit/tizen/20200918.062939submit/tizen/20200917.115639accepted/tizen/unified/20200921.095121Jaehyun Kim1-8/+8
Net-config is implemented assuming that the DeviceChanged signal comes before the service PropertyChanged signal. Therefore, the event order has been adjusted accordingly. Change-Id: I134ec7152a0e40bbfe317c704a91ca81fc01dc1c Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-09-11Fix build warningsJaehyun Kim3-3/+3
Change-Id: I43c65427f5b6e0eb003ac3c17c012cd9b7db0f76 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-09-10Remove DefaultDependencies=false at connman.serviceJaehyun Kim1-1/+0
connman.service has "After=net-config.service" dependency. But net-config.service don't have DefaultDependencies=no. So "DefaultDependencies=false" does not have any effect on connman.service, but instead it is confusing. Change-Id: I52dff5dc4a33deceed87b47ff1aaa05b2f049f8e Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-09-01Fix derefrencing of NULL pointersubmit/tizen/20200903.044940submit/tizen/20200902.111409submit/tizen/20200901.053326accepted/tizen/unified/20200903.151723Jaehyun Kim1-1/+3
In some cases wifi->network is NULL which leads to crash Change-Id: Ie02bb6a84f25d816935b492169feed2aca7f76b8 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-09-01Move GetInterfaces method to Manager interfaceJaehyun Kim4-42/+63
Change-Id: I4e9cd93717a04457f97bf13fc389075a3e5c0e54 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-08-27Add support for handling multiple wifi interfacessubmit/tizen/20200828.142119Jaehyun Kim14-124/+1038
Change-Id: I4762c8d3444167dce34498634de4948e822f865f Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-08-13Svace Fix: memory leakRahul Jain1-3/+19
Change-Id: Id10ede540b99d028f6ff40225b4dfcccb46d7fe0
2020-08-05Use ref counting for network during SignalPoll method call of wpa_supplicant.submit/tizen/20200811.004738accepted/tizen/unified/20200812.144017Nishant Chaprana2-6/+11
Description: This patch fixes the issue in which dangling network pointer is present as user_data of signalpoll_callback. This dangling pointer crashes connman with below backtrace:- >>> bt \#0 connman_device_get_ident (device=0x6e6f632f) at src/device.c:592 \#1 0xb6f54994 in __connman_network_get_ident (network=network@entry=0xb87715b0) at src/network.c:1560 \#2 0xb6f652da in connman_service_lookup_from_network (network=network@entry=0xb87715b0) at src/service.c:10177 \#3 0xb6f655ee in __connman_service_notify_strength_changed (network=network@entry=0xb87715b0) at src/service.c:10523 \#4 0xb6f5527c in connman_network_set_strength (network=network@entry=0xb87715b0, strength=strength@entry=69 'E') at src/network.c:2704 \#5 0xb6f36ac0 in signalpoll_callback (result=<optimized out>, maxspeed=39, strength=69, user_data=0xb87715b0) at plugins/wifi.c:3866 \#6 0xb6f3b68e in interface_signalpoll_result (error=<optimized out>, iter=<optimized out>, user_data=0xb8782af8) at gsupplicant/supplicant.c:6348 \#7 0xb6f4335a in method_call_reply (call=0xb8771ec0, user_data=0xb8782c98) at gsupplicant/dbus.c:476 \#8 0xb6da23a4 in ?? () from /lib/libdbus-1.so.3 \#9 0xb6da5fa0 in dbus_connection_dispatch () from /lib/libdbus-1.so.3 \#10 0xb6f94dce in message_dispatch (data=0xb875fe78) at gdbus/mainloop.c:72 \#11 0xb6e21d84 in g_main_context_dispatch () from /lib/libglib-2.0.so.0 \#12 0xb6e22008 in ?? () from /lib/libglib-2.0.so.0 \#13 0xb6e22268 in g_main_loop_run () from /lib/libglib-2.0.so.0 \#14 0xb6f29d3e in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:1373 Change-Id: Ia171c2ddabf6a4f9c3d6a6bbd3763398b6e0ce46 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
2020-07-23Svace issues: Null check and memory leakssubmit/tizen/20200804.104340submit/tizen/20200730.084504accepted/tizen/unified/20200805.122502Rahul Jain5-1/+24
Change-Id: I937af7e6dbe3a919c1d0b0d7dee4b481c2ef0982
2020-06-24Change the service file path for 64bit buildsubmit/tizen/20200624.065138accepted/tizen/unified/20200626.133553Jaehyun Kim1-33/+2
Change-Id: I4ae421d7428aa3d0a70f1c66fef736b5710739b2 Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-06-10Merge "Add to check ins status on client" into tizensubmit/tizen/20200610.045555hyunuk tak1-4/+59
2020-06-09Add omitted TIZEN_EXTJaehyun Kim1-2/+2
Change-Id: I44227340c3a408711756a2bf4ccfb860ef44170b Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2020-05-27Add to check ins status on clienthyunuk.tak1-4/+59
Change-Id: I3224dc06110f6c0063fa082b713cb2aaa13a3a1f Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
2020-05-25Merge "supported OWE Transition mode" into tizensubmit/tizen/20200528.074637accepted/tizen/unified/20200529.124226Jiung Yu6-8/+186
2020-05-25Merge "Block all extra scans caused by ConnMan" into tizencheoleun moon1-0/+12
2020-05-22supported OWE Transition modeJinwon Kim6-8/+186
Change-Id: I6dd1cb437ac16c0428df4d5bc812fefb36543c6d Signed-off-by: Jinwon Kim <jinwon0325.kim@samsung.com>
2020-05-19Fix wrong length for format stringsubmit/tizen/20200519.021428accepted/tizen/unified/20200519.035055Yu1-1/+1
Change-Id: I11c0eee0076be37b17ec5ffaff92c72975d29d8f Signed-off-by: Yu jiung <jiung.yu@samsung.com>
2020-05-18Merge "Add logic to detect buffer overflow for snprintf" into tizensubmit/tizen/20200518.041610Jiung Yu1-0/+46
2020-05-18Add logic to detect buffer overflow for snprintfYu1-0/+46
Change-Id: I60f835aeed101ef61a2bbb73bf2fc8c2c7327d50 Signed-off-by: Yu jiung <jiung.yu@samsung.com>