summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-11-13iptables: A file descriptor cannot be a nagative integerDanny Jeongseok Seo1-1/+2
When a socket() has failed and a negative file descriptor has been set, close() cannot accept a negative number as a parameter.
2012-11-13manager: Fix negative error codeDanny Jeongseok Seo1-1/+1
Fix error code for __connman_error_failed
2012-11-13wifi: Handle D-Bus method call failurePatrik Flykt1-0/+8
If -ECONNABORTED is received from the gsupplicant network disconnect callback, it's an indication that the interface has already been removed from wpa_supplicant side. This can happen due to a race condition between rtnl and wpa_supplicant interface removal when a USB WiFi dongle is pulled out. The pointers given to the callback can no longer be trusted, don't touch them in the callback. The have been removed by other code at this point.
2012-11-13supplicant: Handle race condition on WiFi dongle removalPatrik Flykt1-4/+21
When a WiFi USB dongle is removed, both rtnl and wpa_supplicant will be telling that the device is gone. While disconnecting and removing an interface via gsupplicant, check that D-Bus doesn't give us an error indicating the interface is already unregistered from D-Bus. The gdb output looks like: (gdb) where #0 0x0042247c in network_connect (network=0x2) at plugins/wifi.c:1197 #1 0x004228f0 in disconnect_callback (result=<value optimized out>, interface=0x0, user_data=0x99) at plugins/wifi.c:1254 #2 0x0042b910 in network_remove_result (error=0x4d5458 "org.freedesktop.DBus.Error.UnknownMethod", iter=<value optimized out>, user_data=<value optimized out>) at gsupplicant/supplicant.c:3593 #3 0x0042ede0 in method_call_reply (call=0x4c6fd0, user_data=0x4d3be8) at gsupplicant/dbus.c:386 #4 0x2abfddb4 in complete_pending_call_and_unlock () from /usr/lib/libdbus-1.so.3 Also don't call the same callback twice.
2012-11-13bridge: Close socket on errorPatrik Flykt1-1/+3
2012-11-13gdhcp: Fix resource leakDanny Jeongseok Seo1-1/+1
The socket was not closed when the sendto failed.
2012-11-13gweb: Check null before referenceDanny Jeongseok Seo1-2/+2
2012-11-13inet: Fix resource leakDanny Jeongseok Seo1-3/+1
The socket was not closed when err < 0 is true.
2012-11-07wifi: Skip service if there is error while loading its settingsJukka Rissanen1-0/+4
If service settings cannot be loaded, then skip that service. Thanks for Felipe Tonello for reporting the issue.
2012-11-05README: Add information about network interface clearing at startupJukka Rissanen1-0/+5
2012-11-05session: Register session after policy plugin returned configDaniel Wagner1-75/+89
Move the configuration part of __connman_session_create() into session_create_cb(). With this change the policy plugin is able to do async work to retrieve a configuration.
2012-11-05session: Factor out user settings in __connman_session_create()Daniel Wagner1-23/+48
In order to be able to pass the user configuration provided through from the D-Bus Manager.SessionCreate() call to the callback we need to store the configuration into a local data data structure. This data structure can then be passed into the callback introduced later on.
2012-11-05session: Remove struct connman_session_bearerDaniel Wagner3-111/+35
Instead start using enum connman_service_type directly.
2012-11-05session: Handle no match case in parse_bearers()Daniel Wagner1-0/+9
2012-11-05session: parse_bearers() should check for invalid typesDaniel Wagner1-2/+9
2012-11-05session: Rename session_parse_allowed_bearers() to parse_bearers()Daniel Wagner1-5/+3
This function name was a source of confusion because in a later patch we introduce connman_session_parse_allowed_bearers() which will call parse_bearers(). With this change it should be more readable.
2012-11-05session: Remove match_all from connman_session_bearerDaniel Wagner2-36/+21
The match_all will be expressed through CONNMAN_SESSION_TYPE_UNKNOWN. The 'no match' case happens when allowed_bearers is NULL.
2012-11-05session: Remove name variable from connman_session_bearerDaniel Wagner2-8/+8
The string is only used when appending the bearer to the D-Bus message in append_allowed_bearers(). Let's use __connman_session_type2string() in append_allowed_bearers(). This saves a bit of memory.
2012-11-05session: Add callback to policy create()Daniel Wagner3-15/+40
Instead returning directly a config when create() is called in policy plugin, use a callback function for handing over a valid configuration from the plugin to the session core. This prepares support for asynchronous create call.
2012-11-05session: Policy register should check callback existenceDaniel Wagner1-0/+3
Let's ensure that the policy plugin has all necessary callbacks installed when connman_session_policy_register() is called. The rest of the code expects that the create() and destroy() callbacks exist whenever a plugin is used.
2012-11-05session: Pick directly first policy in listDaniel Wagner1-8/+3
There is no point in iterating over the list when we always pick the first element in the list.
2012-11-05session: Factor out memory release part of cleanup_sessionDaniel Wagner1-9/+14
We want to reuse this code snippet for the error case in __connman_session_create() too.
2012-11-05manager: Allow async CreateSession method callDaniel Wagner1-2/+6
The CreateSession D-Bus call should be marked as async call in order to allow the session core to defer the response.
2012-11-05storage: Add void if function does not have any argumentsDaniel Wagner2-7/+7
2012-11-02dhcp: Clear ipaddresses from ipconfig before starting DHCPJukka Rissanen1-0/+6
This is needed if manually configured addresses were used and later DHCP was taken into use. If the manually configured IP information (address, netmask and gateway) and the information given by DHCP is the same, DHCP will not set the IP address to the interface.
2012-11-02ipconfig: Add function to clear ipaddress informationJukka Rissanen2-0/+9
2012-10-29openvpn: Support '--tls-auth <file>' with optional '<direction>' argumentEmil Renner Berthing1-0/+14
Connman OpenVPN OpenVPN.TLSAuth --tls-auth <file> [<direction>] OpenVPN.TLSAuthDir optional <direction> argument to '--tls-auth' Since 'OpenVPN.TLSAuthDir' contains the optional <direction> argument for 'OpenVPN.TLSAuth', handle them separately. The special handling is identified by setting openvpn command line argument to NULL.
2012-10-29openvpn: Add more optionsEmil Renner Berthing1-0/+3
Connman OpenVPN OpenVPN.NSCertType --ns-cert-type <client|server> OpenVPN.AskPass --askpass <file> OpenVPN.AuthNoCache --auth-nocache
2012-10-26Release 1.91.9Marcel Holtmann2-1/+10
2012-10-26technology: Do not proceed with tethering if technology is not enabledTomasz Bursztyka1-0/+4
Fixes BMC#25846
2012-10-25systemd: prevent duplicate logging messages in journalMarti Raudsepp1-0/+1
By default, both stdout and syslog messages go to the systemd journal, which results in duplicate messages being logged. Thanks to Vinicius Costa Gomes for pointing out this problem.
2012-10-25technology: Do not presume a technology being hardblocked when createdTomasz Bursztyka1-6/+2
This fixes an issue with the TechnologyAdded signal when the first un-hardblock event occurs: - when a technology was created, D-Bus registration was done and hardblock was set to TRUE even if there was no evidence that the technology was rfkill driven - when the technology was updated to be rfkill driven, hardblock was already set to TRUE and thus the technology was not unregistered - when an rfkill event un-hardblocks the technology, the TechnologyAdded signal was not sent since the technology was already registered to D-Bus
2012-10-25dnsproxy: Add reply host part length checkingPatrik Flykt1-5/+17
Check that the first part of the name is not of zero length before attempting to calculate the length of the domain part. Also ensure the domain lenght checking does not run outside of the receive buffer. Also add debug messages for ids and lengths in order to pinpoint any possible problems.
2012-10-23wispr: Free wispr portal context in the relevant placeTomasz Bursztyka1-11/+11
This fixes 2 issues: - calling __connman_service_ipconfig_indicate_state() might lead to restart wispr_portal check, so context should not be freed afterward but beforehand. - freeing the context in wispr_manage_message() should not happen since wispr_manage_message() will return back to wispr_portal_web_result() where we can still use the context. Thanks to Julien Massot <jmassot@aldebaran-robotics.com> who reported the issue and provided logs.
2012-10-22device: Do not mark connecting networks unavailableTomasz Bursztyka1-1/+2
When autoscan fallback code is started, it sets scanning to true which in turn marks all networks unavailable except for the ones that are already connected. When connecting during an ongoing autoscan, the connection attempt stops autoscan and all unavailable networks are removed, also the one to be connected. The fix is to ignore both connected and connecting networks when marking networks unavailable.
2012-10-19network: Fix typo in debug printJukka Rissanen1-1/+1
2012-10-19web: Make debug func print more useful informationJukka Rissanen1-3/+11
The file and function name are printed in debug prints.
2012-10-19gresolv: Remove query from queue before destroying the queryJukka Rissanen1-1/+1
The order of actions is important here.
2012-10-19gresolv: Make sure we will not receive DNS data after closingJukka Rissanen1-1/+3
We must close the channel when freeing the resolver object, otherwise we might still receive data when the resolver has been freed already. Fixes BMC#25757
2012-10-19gresolv: Add more debug printsJukka Rissanen1-5/+31
2012-10-19gresolv: Make debug func print more useful informationJukka Rissanen1-3/+11
The file and function names are printed in debug prints.
2012-10-18service: Prefer user connected services with SingleConnectedTechnologyPatrik Flykt1-0/+20
Don't override user connected services with the ones selected by the preferred technology list when SingleConnectedTechnology is enabled. Do this by checking each connected service sorted in the beginning of the service list for the userconnect flag.
2012-10-18service: Clear user connected flag on disconnectPatrik Flykt1-2/+2
Remember whether the service was connected by the user via D-Bus until the service gets disconnected.
2012-10-18service: Keep only a single connected technology if configuredPatrik Flykt1-0/+33
If SingleConnectedTechnology is enabled in main.conf, disconnect any previously connected services when the new service enters ready state.
2012-10-18main: Add SingleConnectedTechnology main.conf variablePatrik Flykt1-0/+12
2012-10-18main.conf: Add SingleConnectedTechnology descriptionPatrik Flykt1-0/+12
2012-10-18service: Fix default service switching and setting gatewayPatrik Flykt1-2/+3
Calling switch_default_service() didn't change the service order since the services were already sorted that way. Also update the gateway immediately.
2012-10-18main.conf: Update preferred technology descriptionPatrik Flykt1-6/+7
2012-10-18service: A preferred service in state ready is good enoughPatrik Flykt1-5/+1
Simplify the preferred service selection such that a connected service is good enough, especially since a connecting service will also terminate the search for the current preferred one.
2012-10-18service: Don't trigger autoconnect when neither service is preferredPatrik Flykt1-3/+0
Don't trigger a new autoconnect when neither the default nor the new service is preferred. Rely on the fact that normal autoconnect selection mechanism has done the work for us already.