summaryrefslogtreecommitdiff
path: root/gdbus
diff options
context:
space:
mode:
authorMikel Astiz <mikel.astiz@bmw-carit.de>2012-05-22 14:58:18 (GMT)
committerMarcel Holtmann <marcel@holtmann.org>2012-05-22 18:27:19 (GMT)
commitd41b654bd7cf0723c26f38db7aaee34dbe88bc54 (patch)
treea48784e2e7f18d5f87f0e3192996fccf6f173f75 /gdbus
parenta911bed90486601deefb9585ba5f441e3e2ce02c (diff)
downloadconnman-d41b654bd7cf0723c26f38db7aaee34dbe88bc54.zip
connman-d41b654bd7cf0723c26f38db7aaee34dbe88bc54.tar.gz
connman-d41b654bd7cf0723c26f38db7aaee34dbe88bc54.tar.bz2
gdbus: Fix incorrectly discarded signals
Signals with no arguments were incorrectly filtered out due to the NULL inequality check.
Diffstat (limited to 'gdbus')
-rw-r--r--gdbus/object.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/gdbus/object.c b/gdbus/object.c
index 2dd7c0e..900e7ab 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -612,16 +612,12 @@ static gboolean check_signal(DBusConnection *conn, const char *path,
for (signal = iface->signals; signal && signal->name; signal++) {
if (!strcmp(signal->name, name)) {
*args = signal->args;
- break;
+ return TRUE;
}
}
- if (*args == NULL) {
- error("No signal named %s on interface %s", name, interface);
- return FALSE;
- }
-
- return TRUE;
+ error("No signal named %s on interface %s", name, interface);
+ return FALSE;
}
static dbus_bool_t emit_signal_valist(DBusConnection *conn,