summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNishant Chaprana <n.chaprana@samsung.com>2019-09-27 15:21:16 +0530
committerNishant Chaprana <n.chaprana@samsung.com>2019-10-07 11:56:47 +0530
commit2367010ab69cc69e609ab275541838be289f531f (patch)
treebd79c60f10e6fd46e40e3102e4d0ef633437e6af
parent4b56bbc05a7e48de6209d03280c60bf53fceb91f (diff)
downloadconnman-2367010ab69cc69e609ab275541838be289f531f.tar.gz
connman-2367010ab69cc69e609ab275541838be289f531f.tar.bz2
connman-2367010ab69cc69e609ab275541838be289f531f.zip
Remove unwanted NULL check for service in append_properties()
Description: The service will be always allocated when append_properties() is called, so this NULL check is not required. This NULL check generates SVACE warning which is actually a FALSE alarm. Change-Id: I9b3a15529f6614cb375b8fb7ec656a3c44eeb180 Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
-rw-r--r--packaging/connman.spec2
-rw-r--r--src/service.c12
2 files changed, 6 insertions, 8 deletions
diff --git a/packaging/connman.spec b/packaging/connman.spec
index a2774df4..f4fa2a99 100644
--- a/packaging/connman.spec
+++ b/packaging/connman.spec
@@ -5,7 +5,7 @@
Name: connman
Version: 1.37
-Release: 34
+Release: 35
License: GPL-2.0+
Summary: Connection Manager
Url: http://connman.net
diff --git a/src/service.c b/src/service.c
index 9cbfa6ce..b06471da 100644
--- a/src/service.c
+++ b/src/service.c
@@ -3435,18 +3435,16 @@ static void append_properties(DBusMessageIter *dict, dbus_bool_t limited,
#if defined TIZEN_EXT
unsigned int frequency = 0U;
- if (service && service->network) {
- frequency = connman_network_get_frequency(service->network);
- connman_dbus_dict_append_basic(dict, "Frequency",
- DBUS_TYPE_UINT16, &frequency);
- }
-
unsigned char *wifi_vsie;
unsigned int wifi_vsie_len;
GSList *vsie_list = NULL;
- if (service->network)
+ if (service->network) {
+ frequency = connman_network_get_frequency(service->network);
+ connman_dbus_dict_append_basic(dict, "Frequency",
+ DBUS_TYPE_UINT16, &frequency);
vsie_list = (GSList *)connman_network_get_vsie_list(service->network);
+ }
if (vsie_list) {
GSList *list;