summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJukka Rissanen <jukka.rissanen@linux.intel.com>2012-04-19 15:29:53 +0300
committerMarcel Holtmann <marcel@holtmann.org>2012-04-19 14:39:20 +0200
commit9a7efe890445f2036bffb1c45f6f945d472bada8 (patch)
tree0fc925fae08ce69832a69296d308b48cbe2b3789
parent4d4034d013c14ff303bd21b9cf5035001f2fd798 (diff)
downloadconnman-9a7efe890445f2036bffb1c45f6f945d472bada8.tar.gz
connman-9a7efe890445f2036bffb1c45f6f945d472bada8.tar.bz2
connman-9a7efe890445f2036bffb1c45f6f945d472bada8.zip
service: Changing default service was not correctly checked
Let the default_changed() function check whether the default service is really changed as it is doing it correctly every time. The extra check in the __connman_service_indicate_default() function is causing problems if the user is moving services around. Then we might be using the old DNS service data because DNS code did not get information that default service was changed. Fixes BMC#25027
-rw-r--r--src/service.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/service.c b/src/service.c
index a0e8a11f..d14431a9 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4662,12 +4662,7 @@ int __connman_service_clear_error(struct connman_service *service)
int __connman_service_indicate_default(struct connman_service *service)
{
- struct connman_service *current = __connman_service_get_default();
-
- DBG("service %p default %p", service, current);
-
- if (current == service)
- return 0;
+ DBG("service %p", service);
default_changed();