diff options
author | Milind Ramesh Murhekar <m.murhekar@samsung.com> | 2017-10-16 13:22:03 +0530 |
---|---|---|
committer | taesub kim <taesub.kim@samsung.com> | 2017-10-16 16:58:58 +0900 |
commit | e6637f83c3a33ebab633ba104855bae3d7ce24c6 (patch) | |
tree | 18ffb8b00e185a212e71209f9739af88adaff0c3 | |
parent | e7e8ebca6943ccdbf7079291672669ce263cb4ca (diff) | |
download | connman-e6637f83c3a33ebab633ba104855bae3d7ce24c6.tar.gz connman-e6637f83c3a33ebab633ba104855bae3d7ce24c6.tar.bz2 connman-e6637f83c3a33ebab633ba104855bae3d7ce24c6.zip |
Fix SVACE issue for CID:24236, 31182submit/tizen_4.0/20171016.080645
Description: This patch fixes the SVACE issue
for remove() function.
Change-Id: Ie9fedadb8e36d91f9a197635eb4cee6a89ad7f7b
Signed-off-by: Milind Ramesh Murhekar <m.murhekar@samsung.com>
-rwxr-xr-x | src/log.c | 9 |
1 files changed, 6 insertions, 3 deletions
@@ -77,13 +77,15 @@ static void __connman_log_update_file_revision(int rev) next_log_file = g_strdup_printf("%s.%d", LOG_FILE_PATH, next_log_rev); if (next_log_rev >= MAX_LOG_COUNT) - remove(next_log_file); + if (remove(next_log_file) != 0) + __connman_log_s(LOG_INFO, "error: remove failed for %s", next_log_file); if (access(next_log_file, F_OK) == 0) __connman_log_update_file_revision(next_log_rev); if (rename(log_file, next_log_file) != 0) - remove(log_file); + if (remove(log_file) != 0) + __connman_log_s(LOG_INFO, "error: remove failed for %s", log_file); g_free(log_file); g_free(next_log_file); @@ -100,7 +102,8 @@ static void __connman_log_make_backup(void) __connman_log_update_file_revision(rev); if (rename(LOG_FILE_PATH, backup) != 0) - remove(LOG_FILE_PATH); + if (remove(LOG_FILE_PATH) != 0) + __connman_log_s(LOG_INFO, "error: remove failed for %s", LOG_FILE_PATH); g_free(backup); } |