diff options
author | Steinar H. Gunderson <sesse@google.com> | 2007-09-28 15:53:10 +0000 |
---|---|---|
committer | Steinar H. Gunderson <sesse@google.com> | 2007-09-28 15:53:10 +0000 |
commit | 55d44d3be6da57aab752af316c25c8623d8a728d (patch) | |
tree | 012db4938f4c83144c67504a2738b8f10d976f62 /ares_fds.c | |
parent | c24cd24870f59bcfec461472d100ee78cc41a423 (diff) | |
download | c-ares-55d44d3be6da57aab752af316c25c8623d8a728d.tar.gz c-ares-55d44d3be6da57aab752af316c25c8623d8a728d.tar.bz2 c-ares-55d44d3be6da57aab752af316c25c8623d8a728d.zip |
Always register for TCP events even if there are no outstanding queries, as the other side could always close the connection, which is a valid event which should be responded to.
Diffstat (limited to 'ares_fds.c')
-rw-r--r-- | ares_fds.c | 13 |
1 files changed, 8 insertions, 5 deletions
@@ -30,20 +30,23 @@ int ares_fds(ares_channel channel, fd_set *read_fds, fd_set *write_fds) ares_socket_t nfds; int i; - /* No queries, no file descriptors. */ - if (!channel->queries) - return 0; - nfds = 0; for (i = 0; i < channel->nservers; i++) { server = &channel->servers[i]; - if (server->udp_socket != ARES_SOCKET_BAD) + /* We only need to register interest in UDP sockets if we have + * outstanding queries. + */ + if (channel->queries && server->udp_socket != ARES_SOCKET_BAD) { FD_SET(server->udp_socket, read_fds); if (server->udp_socket >= nfds) nfds = server->udp_socket + 1; } + /* We always register for TCP events, because we want to know + * when the other side closes the connection, so we don't waste + * time trying to use a broken connection. + */ if (server->tcp_socket != ARES_SOCKET_BAD) { FD_SET(server->tcp_socket, read_fds); |