diff options
author | Alan Modra <amodra@gmail.com> | 2014-07-08 15:24:06 +0930 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2014-07-08 19:42:03 +0930 |
commit | bffebb6ba5b4ddbca7353626d682f9f974584dbf (patch) | |
tree | 093877e73fca460e1b1f378024e210b46ddc1f00 /bfd/targets.c | |
parent | 161ac41e03a819bc34e8c70a3fd1bc26f43858a2 (diff) | |
download | binutils-bffebb6ba5b4ddbca7353626d682f9f974584dbf.tar.gz binutils-bffebb6ba5b4ddbca7353626d682f9f974584dbf.tar.bz2 binutils-bffebb6ba5b4ddbca7353626d682f9f974584dbf.zip |
Copy st_other for linker script symbol assignments
This fixes a problem seen on powerpc64le ELFv2 when creating a
function symbol alias with ld --defsym. st_other needs to be copied
from the source symbol to the alias in order to set up the local entry
offset for the alias. I decided to make this change in the generic
ELF code rather than in elf64-ppc.c since it looks like other targets
that use st_other bits might benefit too.
bfd/
* elflink.c (_bfd_elf_copy_link_hash_symbol_type): Copy st_other
bits from source to dest.
* linker.c (_bfd_generic_copy_link_hash_symbol_type): Update comment.
* targets.c (struct bfd_target <_bfd_copy_link_hash_symbol_type>):
Likewise.
* bfd-in2.h: Regenerate.
ld/testsuite/
* ld-powerpc/defsym.s, * ld-powerpc/defsym.d: New test.
* ld-powerpc/powerpc.exp: Run it.
Diffstat (limited to 'bfd/targets.c')
-rw-r--r-- | bfd/targets.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/bfd/targets.c b/bfd/targets.c index 83131d1cfde..81a36959d42 100644 --- a/bfd/targets.c +++ b/bfd/targets.c @@ -478,7 +478,8 @@ BFD_JUMP_TABLE macros. . {* Indicate that we are only retrieving symbol values from this section. *} . void (*_bfd_link_just_syms) (asection *, struct bfd_link_info *); . -. {* Copy the symbol type of a linker hash table entry. *} +. {* Copy the symbol type and other attributes for a linker script +. assignment of one symbol to another. *} .#define bfd_copy_link_hash_symbol_type(b, t, f) \ . BFD_SEND (b, _bfd_copy_link_hash_symbol_type, (b, t, f)) . void (*_bfd_copy_link_hash_symbol_type) |